Eric Dumazet ff999198ec net-timestamp: convert sk->sk_tskey to atomic_t ... [ Upstream commit a1cdec57e0 ] UDP sendmsg() can be lockless, this is causing all kinds of data races. This patch converts sk->sk_tskey to remove one of these races. BUG: KCSAN: data-race in __ip_append_data / __ip_append_data read to 0xffff8881035d4b6c of 4 bytes by task 8877 on cpu 1: __ip_append_data+0x1c1/0x1de0 net/ipv4/ip_output.c:994 ip_make_skb+0x13f/0x2d0 net/ipv4/ip_output.c:1636 udp_sendmsg+0x12bd/0x14c0 net/ipv4/udp.c:1249 inet_sendmsg+0x5f/0x80 net/ipv4/af_inet.c:819 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg net/socket.c:725 [inline] ____sys_sendmsg+0x39a/0x510 net/socket.c:2413 ___sys_sendmsg net/socket.c:2467 [inline] __sys_sendmmsg+0x267/0x4c0 net/socket.c:2553 __do_sys_sendmmsg net/socket.c:2582 [inline] __se_sys_sendmmsg net/socket.c:2579 [inline] __x64_sys_sendmmsg+0x53/0x60 net/socket.c:2579 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae write to 0xffff8881035d4b6c of 4 bytes by task 8880 on cpu 0: __ip_append_data+0x1d8/0x1de0 net/ipv4/ip_output.c:994 ip_make_skb+0x13f/0x2d0 net/ipv4/ip_output.c:1636 udp_sendmsg+0x12bd/0x14c0 net/ipv4/udp.c:1249 inet_sendmsg+0x5f/0x80 net/ipv4/af_inet.c:819 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg net/socket.c:725 [inline] ____sys_sendmsg+0x39a/0x510 net/socket.c:2413 ___sys_sendmsg net/socket.c:2467 [inline] __sys_sendmmsg+0x267/0x4c0 net/socket.c:2553 __do_sys_sendmmsg net/socket.c:2582 [inline] __se_sys_sendmmsg net/socket.c:2579 [inline] __x64_sys_sendmmsg+0x53/0x60 net/socket.c:2579 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae value changed: 0x0000054d -> 0x0000054e Reported by Kernel Concurrency Sanitizer on: CPU: 0 PID: 8880 Comm: syz-executor.5 Not tainted 5.17.0-rc2-syzkaller-00167-gdcb85f85fa6f-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Fixes: 09c2d251b7 ("net-timestamp: add key to disambiguate concurrent datagrams") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Willem de Bruijn <willemb@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-02 11:48:01 +01:00
..
ila	net: Add MODULE_DESCRIPTION entries to network modules	2020-06-20 21:33:57 -07:00
netfilter	netfilter: ip6t_rt: fix rt0_hdr parsing in rt_mt6	2021-10-14 23:08:35 +02:00
addrconf_core.c	ipv6: add ipv6_dev_find to stubs	2021-03-30 13:29:39 -07:00
addrconf.c	ipv6: mcast: use rcu-safe version of ipv6_get_lladdr()	2022-02-23 12:03:10 +01:00
addrlabel.c	ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init	2020-11-25 11:20:16 -08:00
af_inet6.c	net: ipv6: add fib6_nh_release_dsts stub	2021-12-01 09:04:49 +01:00
ah6.c	xfrm: remove hdr_offset indirection	2021-06-11 14:48:50 +02:00
anycast.c	ipv6: fix memory leaks on IPV6_ADDRFORM path	2020-07-30 16:30:55 -07:00
calipso.c	cipso,calipso: resolve a number of problems with the DOI refcounts	2021-03-04 15:26:57 -08:00
datagram.c	lsm,selinux: pass flowi_common instead of flowi to the LSM hooks	2020-11-23 18:36:21 -05:00
esp6_offload.c	xfrm: remove description from xfrm_type struct	2021-06-09 09:38:52 +02:00
esp6.c	ipv6: check return value of ipv6_skip_exthdr	2021-12-08 09:04:40 +01:00
exthdrs_core.c
exthdrs_offload.c
exthdrs.c	ipv6: exthdrs: get rid of indirect calls in ip6_parse_tlv()	2021-08-04 10:34:40 +01:00
fib6_notifier.c
fib6_rules.c	ipv6: fix memory leak in fib6_rule_suppress	2021-12-08 09:04:43 +01:00
fou6.c	net: Add MODULE_DESCRIPTION entries to network modules	2020-06-20 21:33:57 -07:00
icmp.c	icmp: ICMPV6: Examine invoking packet for Segment Route Headers.	2022-01-27 11:05:05 +01:00
inet6_connection_sock.c	lsm,selinux: pass flowi_common instead of flowi to the LSM hooks	2020-11-23 18:36:21 -05:00
inet6_hashtables.c	net: prefer socket bound to interface when not in VRF	2021-10-07 07:27:55 -07:00
ioam6_iptunnel.c	ipv6: ioam: move the check for undefined bits	2021-10-12 11:49:49 +01:00
ioam6.c	ipv6: ioam: move the check for undefined bits	2021-10-12 11:49:49 +01:00
ip6_checksum.c
ip6_fib.c	ipv6: annotate accesses to fn->fn_sernum	2022-02-01 17:27:09 +01:00
ip6_flowlabel.c	ipv6: per-netns exclusive flowlabel checks	2022-02-23 12:03:10 +01:00
ip6_gre.c	xfrm: fix policy lookup for ipv6 gre packets	2022-01-27 11:05:14 +01:00
ip6_icmp.c	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-02-23 11:29:52 -08:00
ip6_input.c	ipv6: weaken the v4mapped source check	2021-03-18 11:19:23 -07:00
ip6_offload.c	gso: do not skip outer ip header in case of ipip and net_failover	2022-03-02 11:47:56 +01:00
ip6_offload.h
ip6_output.c	net-timestamp: convert sk->sk_tskey to atomic_t	2022-03-02 11:48:01 +01:00
ip6_tunnel.c	ipv6_tunnel: Rate limit warning messages	2022-02-01 17:27:07 +01:00
ip6_udp_tunnel.c	net: Make locking in sock_bindtoindex optional	2020-06-01 14:57:14 -07:00
ip6_vti.c	ip6_vti: initialize __ip6_tnl_parm struct in vti6_siocdevprivate	2022-01-11 15:35:17 +01:00
ip6mr.c	ipmr,ip6mr: acquire RTNL before calling ip[6]mr_free_table() on failure path	2022-02-16 12:56:29 +01:00
ipcomp6.c	xfrm: remove hdr_offset indirection	2021-06-11 14:48:50 +02:00
ipv6_sockglue.c	net/ipv4/ipv6: Replace one-element arraya with flexible-array members	2021-08-05 11:46:42 +01:00
Kconfig	ipv6: ioam: Support for IOAM injection with lwtunnels	2021-07-21 08:14:33 -07:00
Makefile	ipv6: ioam: Support for IOAM injection with lwtunnels	2021-07-21 08:14:33 -07:00
mcast_snoop.c	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-04-27 14:02:06 -07:00
mcast.c	ipv6: mcast: use rcu-safe version of ipv6_get_lladdr()	2022-02-23 12:03:10 +01:00
mip6.c	xfrm: ipv6: move mip6_rthdr_offset into xfrm core	2021-06-11 14:48:50 +02:00
ndisc.c	ipv6: add IFLA_INET6_RA_MTU to expose mtu value	2021-08-27 17:29:18 -07:00
netfilter.c	netfilter: Dissect flow after packet mangling	2021-04-18 22:04:16 +02:00
output_core.c	ipv6: use prandom_u32() for ID generation	2021-05-31 22:12:08 -07:00
ping.c	lsm,selinux: pass flowi_common instead of flowi to the LSM hooks	2020-11-23 18:36:21 -05:00
proc.c	net: udp: introduce UDP_MIB_MEMERRORS for udp_mem	2020-11-09 15:34:44 -08:00
protocol.c
raw.c	ipv6: raw: check passed optlen before reading	2022-01-11 15:35:18 +01:00
reassembly.c	ipv6: record frag_max_size in atomic fragments in input path	2021-05-21 15:02:25 -07:00
route.c	ipv6: fix data-race in fib6_info_hw_flags_set / fib6_purge_rt	2022-02-23 12:03:10 +01:00
rpl_iptunnel.c	net: ipv6: rpl_iptunnel: simplify the return expression of rpl_do_srh()	2020-12-08 16:22:54 -08:00
rpl.c	net: ipv6: rpl*: Fix strange kerneldoc warnings due to bad header	2020-10-30 12:12:52 -07:00
seg6_hmac.c	crypto: sha - split sha.h into sha1.h and sha2.h	2020-11-20 14:45:33 +11:00
seg6_iptunnel.c	seg6: fix the iif in the IPv6 socket control block	2021-12-14 10:57:09 +01:00
seg6_local.c	seg6: export get_srh() for ICMP handling	2022-01-27 11:05:05 +01:00
seg6.c	icmp: ICMPV6: Examine invoking packet for Segment Route Headers.	2022-01-27 11:05:05 +01:00
sit.c	sit: do not call ipip6_dev_free() from sit_init_net()	2021-12-22 09:32:44 +01:00
syncookies.c	selinux/stable-5.11 PR 20201214	2020-12-16 11:01:04 -08:00
sysctl_net_ipv6.c	ipv6: ioam: Data plane support for Pre-allocated Trace	2021-07-21 08:14:33 -07:00
tcp_ipv6.c	inet: fully convert sk->sk_rx_dst to RCU rules	2021-12-29 12:28:42 +01:00
tcpv6_offload.c
tunnel6.c	tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels	2020-07-09 12:52:37 +02:00
udp_impl.h	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
udp_offload.c	udp: properly complete L4 GRO over UDP tunnel packet	2021-03-30 17:06:49 -07:00
udp.c	udp6: Use Segment Routing Header for dest address if present	2022-01-27 11:05:05 +01:00
udplite.c	net/ipv6: remove compat_ipv6_{get,set}sockopt	2020-07-19 18:16:41 -07:00
xfrm6_input.c	xfrm: state: remove extract_input indirection from xfrm_state_afinfo	2020-05-06 09:40:08 +02:00
xfrm6_output.c	net: ipv6: fix return value of ip6_skb_dst_mtu	2021-07-02 11:57:01 -07:00
xfrm6_policy.c
xfrm6_protocol.c	xfrm: add support for UDPv6 encapsulation of ESP	2020-04-28 11:28:36 +02:00
xfrm6_state.c	xfrm: remove output_finish indirection from xfrm_state_afinfo	2020-05-06 09:40:08 +02:00
xfrm6_tunnel.c	xfrm: remove description from xfrm_type struct	2021-06-09 09:38:52 +02:00