mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-18 16:44:27 +08:00
ad5f604e18
The dso__find_symbol_by_name() should be have idx pointer argument.
Found during the build-test.
$ make build-test
...
CC /tmp/tmp.6JwPK1xbWG/tests/pe-file-parsing.o
tests/pe-file-parsing.c: In function ‘run_dir’:
tests/pe-file-parsing.c:64:15: error: too few arguments to function ‘dso__find_symbol_by_name’
64 | sym = dso__find_symbol_by_name(dso, "main");
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from tests/pe-file-parsing.c:16:
/usr/local/google/home/namhyung/project/linux/tools/perf/util/symbol.h:135:16: note: declared here
135 | struct symbol *dso__find_symbol_by_name(struct dso *dso, const char *name, size_t *idx);
| ^~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 259dce914e ("perf symbol: Remove symbol_name_rb_node")
Acked-by: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230627063257.549005-1-namhyung@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
102 lines
2.5 KiB
C
102 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <stdbool.h>
|
|
#include <inttypes.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/types.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
#include <subcmd/exec-cmd.h>
|
|
|
|
#include "debug.h"
|
|
#include "util/build-id.h"
|
|
#include "util/symbol.h"
|
|
#include "util/dso.h"
|
|
|
|
#include "tests.h"
|
|
|
|
#ifdef HAVE_LIBBFD_SUPPORT
|
|
|
|
static int run_dir(const char *d)
|
|
{
|
|
char filename[PATH_MAX];
|
|
char debugfile[PATH_MAX];
|
|
struct build_id bid;
|
|
char debuglink[PATH_MAX];
|
|
char expect_build_id[] = {
|
|
0x5a, 0x0f, 0xd8, 0x82, 0xb5, 0x30, 0x84, 0x22,
|
|
0x4b, 0xa4, 0x7b, 0x62, 0x4c, 0x55, 0xa4, 0x69,
|
|
};
|
|
char expect_debuglink[PATH_MAX] = "pe-file.exe.debug";
|
|
struct dso *dso;
|
|
struct symbol *sym;
|
|
int ret;
|
|
size_t idx;
|
|
|
|
scnprintf(filename, PATH_MAX, "%s/pe-file.exe", d);
|
|
ret = filename__read_build_id(filename, &bid);
|
|
TEST_ASSERT_VAL("Failed to read build_id",
|
|
ret == sizeof(expect_build_id));
|
|
TEST_ASSERT_VAL("Wrong build_id", !memcmp(bid.data, expect_build_id,
|
|
sizeof(expect_build_id)));
|
|
|
|
ret = filename__read_debuglink(filename, debuglink, PATH_MAX);
|
|
TEST_ASSERT_VAL("Failed to read debuglink", ret == 0);
|
|
TEST_ASSERT_VAL("Wrong debuglink",
|
|
!strcmp(debuglink, expect_debuglink));
|
|
|
|
scnprintf(debugfile, PATH_MAX, "%s/%s", d, debuglink);
|
|
ret = filename__read_build_id(debugfile, &bid);
|
|
TEST_ASSERT_VAL("Failed to read debug file build_id",
|
|
ret == sizeof(expect_build_id));
|
|
TEST_ASSERT_VAL("Wrong build_id", !memcmp(bid.data, expect_build_id,
|
|
sizeof(expect_build_id)));
|
|
|
|
dso = dso__new(filename);
|
|
TEST_ASSERT_VAL("Failed to get dso", dso);
|
|
|
|
ret = dso__load_bfd_symbols(dso, debugfile);
|
|
TEST_ASSERT_VAL("Failed to load symbols", ret == 0);
|
|
|
|
dso__sort_by_name(dso);
|
|
sym = dso__find_symbol_by_name(dso, "main", &idx);
|
|
TEST_ASSERT_VAL("Failed to find main", sym);
|
|
dso__delete(dso);
|
|
|
|
return TEST_OK;
|
|
}
|
|
|
|
static int test__pe_file_parsing(struct test_suite *test __maybe_unused,
|
|
int subtest __maybe_unused)
|
|
{
|
|
struct stat st;
|
|
char path_dir[PATH_MAX];
|
|
|
|
/* First try development tree tests. */
|
|
if (!lstat("./tests", &st))
|
|
return run_dir("./tests");
|
|
|
|
/* Then installed path. */
|
|
snprintf(path_dir, PATH_MAX, "%s/tests", get_argv_exec_path());
|
|
|
|
if (!lstat(path_dir, &st))
|
|
return run_dir(path_dir);
|
|
|
|
return TEST_SKIP;
|
|
}
|
|
|
|
#else
|
|
|
|
static int test__pe_file_parsing(struct test_suite *test __maybe_unused,
|
|
int subtest __maybe_unused)
|
|
{
|
|
return TEST_SKIP;
|
|
}
|
|
|
|
#endif
|
|
|
|
DEFINE_SUITE("PE file support", pe_file_parsing);
|