mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-30 15:44:13 +08:00
2062f9fb64
Update stub IOMMU driver (which main purpose is to reuse generic IOMMU device-tree bindings by Xen grant DMA-mapping layer on Arm) according to the recent changes done in the following commit57365a04c9("iommu: Move bus setup to IOMMU device registration"). With probe_device() callback being called during IOMMU device registration, the uninitialized callback just leads to the "kernel NULL pointer dereference" issue during boot. Fix that by adding a dummy callback. Looks like the release_device() callback is not mandatory to be implemented as IOMMU framework makes sure that callback is initialized before dereferencing. Reported-by: Viresh Kumar <viresh.kumar@linaro.org> Fixes:57365a04c9("iommu: Move bus setup to IOMMU device registration") Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> Tested-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Link: https://lore.kernel.org/r/20230208153649.3604857-1-olekstysh@gmail.com Signed-off-by: Juergen Gross <jgross@suse.com>
86 lines
1.9 KiB
C
86 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Stub IOMMU driver which does nothing.
|
|
* The main purpose of it being present is to reuse generic IOMMU device tree
|
|
* bindings by Xen grant DMA-mapping layer.
|
|
*
|
|
* Copyright (C) 2022 EPAM Systems Inc.
|
|
*/
|
|
|
|
#include <linux/iommu.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
struct grant_dma_iommu_device {
|
|
struct device *dev;
|
|
struct iommu_device iommu;
|
|
};
|
|
|
|
static struct iommu_device *grant_dma_iommu_probe_device(struct device *dev)
|
|
{
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
|
|
/* Nothing is really needed here except a dummy probe_device callback */
|
|
static const struct iommu_ops grant_dma_iommu_ops = {
|
|
.probe_device = grant_dma_iommu_probe_device,
|
|
};
|
|
|
|
static const struct of_device_id grant_dma_iommu_of_match[] = {
|
|
{ .compatible = "xen,grant-dma" },
|
|
{ },
|
|
};
|
|
|
|
static int grant_dma_iommu_probe(struct platform_device *pdev)
|
|
{
|
|
struct grant_dma_iommu_device *mmu;
|
|
int ret;
|
|
|
|
mmu = devm_kzalloc(&pdev->dev, sizeof(*mmu), GFP_KERNEL);
|
|
if (!mmu)
|
|
return -ENOMEM;
|
|
|
|
mmu->dev = &pdev->dev;
|
|
|
|
ret = iommu_device_register(&mmu->iommu, &grant_dma_iommu_ops, &pdev->dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
platform_set_drvdata(pdev, mmu);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int grant_dma_iommu_remove(struct platform_device *pdev)
|
|
{
|
|
struct grant_dma_iommu_device *mmu = platform_get_drvdata(pdev);
|
|
|
|
platform_set_drvdata(pdev, NULL);
|
|
iommu_device_unregister(&mmu->iommu);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver grant_dma_iommu_driver = {
|
|
.driver = {
|
|
.name = "grant-dma-iommu",
|
|
.of_match_table = grant_dma_iommu_of_match,
|
|
},
|
|
.probe = grant_dma_iommu_probe,
|
|
.remove = grant_dma_iommu_remove,
|
|
};
|
|
|
|
static int __init grant_dma_iommu_init(void)
|
|
{
|
|
struct device_node *iommu_np;
|
|
|
|
iommu_np = of_find_matching_node(NULL, grant_dma_iommu_of_match);
|
|
if (!iommu_np)
|
|
return 0;
|
|
|
|
of_node_put(iommu_np);
|
|
|
|
return platform_driver_register(&grant_dma_iommu_driver);
|
|
}
|
|
subsys_initcall(grant_dma_iommu_init);
|