Chao Yu b19f73b46b f2fs: fix to update user block counts in block_operations() ... [ Upstream commit f06c0f82e3 ] Commit 59c9081bc8 ("f2fs: allow write page cache when writting cp") allows write() to write data to page cache during checkpoint, so block count fields like .total_valid_block_count, .alloc_valid_block_count and .rf_node_block_count may encounter race condition as below: CP Thread A - write_checkpoint - block_operations - f2fs_down_write(&sbi->node_change) - __prepare_cp_block : ckpt->valid_block_count = .total_valid_block_count - f2fs_up_write(&sbi->node_change) - write - f2fs_preallocate_blocks - f2fs_map_blocks(,F2FS_GET_BLOCK_PRE_AIO) - f2fs_map_lock - f2fs_down_read(&sbi->node_change) - f2fs_reserve_new_blocks - inc_valid_block_count : percpu_counter_add(&sbi->alloc_valid_block_count, count) : sbi->total_valid_block_count += count - f2fs_up_read(&sbi->node_change) - do_checkpoint : sbi->last_valid_block_count = sbi->total_valid_block_count : percpu_counter_set(&sbi->alloc_valid_block_count, 0) : percpu_counter_set(&sbi->rf_node_block_count, 0) - fsync - need_do_checkpoint - f2fs_space_for_roll_forward : alloc_valid_block_count was reset to zero, so, it may missed last data during checkpoint Let's change to update .total_valid_block_count, .alloc_valid_block_count and .rf_node_block_count in block_operations(), then their access can be protected by .node_change and .cp_rwsem lock, so that it can avoid above race condition. Fixes: 59c9081bc8 ("f2fs: allow write page cache when writting cp") Cc: Yunlei He <heyunlei@oppo.com> Signed-off-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-08-03 08:49:48 +02:00
..
9p	9p: add missing locking around taking dentry fid list	2024-06-16 13:41:37 +02:00
adfs
affs	affs: initialize fsdata in affs_truncate()	2023-02-01 08:34:08 +01:00
afs	afs: Don't cross .backup mountpoint from backup volume	2024-06-16 13:41:31 +02:00
autofs	autofs: fix memory leak of waitqueues in autofs_catatonic_mode	2023-09-23 11:10:59 +02:00
befs
bfs
btrfs	btrfs: do not BUG_ON on failure to get dir index for new snapshot	2024-07-27 11:32:19 +02:00
cachefiles	cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie()	2024-07-25 09:49:21 +02:00
ceph	ceph: switch to corrected encoding of max_xattr_size in mdsmap	2024-03-15 10:48:13 -04:00
coda	coda: Avoid partial allocation of sig_inputArgs	2023-03-10 09:33:52 +01:00
configfs	configfs: fix possible memory leak in configfs_create_dir()	2022-12-31 13:32:22 +01:00
cramfs	fs/cramfs/inode.c: initialize file_ra_state	2023-03-10 09:34:09 +01:00
crypto	blk-crypto: add a blk_crypto_config_supported_natively helper	2023-05-11 23:03:00 +09:00
debugfs	debugfs: fix automount d_fsdata usage	2024-01-20 11:50:04 +01:00
devpts
dlm	fs: dlm: don't put dlm_local_addrs on heap	2024-02-16 19:06:29 +01:00
ecryptfs	ecryptfs: Fix buffer size for tag 66 packet	2024-06-12 11:03:04 +02:00
efivarfs	efivarfs: Request at most 512 bytes for variable names	2024-03-06 14:45:11 +00:00
efs
erofs	erofs: ensure m_llen is reset to 0 if metadata is invalid	2024-07-25 09:49:18 +02:00
exfat	exfat: support handle zero-size directory	2023-11-28 17:07:00 +00:00
exportfs	exportfs: use pr_debug for unreachable debug statements	2024-03-06 14:45:15 +00:00
ext2	ext2: Verify bitmap and itable block numbers before using them	2024-08-03 08:49:32 +02:00
ext4	ext4: make sure the first directory block is not a hole	2024-08-03 08:49:34 +02:00
f2fs	f2fs: fix to update user block counts in block_operations()	2024-08-03 08:49:48 +02:00
fat	fat: fix uninitialized field in nostale filehandles	2024-04-03 15:19:27 +02:00
freevxfs
fscache	netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume()	2024-07-25 09:49:20 +02:00
fuse	fuse: verify {g,u}id mount options correctly	2024-08-03 08:49:31 +02:00
gfs2	gfs2: Fix slab-use-after-free in gfs2_qd_dealloc	2024-07-05 09:32:00 +02:00
hfs	hfs: fix to initialize fields of hfs_inode_info after hfs_alloc_inode()	2024-08-03 08:49:32 +02:00
hfsplus	hfsplus: fix to avoid false alarm of circular locking	2024-08-03 08:48:53 +02:00
hostfs	hostfs: move from strlcpy with unused retval to strscpy	2022-09-19 22:46:25 +02:00
hpfs
hugetlbfs	mm/hugetlb: add hugetlb_folio_subpool() helpers	2024-05-17 11:55:51 +02:00
iomap	iomap: Fix iomap_adjust_read_range for plen calculation	2024-07-25 09:49:12 +02:00
isofs	isofs: handle CDs with bad root inode but good Joliet root directory	2024-04-13 13:05:06 +02:00
jbd2	jbd2: make jbd2_journal_get_max_txn_bufs() internal	2024-08-03 08:49:35 +02:00
jffs2	jffs2: Fix potential illegal address access in jffs2_free_inode	2024-07-11 12:47:09 +02:00
jfs	jfs: Fix array-index-out-of-bounds in diFree	2024-08-03 08:49:47 +02:00
kernfs	kernfs: Convert kernfs_path_from_node_locked() from strlcpy() to strscpy()	2024-08-03 08:48:54 +02:00
lockd	lockd: fix file selection in nlmsvc_cancel_blocked	2024-03-06 14:45:16 +00:00
minix	vfs: open inside ->tmpfile()	2022-09-24 07:00:00 +02:00
netfs	netfs: Only call folio_start_fscache() one time for each folio	2023-10-06 14:56:32 +02:00
nfs	NFSv4.1 another fix for EXCHGID4_FLAG_USE_PNFS_DS for DS server	2024-08-03 08:49:16 +02:00
nfs_common
nfsd	knfsd: LOOKUP can return an illegal error value	2024-06-21 14:35:55 +02:00
nilfs2	nilfs2: handle inconsistent state in nilfs_btnode_create_block()	2024-08-03 08:49:46 +02:00
nls	fs/nls: make load_nls() take a const parameter	2023-09-13 09:42:22 +02:00
notify	fanotify: disallow mount/sb marks on kernel internal pseudo fs	2023-07-19 16:22:05 +02:00
ntfs	- hfs and hfsplus kmap API modernization from Fabio Francesco	2022-10-12 11:00:22 -07:00
ntfs3	fs/ntfs3: Update log->page_{mask,bits} if log->page_size changed	2024-08-03 08:49:37 +02:00
ocfs2	ocfs2: add bounds checking to ocfs2_check_dir_entry()	2024-07-27 11:32:18 +02:00
omfs
openpromfs	openpromfs: finish conversion to the new mount API	2024-06-12 11:03:03 +02:00
orangefs	orangefs: fix out-of-bounds fsid access	2024-07-11 12:47:08 +02:00
overlayfs	ovl: remove upper umask handling from ovl_create_upper()	2024-06-12 11:03:39 +02:00
proc	fs/proc/task_mmu: indicate PM_FILE for PMD-mapped file THP	2024-08-03 08:49:28 +02:00
pstore	pstore/zone: Add a null pointer check to the psz_kmsg_read	2024-04-13 13:04:57 +02:00
qnx4
qnx6	fs/qnx6: delete unnecessary checks before brelse()	2022-09-11 21:55:07 -07:00
quota	quota: Fix rcu annotations of inode dquot pointers	2024-03-26 18:20:47 -04:00
ramfs	shmem: use ramfs_kill_sb() for kill_sb method of ramfs-based tmpfs	2023-07-19 16:22:11 +02:00
reiserfs	reiserfs: Check the return value from __getblk()	2023-09-13 09:42:27 +02:00
romfs
smb	cifs: mount with "unix" mount option for SMB1 incorrectly handled	2024-08-03 08:49:33 +02:00
squashfs	revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"	2023-02-22 12:59:50 +01:00
sysfs	fs: sysfs: Fix reference leak in sysfs_break_active_protection()	2024-04-27 17:07:16 +02:00
sysv	sysv: don't call sb_bread() with pointers_lock held	2024-04-13 13:05:05 +02:00
tracefs	tracefs: Add missing lockdown check to tracefs_create_dir()	2023-09-23 11:11:12 +02:00
ubifs	ubifs: Set page uptodate in the correct place	2024-04-03 15:19:27 +02:00
udf	udf: Avoid using corrupted block bitmap buffer	2024-08-03 08:49:34 +02:00
ufs	ufs: replace ll_rw_block()	2022-09-11 20:26:07 -07:00
unicode
vboxsf	vboxsf: Avoid an spurious warning if load_nls_xxx() fails	2024-04-10 16:28:25 +02:00
verity	fsverity: skip PKCS#7 parser when keyring is empty	2023-09-13 09:43:03 +02:00
xfs	xfs: short circuit xfs_growfs_data_private() if delta is zero	2024-05-25 16:21:34 +02:00
zonefs	zonefs: Improve error handling	2024-02-23 09:12:45 +01:00
aio.c	fs/aio: Check IOCB_AIO_RW before the struct aio_kiocb conversion	2024-04-03 15:19:42 +02:00
anon_inodes.c	dynamic_dname(): drop unused dentry argument	2022-08-20 11:34:04 -04:00
attr.c	attr: block mode changes of symlinks	2023-09-23 11:11:10 +02:00
bad_inode.c	vfs: open inside ->tmpfile()	2022-09-24 07:00:00 +02:00
binfmt_elf_fdpic.c	fs: binfmt_elf_efpic: fix personality for ELF-FDPIC	2023-10-06 14:57:06 +02:00
binfmt_elf_test.c
binfmt_elf.c	mm: always expand the stack with the mmap write lock held	2023-07-01 13:16:25 +02:00
binfmt_flat.c
binfmt_misc.c	binfmt_misc: fix shift-out-of-bounds in check_special_flags	2022-12-31 13:32:57 +01:00
binfmt_script.c
buffer.c	- hfs and hfsplus kmap API modernization from Fabio Francesco	2022-10-12 11:00:22 -07:00
char_dev.c	chardev: fix error handling in cdev_device_add()	2022-12-31 13:32:41 +01:00
compat_binfmt_elf.c
coredump.c	coredump: Move dump_emit_page() to kill unused warning	2023-02-22 12:59:50 +01:00
d_path.c	d_path.c: typo fix...	2022-08-20 11:34:33 -04:00
dax.c	Merge branch 'for-6.0/dax' into libnvdimm-fixes	2022-09-24 18:14:12 -07:00
dcache.c	fs: better handle deep ancestor chains in is_subdir()	2024-07-25 09:49:18 +02:00
direct-io.c	block: remove PSI accounting from the bio layer	2022-09-20 08:24:38 -06:00
drop_caches.c
eventfd.c	eventfd: prevent underflow for eventfd semaphores	2023-09-13 09:42:27 +02:00
eventpoll.c	epoll: be better about file lifetimes	2024-06-12 11:03:03 +02:00
exec.c	exec: Fix NOMMU linux_binprm::exec in transfer_args_to_stack()	2024-04-03 15:19:48 +02:00
fcntl.c	fs: Fix rw_hint validation	2024-03-26 18:20:28 -04:00
fhandle.c	do_sys_name_to_handle(): use kzalloc() to fix kernel-infoleak	2024-03-26 18:20:27 -04:00
file_table.c
file.c	fs/file: fix the check in find_next_fd()	2024-07-25 09:49:12 +02:00
filesystems.c
fs_context.c	vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing	2023-09-13 09:42:28 +02:00
fs_parser.c	ext4: journal_path mount options should follow links	2023-01-07 11:11:59 +01:00
fs_pin.c
fs_struct.c
fs_types.c
fs-writeback.c	writeback, cgroup: switch inodes with dirty timestamps to release dying cgwbs	2023-11-20 11:51:50 +01:00
fsopen.c
init.c
inode.c	filemap: add a per-mapping stable writes flag	2024-01-10 17:10:32 +01:00
internal.h	nfs: use vfs setgid helper	2023-08-30 16:11:10 +02:00
ioctl.c	lsm: new security_file_ioctl_compat() hook	2024-01-31 16:17:00 -08:00
Kconfig	smb: move client and server files to common directory fs/smb	2023-06-28 11:12:40 +02:00
Kconfig.binfmt	Xtensa updates for v6.1	2022-10-10 14:21:11 -07:00
kernel_read_file.c
libfs.c	libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value	2022-12-31 13:31:58 +01:00
locks.c	filelock: Fix fcntl/close race recovery compat path	2024-07-27 11:32:19 +02:00
Makefile	smb: move client and server files to common directory fs/smb	2023-06-28 11:12:40 +02:00
mbcache.c	ext4: fix deadlock due to mbcache entry corruption	2023-01-07 11:12:02 +01:00
mount.h
mpage.c
namei.c	rename(): fix the locking of subdirectories	2024-01-31 16:17:02 -08:00
namespace.c	fs: relax mount_setattr() permission checks	2024-02-23 09:12:46 +01:00
no-block.c
nsfs.c	dynamic_dname(): drop unused dentry argument	2022-08-20 11:34:04 -04:00
open.c	ftruncate: pass a signed offset	2024-07-05 09:31:59 +02:00
pipe.c	fs/pipe: Fix lockdep false-positive in watchqueue pipe_write()	2024-04-10 16:28:30 +02:00
pnode.c	pnode: terminate at peers of source	2023-01-04 11:29:01 +01:00
pnode.h
posix_acl.c	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
proc_namespace.c
read_write.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
readdir.c
remap_range.c
select.c	fs/select: rework stack allocation hack for clang	2024-03-26 18:20:28 -04:00
seq_file.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
signalfd.c
splice.c	mm: merge folio_has_private()/filemap_release_folio() call pairs	2024-01-10 17:10:31 +01:00
stack.c
stat.c	vfs: support STATX_DIOALIGN on block devices	2022-09-11 19:47:12 -05:00
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-24 17:32:51 +01:00
super.c	fs: Protect reconfiguration of sb read-write from racing writes	2023-08-11 12:08:24 +02:00
sync.c
sysctls.c
timerfd.c
userfaultfd.c	Fix userfaultfd_api to return EINVAL as expected	2024-07-18 13:18:41 +02:00
utimes.c
xattr.c	fs: don't audit the capability check in simple_xattr_list()	2022-12-31 13:31:55 +01:00