linux/drivers/net/can/softing
Julia Lawall da78b7998e can: softing: softing_main: ensure a consistent return value in error case
Typically, the return value desired for the failure of a function with an
integer return value is a negative integer.  In these cases, the return
value is sometimes a negative integer and sometimes 0, due to a subsequent
initialization of the return variable within the loop.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)

//<smpl>
@r exists@
identifier ret;
position p;
constant C;
expression e1,e3,e4;
statement S;
@@

ret = -C
... when != ret = e3
    when any
if@p (...) S
... when any
if (\(ret != 0\|ret < 0\|ret > 0\) || ...) { ... return ...; }
... when != ret = e3
    when any
*if@p (...)
{
  ... when != ret = e4
  return ret;
}
//</smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2012-07-17 09:35:59 +02:00
..
Kconfig net/can/softing: make CAN_SOFTING_CS depend on CAN_SOFTING 2011-02-14 11:44:01 -08:00
Makefile
softing_cs.c pcmcia: Convert pcmcia_device_id declarations to const 2011-05-06 07:46:22 +02:00
softing_fw.c net: remove mm.h inclusion from netdevice.h 2011-06-21 19:17:20 -07:00
softing_main.c can: softing: softing_main: ensure a consistent return value in error case 2012-07-17 09:35:59 +02:00
softing_platform.h
softing.h Fix common misspellings 2011-03-31 11:26:23 -03:00