linux/lib/zstd/compress
Nick Terrell ae8d67b211 lib: zstd: Fix unused variable warning
The variable `litLengthSum` is only used by an `assert()`, so when
asserts are disabled the compiler doesn't see any usage and warns.

This issue is already fixed upstream by PR #2838 [0]. It was reported
by the Kernel test robot in [1].

Another approach would be to change zstd's disabled `assert()`
definition to use the argument in a disabled branch, instead of
ignoring the argument. I've avoided this approach because there are
some small changes necessary to get zstd to build, and I would
want to thoroughly re-test for performance, since that is slightly
changing the code in every function in zstd. It seems like a
trivial change, but some functions are pretty sensitive to small
changes. However, I think it is a valid approach that I would
like to see upstream take, so I've opened Issue #2868 to attempt
this upstream.

Lastly, I've chosen not to use __maybe_unused because all code
in lib/zstd/ must eventually be upstreamed. Upstream zstd can't
use __maybe_unused because it isn't portable across all compilers.

[0] https://github.com/facebook/zstd/pull/2838
[1] https://lore.kernel.org/linux-mm/202111120312.833wII4i-lkp@intel.com/T/
[2] https://github.com/facebook/zstd/issues/2868

Link: https://lore.kernel.org/r/20211117014949.1169186-2-nickrterrell@gmail.com/
Link: https://lore.kernel.org/r/20211117201459.1194876-2-nickrterrell@gmail.com/

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nick Terrell <terrelln@fb.com>
2021-11-18 13:12:26 -08:00
..
fse_compress.c
hist.c
hist.h
huf_compress.c
zstd_compress_internal.h
zstd_compress_literals.c
zstd_compress_literals.h
zstd_compress_sequences.c
zstd_compress_sequences.h
zstd_compress_superblock.c
zstd_compress_superblock.h
zstd_compress.c
zstd_cwksp.h
zstd_double_fast.c
zstd_double_fast.h
zstd_fast.c
zstd_fast.h
zstd_lazy.c
zstd_lazy.h
zstd_ldm_geartab.h
zstd_ldm.c
zstd_ldm.h
zstd_opt.c
zstd_opt.h