mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-15 08:14:15 +08:00
e4e9bfb7c9
Calling ipa_cmd_pipeline_clear() after stopping the channel underlying the AP<-modem RX endpoint can lead to a deadlock. This occurs in the ->runtime_suspend device power operation for the IPA driver. While this callback is in progress, any other requests for power will block until the callback returns. Stopping the AP<-modem RX channel does not prevent the modem from sending another packet to this endpoint. If a packet arrives for an RX channel when the channel is stopped, an SUSPEND IPA interrupt condition will be pending. Handling an IPA interrupt requires power, so ipa_isr_thread() calls pm_runtime_get_sync() first thing. The problem occurs because a "pipeline clear" command will not complete while such a SUSPEND interrupt condition exists. So the SUSPEND IPA interrupt handler won't proceed until it gets power; that won't happen until the ->runtime_suspend callback (and its "pipeline clear" command) completes; and that can't happen while the SUSPEND interrupt condition exists. It turns out that in this case there is no need to use the "pipeline clear" command. There are scenarios in which clearing the pipeline is required while suspending, but those are not (yet) supported upstream. So a simple fix, avoiding the potential deadlock, is to stop calling ipa_cmd_pipeline_clear() in ipa_endpoint_suspend(). This removes the only user of ipa_cmd_pipeline_clear(), so get rid of that function. It can be restored again whenever it's needed. This is basically a manual revert along with an explanation for commit |
||
|---|---|---|
| .. | ||
| gsi_private.h | ||
| gsi_reg.h | ||
| gsi_trans.c | ||
| gsi_trans.h | ||
| gsi.c | ||
| gsi.h | ||
| ipa_cmd.c | ||
| ipa_cmd.h | ||
| ipa_data-v3.1.c | ||
| ipa_data-v3.5.1.c | ||
| ipa_data-v4.2.c | ||
| ipa_data-v4.5.c | ||
| ipa_data-v4.9.c | ||
| ipa_data-v4.11.c | ||
| ipa_data.h | ||
| ipa_endpoint.c | ||
| ipa_endpoint.h | ||
| ipa_gsi.c | ||
| ipa_gsi.h | ||
| ipa_interrupt.c | ||
| ipa_interrupt.h | ||
| ipa_main.c | ||
| ipa_mem.c | ||
| ipa_mem.h | ||
| ipa_modem.c | ||
| ipa_modem.h | ||
| ipa_power.c | ||
| ipa_power.h | ||
| ipa_qmi_msg.c | ||
| ipa_qmi_msg.h | ||
| ipa_qmi.c | ||
| ipa_qmi.h | ||
| ipa_reg.c | ||
| ipa_reg.h | ||
| ipa_resource.c | ||
| ipa_resource.h | ||
| ipa_smp2p.c | ||
| ipa_smp2p.h | ||
| ipa_sysfs.c | ||
| ipa_sysfs.h | ||
| ipa_table.c | ||
| ipa_table.h | ||
| ipa_uc.c | ||
| ipa_uc.h | ||
| ipa_version.h | ||
| ipa.h | ||
| Kconfig | ||
| Makefile | ||