David Howells 4c0421fa6d iov: Fix netfs_extract_user_to_sg() ... Fix the loop check in netfs_extract_user_to_sg() for extraction from user-backed iterators to do the body if npages > 0, not if npages < 0 (which it can never be). This isn't currently used by cifs, which only ever extracts data from BVEC, KVEC and XARRAY iterators at this level, user-backed iterators having being decanted into BVEC iterators at a higher level to accommodate the work being done in a kernel thread. Found by smatch: fs/netfs/iterator.c:139 netfs_extract_user_to_sg() warn: unsigned 'npages' is never less than zero. Fixes: 0185846975 ("netfs: Add a function to extract an iterator into a scatterlist") Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/oe-kbuild-all/202302261115.P3TQi1ZO-lkp@intel.com/ Reported-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/r/Y/yYnAhoAYDBKixX@kili Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com> Signed-off-by: David Howells <dhowells@redhat.com> cc: Jeff Layton <jlayton@kernel.org> cc: linux-cifs@vger.kernel.org cc: linux-cachefs@redhat.com Signed-off-by: Steve French <stfrench@microsoft.com>		2023-03-01 18:18:25 -06:00
..
buffered_read.c	netfs: Fix dodgy maths	2022-11-15 16:56:07 +00:00
internal.h	netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context	2022-06-09 13:55:00 -07:00
io.c	use less confusing names for iov_iter direction initializers	2022-11-25 13:01:55 -05:00
iterator.c	iov: Fix netfs_extract_user_to_sg()	2023-03-01 18:18:25 -06:00
Kconfig	netfs: Make CONFIG_NETFS_SUPPORT auto-selected rather than manual	2021-05-25 13:48:04 +01:00
main.c	netfs: Split some core bits out into their own file	2022-03-18 09:29:05 +00:00
Makefile	netfs: Add a function to extract a UBUF or IOVEC into a BVEC iterator	2023-02-20 17:25:43 -06:00
objects.c	netfs: Rename the netfs_io_request cleanup op and give it an op pointer	2022-06-10 20:55:21 +01:00
stats.c	netfs: Add a netfs inode context	2022-03-18 09:29:05 +00:00