linux/Documentation/misc-devices
Paul Bolle aa98a28563 Documentation/misc-devices/mei/mei-amt-version.c: remove unneeded call of mei_deinit()
Building mei-amt-version.o triggers a GCC warning:
    Documentation/misc-devices/mei/mei-amt-version.c: In function 'main':
    Documentation/misc-devices/mei/mei-amt-version.c:103:5: warning: 'acmd.fd' is used uninitialized in this function [-Wuninitialized]
      if (cl->fd != -1)
         ^
    Documentation/misc-devices/mei/mei-amt-version.c:443:21: note: 'acmd.fd' was declared here
      struct amt_host_if acmd;
                         ^

GCC is correct. See, the call chain that GCC detects must be
    main()
        amt_host_if_init()
            mei_init()
                mei_deinit()

But when we enter mei_deinit() struct amt_host_if acmd is still
unitialized. That makes the test for (effectively) amt_host_if->mei_cl->fd
bogus.

But it turns out that call of mei_deinit() isn't needed at all. All of
the members of mei_cl will be set later in mei_init() and none will be
used before they are set. So we can simply drop this call of
mei_deinit().

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Cc: Tomas Winkler <tomas.winkler@intel.com>
Reported-by: David Howells <dhowells@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08 15:20:20 -08:00
..
mei Documentation/misc-devices/mei/mei-amt-version.c: remove unneeded call of mei_deinit() 2014-01-08 15:20:20 -08:00
ad525x_dpot.txt ad525x_dpot: new driver for AD525x digital potentiometers 2009-12-15 08:53:25 -08:00
apds990x.txt Documentation: short descriptions for bh1770glc and apds990x drivers 2010-10-26 16:52:14 -07:00
bh1770glc.txt Documentation: short descriptions for bh1770glc and apds990x drivers 2010-10-26 16:52:14 -07:00
c2port.txt Documentation: update broken web addresses. 2010-08-04 15:21:40 +02:00
eeprom i2c: Move misc devices documentation 2009-10-04 22:53:40 +02:00
ics932s401 Fix common misspellings 2011-03-31 11:26:23 -03:00
isl29003
lis3lv02d lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer 2012-09-05 13:44:04 -07:00
max6875 max6875: Discard obsolete detect method 2009-10-04 22:53:41 +02:00
spear-pcie-gadget.txt ST SPEAr: PCIE gadget suppport 2011-03-22 17:44:10 -07:00