mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-16 07:24:39 +08:00
cbd38332c1
clang-16 warns about casting functions to incompatible types, as is done
here to call clk_disable_unprepare:
drivers/nvmem/meson-efuse.c:78:12: error: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
78 | (void(*)(void *))clk_disable_unprepare,
The pattern of getting, enabling and setting a disable callback for a
clock can be replaced with devm_clk_get_enabled(), which also fixes
this warning.
Fixes: 611fbca1c8 ("nvmem: meson-efuse: add peripheral clock")
Cc: Stable@vger.kernel.org
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20240224114023.85535-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
103 lines
2.5 KiB
C
103 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Amlogic Meson GX eFuse Driver
|
|
*
|
|
* Copyright (c) 2016 Endless Computers, Inc.
|
|
* Author: Carlo Caione <carlo@endlessm.com>
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/module.h>
|
|
#include <linux/nvmem-provider.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/firmware/meson/meson_sm.h>
|
|
|
|
static int meson_efuse_read(void *context, unsigned int offset,
|
|
void *val, size_t bytes)
|
|
{
|
|
struct meson_sm_firmware *fw = context;
|
|
|
|
return meson_sm_call_read(fw, (u8 *)val, bytes, SM_EFUSE_READ, offset,
|
|
bytes, 0, 0, 0);
|
|
}
|
|
|
|
static int meson_efuse_write(void *context, unsigned int offset,
|
|
void *val, size_t bytes)
|
|
{
|
|
struct meson_sm_firmware *fw = context;
|
|
|
|
return meson_sm_call_write(fw, (u8 *)val, bytes, SM_EFUSE_WRITE, offset,
|
|
bytes, 0, 0, 0);
|
|
}
|
|
|
|
static const struct of_device_id meson_efuse_match[] = {
|
|
{ .compatible = "amlogic,meson-gxbb-efuse", },
|
|
{ /* sentinel */ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, meson_efuse_match);
|
|
|
|
static int meson_efuse_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct meson_sm_firmware *fw;
|
|
struct device_node *sm_np;
|
|
struct nvmem_device *nvmem;
|
|
struct nvmem_config *econfig;
|
|
struct clk *clk;
|
|
unsigned int size;
|
|
|
|
sm_np = of_parse_phandle(pdev->dev.of_node, "secure-monitor", 0);
|
|
if (!sm_np) {
|
|
dev_err(&pdev->dev, "no secure-monitor node\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
fw = meson_sm_get(sm_np);
|
|
of_node_put(sm_np);
|
|
if (!fw)
|
|
return -EPROBE_DEFER;
|
|
|
|
clk = devm_clk_get_enabled(dev, NULL);
|
|
if (IS_ERR(clk))
|
|
return dev_err_probe(dev, PTR_ERR(clk), "failed to get efuse gate");
|
|
|
|
if (meson_sm_call(fw, SM_EFUSE_USER_MAX, &size, 0, 0, 0, 0, 0) < 0) {
|
|
dev_err(dev, "failed to get max user");
|
|
return -EINVAL;
|
|
}
|
|
|
|
econfig = devm_kzalloc(dev, sizeof(*econfig), GFP_KERNEL);
|
|
if (!econfig)
|
|
return -ENOMEM;
|
|
|
|
econfig->dev = dev;
|
|
econfig->name = dev_name(dev);
|
|
econfig->add_legacy_fixed_of_cells = true;
|
|
econfig->stride = 1;
|
|
econfig->word_size = 1;
|
|
econfig->reg_read = meson_efuse_read;
|
|
econfig->reg_write = meson_efuse_write;
|
|
econfig->size = size;
|
|
econfig->priv = fw;
|
|
|
|
nvmem = devm_nvmem_register(&pdev->dev, econfig);
|
|
|
|
return PTR_ERR_OR_ZERO(nvmem);
|
|
}
|
|
|
|
static struct platform_driver meson_efuse_driver = {
|
|
.probe = meson_efuse_probe,
|
|
.driver = {
|
|
.name = "meson-efuse",
|
|
.of_match_table = meson_efuse_match,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(meson_efuse_driver);
|
|
|
|
MODULE_AUTHOR("Carlo Caione <carlo@endlessm.com>");
|
|
MODULE_DESCRIPTION("Amlogic Meson GX NVMEM driver");
|
|
MODULE_LICENSE("GPL v2");
|