linux/drivers/infiniband/hw/cxgb4
Alexey Kodanev cab30a9835 RDMA/cxgb4: remove unnecessary NULL check in __c4iw_poll_cq_one()
If 'qhp' is NULL then 'wq' is also NULL:

    struct t4_wq *wq = qhp ? &qhp->wq : NULL;
    ...
    ret = poll_cq(wq, ...);
    if (ret)
        goto out;

poll_cq(wq, ...) always returns a non-zero status if 'wq' is NULL,
either on a t4_next_cqe() error or on a 'wq == NULL' check.

Therefore, checking 'qhp' again after poll_cq() is redundant.

BTW, there're also 'qhp' dereference cases below poll_cq() without
any checks (c4iw_invalidate_mr(qhp->rhp,...)).

Detected using the static analysis tool - Svace.

Fixes: 4ab39e2f98 ("RDMA/cxgb4: Make c4iw_poll_cq_one() easier to analyze")
Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Link: https://lore.kernel.org/r/20221215123030.155378-1-aleksei.kodanev@bell-sw.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
2022-12-27 15:27:59 +02:00
..
cm.c treewide: use get_random_u32() when possible 2022-10-11 17:42:58 -06:00
cq.c RDMA/cxgb4: remove unnecessary NULL check in __c4iw_poll_cq_one() 2022-12-27 15:27:59 +02:00
device.c RDMA: Remove redundant 'flush_workqueue()' calls 2021-10-12 13:21:23 -03:00
ev.c RDMA/iw_cxgb4: Fix refcount underflow while destroying cqs. 2021-08-05 22:33:00 -03:00
id_table.c treewide: use get_random_u32_below() instead of deprecated function 2022-11-18 02:15:15 +01:00
iw_cxgb4.h RDMA: Split kernel-only global device caps from uverbs device caps 2022-04-06 15:02:13 -03:00
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
mem.c RDMA/cxgb4: Remove MW support 2020-10-26 19:27:44 -03:00
provider.c RDMA: Split kernel-only global device caps from uverbs device caps 2022-04-06 15:02:13 -03:00
qp.c RDMA/cxgb4: Set queue pair state when being queried 2022-01-05 15:51:51 -04:00
resource.c RDMA/cxgb4: add missing qpid increment 2021-04-20 09:36:00 -03:00
restrack.c RDMA: Use kzalloc for allocating only one thing 2021-01-07 16:47:53 -04:00
t4.h RDMA: Delete not-used static inline functions 2021-03-22 09:31:19 -03:00
t4fw_ri_api.h RDMA: Replace zero-length array with flexible-array member 2020-02-20 13:33:51 -04:00