mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2025-01-10 15:54:39 +08:00
4f88f8747f
The major drawback of commit7e34f4e4aa("drm/i915/gen8+: Add RC6 CTX corruption WA") is that it disables RC6 while Skylake (and friends) is active, and we do not consider the GPU idle until all outstanding requests have been retired and the engine switched over to the kernel context. If userspace is idle, this task falls onto our background idle worker, which only runs roughly once a second, meaning that userspace has to have been idle for a couple of seconds before we enable RC6 again. Naturally, this causes us to consume considerably more energy than before as powersaving is effectively disabled while a display server (here's looking at you Xorg) is running. As execlists will get a completion event as each context is completed, we can use this interrupt to queue a retire worker bound to this engine to cleanup idle timelines. We will then immediately notice the idle engine (without userspace intervention or the aid of the background retire worker) and start parking the GPU. Thus during light workloads, we will do much more work to idle the GPU faster... Hopefully with commensurate power saving! v2: Watch context completions and only look at those local to the engine when retiring to reduce the amount of excess work we perform. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112315 References:7e34f4e4aa("drm/i915/gen8+: Add RC6 CTX corruption WA") References:2248a28384("drm/i915/gen8+: Add RC6 CTX corruption WA") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20191125105858.1718307-3-chris@chris-wilson.co.uk
33 lines
914 B
C
33 lines
914 B
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#ifndef INTEL_GT_REQUESTS_H
|
|
#define INTEL_GT_REQUESTS_H
|
|
|
|
struct intel_engine_cs;
|
|
struct intel_gt;
|
|
struct intel_timeline;
|
|
|
|
long intel_gt_retire_requests_timeout(struct intel_gt *gt, long timeout);
|
|
static inline void intel_gt_retire_requests(struct intel_gt *gt)
|
|
{
|
|
intel_gt_retire_requests_timeout(gt, 0);
|
|
}
|
|
|
|
void intel_engine_init_retire(struct intel_engine_cs *engine);
|
|
void intel_engine_add_retire(struct intel_engine_cs *engine,
|
|
struct intel_timeline *tl);
|
|
void intel_engine_fini_retire(struct intel_engine_cs *engine);
|
|
|
|
int intel_gt_wait_for_idle(struct intel_gt *gt, long timeout);
|
|
|
|
void intel_gt_init_requests(struct intel_gt *gt);
|
|
void intel_gt_park_requests(struct intel_gt *gt);
|
|
void intel_gt_unpark_requests(struct intel_gt *gt);
|
|
void intel_gt_fini_requests(struct intel_gt *gt);
|
|
|
|
#endif /* INTEL_GT_REQUESTS_H */
|