Linus Torvalds e4178d809f printk: fix syslog() overflowing user buffer ... This is not a buffer overflow in the traditional sense: we don't overflow any *kernel* buffers, but we do mis-count the amount of data we copy back to user space for the SYSLOG_ACTION_READ_ALL case. In particular, if the user buffer is too small to hold everything, and *if* there is a continuation line at just the right place, we can end up giving the user more data than he asked for. The reason is that we first count up the number of bytes all the log records contains, then we walk the records again until we've skipped the records at the beginning that won't fit, and then we walk the rest of the records and copy them to the user space buffer. And in between that "skip the initial records that won't fit" and the "copy the records that *will* fit to user space", we reset the 'prev' variable that contained the record information for the last record not copied. That meant that when we started copying to user space, we now had a different character count than what we had originally calculated in the first record walk-through. The fix is to simply not clear the 'prev' flags value (in both cases where we had the same logic: syslog_print_all and kmsg_dump_get_buffer: the latter is used for pstore-like dumping) Reported-and-tested-by: Debabrata Banerjee <dbanerje@akamai.com> Acked-by: Kay Sievers <kay@vrfy.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jeff Mahoney <jeffm@suse.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2014-02-17 12:24:45 -08:00
..
braille.c	printk: Fix return of braille_register_console()	2013-08-06 13:18:12 -07:00
braille.h	printk: move braille console support into separate braille.[ch] files	2013-07-31 14:41:03 -07:00
console_cmdline.h	printk: add console_cmdline.h	2013-07-31 14:41:03 -07:00
Makefile	printk: move braille console support into separate braille.[ch] files	2013-07-31 14:41:03 -07:00
printk.c	printk: fix syslog() overflowing user buffer	2014-02-17 12:24:45 -08:00