Kuninori Morimoto a122a116fc ASoC: rsnd: call rsnd_ssi_master_clk_start() from rsnd_ssi_init() ... Current rsnd needs to call .prepare (P) for clock settings, .trigger for playback start (S) and stop (E). It should be called as below from SSI point of view. P -> S -> E -> P -> S -> E -> ... But, if you used MIXer, below case might happen (2) 1: P -> S ---> E -> ... 2: P ----> S -> ... (1) (3) P(1) setups clock, but E(2) resets it. and starts playback (3). In such case, it will reports "SSI parent/child should use same rate". rsnd_ssi_master_clk_start() which is the main function at (P) was called from rsnd_ssi_init() (= S) before, but was moved by below patch to rsnd_soc_dai_prepare() (= P) to avoid using clk_get_rate() which shouldn't be used under atomic context. commit 4d230d1271 ("ASoC: rsnd: fixup not to call clk_get/set under non-atomic") Because of above patch, rsnd_ssi_master_clk_start() is now called at (P) which is for non atomic context. But (P) is assuming that spin lock is *not* used. One issue now is rsnd_ssi_master_clk_start() is checking ssi->xxx which should be protected by spin lock. After above patch, adg.c had below patch for other reasons. commit 06e8f5c842 ("ASoC: rsnd: don't call clk_get_rate() under atomic context") clk_get_rate() is used at probe() timing by this patch. In other words, rsnd_ssi_master_clk_start() is no longer using clk_get_rate() any more. This means we can call it from rsnd_ssi_init() (= S) again which is protected by spin lock. This patch re-move it to under spin lock, and solves 1. checking ssi->xxx without spin lock issue. 2. clk setting / device start / device stop race condition. Reported-by: Linh Phung T. Y. <linh.phung.jy@renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/875z0x1jt5.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org>		2021-04-14 15:24:09 +01:00
..
ac97	ALSA: ac97: Constify static struct attribute_group	2021-01-31 09:49:58 +01:00
aoa	ALSA: Convert strlcpy to strscpy when return value is unused	2021-01-08 09:30:05 +01:00
arm	ARM updates for 5.12-rc1:	2021-02-22 14:27:07 -08:00
atmel	ALSA: atmel: ac97: clarify operator precedence	2020-09-03 09:27:34 +02:00
core	ALSA: led control - add sysfs kcontrol LED marking layer	2021-03-30 15:41:30 +02:00
drivers	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
firewire	ALSA: dice: fix null pointer dereference when node is disconnected	2021-03-12 14:12:53 +01:00
hda	ALSA: hda: ignore invalid NHLT table	2021-03-04 09:14:36 +01:00
i2c	ALSA: Convert strlcpy to strscpy when return value is unused	2021-01-08 09:30:05 +01:00
isa	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
mips	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
oss	ALSA: Convert strlcpy to strscpy when return value is unused	2021-01-08 09:30:05 +01:00
parisc
pci	ALSA: HDA - remove the custom implementation for the audio LED trigger	2021-03-30 15:35:15 +02:00
pcmcia	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
ppc	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
sh	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
soc	ASoC: rsnd: call rsnd_ssi_master_clk_start() from rsnd_ssi_init()	2021-04-14 15:24:09 +01:00
sparc	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
spi
synth
usb	sound fixes for 5.12-rc4	2021-03-19 09:53:32 -07:00
x86	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
xen	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
ac97_bus.c
Kconfig
last.c
Makefile
sound_core.c