Song Liu 9e2ad638ae bpf: Extend BTF_ID_LIST_GLOBAL with parameter for number of IDs ... syzbot reported the following BUG w/o CONFIG_DEBUG_INFO_BTF BUG: KASAN: global-out-of-bounds in task_iter_init+0x212/0x2e7 kernel/bpf/task_iter.c:661 Read of size 4 at addr ffffffff90297404 by task swapper/0/1 CPU: 1 PID: 1 Comm: swapper/0 Not tainted 5.15.0-syzkaller #0 Hardware name: ... Google Compute Engine, BIOS Google 01/01/2011 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 print_address_description.constprop.0.cold+0xf/0x309 mm/kasan/report.c:256 __kasan_report mm/kasan/report.c:442 [inline] kasan_report.cold+0x83/0xdf mm/kasan/report.c:459 task_iter_init+0x212/0x2e7 kernel/bpf/task_iter.c:661 do_one_initcall+0x103/0x650 init/main.c:1295 do_initcall_level init/main.c:1368 [inline] do_initcalls init/main.c:1384 [inline] do_basic_setup init/main.c:1403 [inline] kernel_init_freeable+0x6b1/0x73a init/main.c:1606 kernel_init+0x1a/0x1d0 init/main.c:1497 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 </TASK> This is caused by hard-coded name[1] in BTF_ID_LIST_GLOBAL (w/o CONFIG_DEBUG_INFO_BTF). Fix this by adding a parameter n to BTF_ID_LIST_GLOBAL. This avoids ifdef CONFIG_DEBUG_INFO_BTF in btf.c and filter.c. Fixes: 7c7e3d31e7 ("bpf: Introduce helper bpf_find_vma") Reported-by: syzbot+e0d81ec552a21d9071aa@syzkaller.appspotmail.com Reported-by: Eric Dumazet <edumazet@google.com> Suggested-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Song Liu <songliubraving@fb.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Yonghong Song <yhs@fb.com> Link: https://lore.kernel.org/bpf/20211112150243.1270987-2-songliubraving@fb.com		2021-11-12 10:19:09 -08:00
..
preload	bpf/preload: Clean up .gitignore and "clean-files" target	2021-10-20 10:39:04 -07:00
arraymap.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-10-28 10:43:58 -07:00
bloom_filter.c	bpf: Add missing map_delete_elem method to bloom filter map	2021-11-01 14:22:44 -07:00
bpf_inode_storage.c	bpf: Fix spelling mistakes	2021-05-24 21:13:05 -07:00
bpf_iter.c	bpf: Refactor BPF_PROG_RUN into a function	2021-08-17 00:45:07 +02:00
bpf_local_storage.c	bpf: Prevent deadlock from recursive bpf_task_storage_[get|delete]	2021-02-26 11:51:48 -08:00
bpf_lru_list.c	bpf_lru_list: Read double-checked variable once without lock	2021-02-10 15:54:26 -08:00
bpf_lru_list.h	bpf: Fix a typo "inacitve" -> "inactive"	2020-04-06 21:54:10 +02:00
bpf_lsm.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-06-17 11:54:56 -07:00
bpf_struct_ops_types.h	bpf: Add dummy BPF STRUCT_OPS for test purpose	2021-11-01 14:10:00 -07:00
bpf_struct_ops.c	bpf: Add dummy BPF STRUCT_OPS for test purpose	2021-11-01 14:10:00 -07:00
bpf_task_storage.c	bpf: Consolidate task_struct BTF_ID declarations	2021-08-25 10:37:05 -07:00
btf.c	bpf: Extend BTF_ID_LIST_GLOBAL with parameter for number of IDs	2021-11-12 10:19:09 -08:00
cgroup.c	bpf: Migrate cgroup_bpf to internal cgroup_bpf_attach_type enum	2021-08-23 17:50:24 -07:00
core.c	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-11-01 19:59:46 -07:00
cpumap.c	bpf: cpumap: Implement generic cpumap	2021-07-07 20:01:45 -07:00
devmap.c	bpf, devmap: Exclude XDP broadcast to master device	2021-08-09 23:25:14 +02:00
disasm.c	bpf: Relicense disassembler as GPL-2.0-only OR BSD-2-Clause	2021-09-02 14:49:23 +02:00
disasm.h	bpf: Relicense disassembler as GPL-2.0-only OR BSD-2-Clause	2021-09-02 14:49:23 +02:00
dispatcher.c	bpf: Remove bpf_image tree	2020-03-13 12:49:52 -07:00
hashtab.c	bpf: Replace callers of BPF_CAST_CALL with proper function typedef	2021-09-28 16:27:18 -07:00
helpers.c	bpf: Replace callers of BPF_CAST_CALL with proper function typedef	2021-09-28 16:27:18 -07:00
inode.c	bpf: Fix regression on BPF_OBJ_GET with non-O_RDWR flags	2021-06-22 14:57:43 +02:00
Kconfig	bpf: Disallow unprivileged bpf by default	2021-11-01 17:06:47 +01:00
local_storage.c	bpf: Increase supported cgroup storage value size	2021-07-27 15:59:29 -07:00
lpm_trie.c	bpf: Allow RCU-protected lookups to happen from bh context	2021-06-24 19:41:15 +02:00
Makefile	bpf: Add bloom filter map implementation	2021-10-28 13:22:49 -07:00
map_in_map.c	bpf: Remember BTF of inner maps.	2021-07-15 22:31:10 +02:00
map_in_map.h	bpf: Add map_meta_equal map ops	2020-08-28 15:41:30 +02:00
map_iter.c	bpf: Implement link_query callbacks in map element iterators	2020-08-21 14:01:39 -07:00
mmap_unlock_work.h	bpf: Introduce helper bpf_find_vma	2021-11-07 11:54:51 -08:00
net_namespace.c	bpf: Add support for forced LINK_DETACH command	2020-08-01 20:38:28 -07:00
offload.c	bpf, offload: Replace bitwise AND by logical AND in bpf_prog_offload_info_fill	2020-02-17 16:53:49 +01:00
percpu_freelist.c	bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI	2020-10-06 00:04:11 +02:00
percpu_freelist.h	bpf: Use raw_spin_trylock() for pcpu_freelist_push/pop in NMI	2020-10-06 00:04:11 +02:00
prog_iter.c	bpf: Refactor bpf_iter_reg to have separate seq_info member	2020-07-25 20:16:32 -07:00
queue_stack_maps.c	bpf: Eliminate rlimit-based memory accounting for queue_stack_maps maps	2020-12-02 18:32:46 -08:00
reuseport_array.c	bpf: Fix spelling mistakes	2021-05-24 21:13:05 -07:00
ringbuf.c	bpf: Fix false positive kmemleak report in bpf_ringbuf_area_alloc()	2021-06-28 15:57:46 +02:00
stackmap.c	bpf: Introduce helper bpf_find_vma	2021-11-07 11:54:51 -08:00
syscall.c	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-11-01 19:59:46 -07:00
sysfs_btf.c	bpf: Load and verify kernel module BTFs	2020-11-10 15:25:53 -08:00
task_iter.c	bpf: Introduce helper bpf_find_vma	2021-11-07 11:54:51 -08:00
tnum.c	bpf, tnums: Provably sound, faster, and more precise algorithm for tnum_mul	2021-06-01 13:34:15 +02:00
trampoline.c	bpf: Use u64_stats_t in struct bpf_prog_stats	2021-10-27 11:13:52 -07:00
verifier.c	bpf: Introduce helper bpf_find_vma	2021-11-07 11:54:51 -08:00