mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-04 09:34:12 +08:00
ee756ef749
Add reference count checking to struct dso, this can help with implementing correct reference counting discipline. To avoid RC_CHK_ACCESS everywhere, add accessor functions for the variables in struct dso. The majority of the change is mechanical in nature and not easy to split up. Committer testing: 'perf test' up to this patch shows no regressions. But: util/symbol.c: In function ‘dso__load_bfd_symbols’: util/symbol.c:1683:9: error: too few arguments to function ‘dso__set_adjust_symbols’ 1683 | dso__set_adjust_symbols(dso); | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from util/symbol.c:21: util/dso.h:268:20: note: declared here 268 | static inline void dso__set_adjust_symbols(struct dso *dso, bool val) | ^~~~~~~~~~~~~~~~~~~~~~~ make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:106: /tmp/tmp.ZWHbQftdN6/util/symbol.o] Error 1 MKDIR /tmp/tmp.ZWHbQftdN6/tests/workloads/ make[6]: *** Waiting for unfinished jobs.... This was updated: - symbols__fixup_end(&dso->symbols, false); - symbols__fixup_duplicate(&dso->symbols); - dso->adjust_symbols = 1; + symbols__fixup_end(dso__symbols(dso), false); + symbols__fixup_duplicate(dso__symbols(dso)); + dso__set_adjust_symbols(dso); But not build tested with BUILD_NONDISTRO and libbfd devel files installed (binutils-devel on fedora). Add the missing argument: symbols__fixup_end(dso__symbols(dso), false); symbols__fixup_duplicate(dso__symbols(dso)); - dso__set_adjust_symbols(dso); + dso__set_adjust_symbols(dso, true); Signed-off-by: Ian Rogers <irogers@google.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com> Cc: Ben Gainey <ben.gainey@arm.com> Cc: Changbin Du <changbin.du@huawei.com> Cc: Chengen Du <chengen.du@canonical.com> Cc: Colin Ian King <colin.i.king@gmail.com> Cc: Dima Kogan <dima@secretsauce.net> Cc: Ilkka Koskinen <ilkka@os.amperecomputing.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Clark <james.clark@arm.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: K Prateek Nayak <kprateek.nayak@amd.com> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Leo Yan <leo.yan@linux.dev> Cc: Li Dong <lidong@vivo.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paran Lee <p4ranlee@gmail.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Song Liu <song@kernel.org> Cc: Sun Haiyong <sunhaiyong@loongson.cn> Cc: Thomas Richter <tmricht@linux.ibm.com> Cc: Tiezhu Yang <yangtiezhu@loongson.cn> Cc: Yanteng Si <siyanteng@loongson.cn> Cc: zhaimingbing <zhaimingbing@cmss.chinamobile.com> Link: https://lore.kernel.org/r/20240504213803.218974-6-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
164 lines
4.2 KiB
C
164 lines
4.2 KiB
C
/*
|
|
* builtin-buildid-list.c
|
|
*
|
|
* Builtin buildid-list command: list buildids in perf.data, in the running
|
|
* kernel and in ELF files.
|
|
*
|
|
* Copyright (C) 2009, Red Hat Inc.
|
|
* Copyright (C) 2009, Arnaldo Carvalho de Melo <acme@redhat.com>
|
|
*/
|
|
#include "builtin.h"
|
|
#include "util/build-id.h"
|
|
#include "util/debug.h"
|
|
#include "util/dso.h"
|
|
#include "util/map.h"
|
|
#include <subcmd/pager.h>
|
|
#include <subcmd/parse-options.h>
|
|
#include "util/session.h"
|
|
#include "util/symbol.h"
|
|
#include "util/data.h"
|
|
#include "util/util.h"
|
|
#include <errno.h>
|
|
#include <inttypes.h>
|
|
#include <linux/err.h>
|
|
|
|
static int buildid__map_cb(struct map *map, void *arg __maybe_unused)
|
|
{
|
|
const struct dso *dso = map__dso(map);
|
|
char bid_buf[SBUILD_ID_SIZE];
|
|
const char *dso_long_name = dso__long_name(dso);
|
|
const char *dso_short_name = dso__short_name(dso);
|
|
|
|
memset(bid_buf, 0, sizeof(bid_buf));
|
|
if (dso__has_build_id(dso))
|
|
build_id__sprintf(dso__bid_const(dso), bid_buf);
|
|
printf("%s %16" PRIx64 " %16" PRIx64, bid_buf, map__start(map), map__end(map));
|
|
if (dso_long_name != NULL)
|
|
printf(" %s", dso_long_name);
|
|
else if (dso_short_name != NULL)
|
|
printf(" %s", dso_short_name);
|
|
|
|
printf("\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void buildid__show_kernel_maps(void)
|
|
{
|
|
struct machine *machine;
|
|
|
|
machine = machine__new_host();
|
|
machine__for_each_kernel_map(machine, buildid__map_cb, NULL);
|
|
machine__delete(machine);
|
|
}
|
|
|
|
static int sysfs__fprintf_build_id(FILE *fp)
|
|
{
|
|
char sbuild_id[SBUILD_ID_SIZE];
|
|
int ret;
|
|
|
|
ret = sysfs__sprintf_build_id("/", sbuild_id);
|
|
if (ret != sizeof(sbuild_id))
|
|
return ret < 0 ? ret : -EINVAL;
|
|
|
|
return fprintf(fp, "%s\n", sbuild_id);
|
|
}
|
|
|
|
static int filename__fprintf_build_id(const char *name, FILE *fp)
|
|
{
|
|
char sbuild_id[SBUILD_ID_SIZE];
|
|
int ret;
|
|
|
|
ret = filename__sprintf_build_id(name, sbuild_id);
|
|
if (ret != sizeof(sbuild_id))
|
|
return ret < 0 ? ret : -EINVAL;
|
|
|
|
return fprintf(fp, "%s\n", sbuild_id);
|
|
}
|
|
|
|
static bool dso__skip_buildid(struct dso *dso, int with_hits)
|
|
{
|
|
return with_hits && !dso__hit(dso);
|
|
}
|
|
|
|
static int perf_session__list_build_ids(bool force, bool with_hits)
|
|
{
|
|
struct perf_session *session;
|
|
struct perf_data data = {
|
|
.path = input_name,
|
|
.mode = PERF_DATA_MODE_READ,
|
|
.force = force,
|
|
};
|
|
|
|
symbol__elf_init();
|
|
/*
|
|
* See if this is an ELF file first:
|
|
*/
|
|
if (filename__fprintf_build_id(input_name, stdout) > 0)
|
|
goto out;
|
|
|
|
session = perf_session__new(&data, &build_id__mark_dso_hit_ops);
|
|
if (IS_ERR(session))
|
|
return PTR_ERR(session);
|
|
|
|
/*
|
|
* We take all buildids when the file contains AUX area tracing data
|
|
* because we do not decode the trace because it would take too long.
|
|
*/
|
|
if (!perf_data__is_pipe(&data) &&
|
|
perf_header__has_feat(&session->header, HEADER_AUXTRACE))
|
|
with_hits = false;
|
|
|
|
if (!perf_header__has_feat(&session->header, HEADER_BUILD_ID))
|
|
with_hits = true;
|
|
|
|
if (zstd_init(&(session->zstd_data), 0) < 0)
|
|
pr_warning("Decompression initialization failed. Reported data may be incomplete.\n");
|
|
|
|
/*
|
|
* in pipe-mode, the only way to get the buildids is to parse
|
|
* the record stream. Buildids are stored as RECORD_HEADER_BUILD_ID
|
|
*/
|
|
if (with_hits || perf_data__is_pipe(&data))
|
|
perf_session__process_events(session);
|
|
|
|
perf_session__fprintf_dsos_buildid(session, stdout, dso__skip_buildid, with_hits);
|
|
perf_session__delete(session);
|
|
out:
|
|
return 0;
|
|
}
|
|
|
|
int cmd_buildid_list(int argc, const char **argv)
|
|
{
|
|
bool show_kernel = false;
|
|
bool show_kernel_maps = false;
|
|
bool with_hits = false;
|
|
bool force = false;
|
|
const struct option options[] = {
|
|
OPT_BOOLEAN('H', "with-hits", &with_hits, "Show only DSOs with hits"),
|
|
OPT_STRING('i', "input", &input_name, "file", "input file name"),
|
|
OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
|
|
OPT_BOOLEAN('k', "kernel", &show_kernel, "Show current kernel build id"),
|
|
OPT_BOOLEAN('m', "kernel-maps", &show_kernel_maps,
|
|
"Show build id of current kernel + modules"),
|
|
OPT_INCR('v', "verbose", &verbose, "be more verbose"),
|
|
OPT_END()
|
|
};
|
|
const char * const buildid_list_usage[] = {
|
|
"perf buildid-list [<options>]",
|
|
NULL
|
|
};
|
|
|
|
argc = parse_options(argc, argv, options, buildid_list_usage, 0);
|
|
setup_pager();
|
|
|
|
if (show_kernel) {
|
|
return !(sysfs__fprintf_build_id(stdout) > 0);
|
|
} else if (show_kernel_maps) {
|
|
buildid__show_kernel_maps();
|
|
return 0;
|
|
}
|
|
|
|
return perf_session__list_build_ids(force, with_hits);
|
|
}
|