mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2025-01-11 00:04:33 +08:00
5222d69642
The test was previously using an mprotect on the heap memory allocated
using malloc and was expecting the allocation to be always using
sbrk(2). This is, however, not always true and in certain conditions
malloc may end up using anonymous mmaps for heap alloctions. This means
that the following condition that is used in the "lsm/file_mprotect"
program is not sufficent to detect all mprotect calls done on heap
memory:
is_heap = (vma->vm_start >= vma->vm_mm->start_brk &&
vma->vm_end <= vma->vm_mm->brk);
The test is updated to use an mprotect on memory allocated on the stack.
While this would result in the splitting of the vma, this happens only
after the security_file_mprotect hook. So, the condition used in the BPF
program holds true.
Fixes: 03e54f100d ("bpf: lsm: Add selftests for BPF_PROG_TYPE_LSM")
Reported-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: KP Singh <kpsingh@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200402200751.26372-1-kpsingh@chromium.org
87 lines
1.7 KiB
C
87 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
|
* Copyright (C) 2020 Google LLC.
|
|
*/
|
|
|
|
#include <test_progs.h>
|
|
#include <sys/mman.h>
|
|
#include <sys/wait.h>
|
|
#include <unistd.h>
|
|
#include <malloc.h>
|
|
#include <stdlib.h>
|
|
|
|
#include "lsm.skel.h"
|
|
|
|
char *CMD_ARGS[] = {"true", NULL};
|
|
|
|
#define GET_PAGE_ADDR(ADDR, PAGE_SIZE) \
|
|
(char *)(((unsigned long) (ADDR + PAGE_SIZE)) & ~(PAGE_SIZE-1))
|
|
|
|
int stack_mprotect(void)
|
|
{
|
|
void *buf;
|
|
long sz;
|
|
int ret;
|
|
|
|
sz = sysconf(_SC_PAGESIZE);
|
|
if (sz < 0)
|
|
return sz;
|
|
|
|
buf = alloca(sz * 3);
|
|
ret = mprotect(GET_PAGE_ADDR(buf, sz), sz,
|
|
PROT_READ | PROT_WRITE | PROT_EXEC);
|
|
return ret;
|
|
}
|
|
|
|
int exec_cmd(int *monitored_pid)
|
|
{
|
|
int child_pid, child_status;
|
|
|
|
child_pid = fork();
|
|
if (child_pid == 0) {
|
|
*monitored_pid = getpid();
|
|
execvp(CMD_ARGS[0], CMD_ARGS);
|
|
return -EINVAL;
|
|
} else if (child_pid > 0) {
|
|
waitpid(child_pid, &child_status, 0);
|
|
return child_status;
|
|
}
|
|
|
|
return -EINVAL;
|
|
}
|
|
|
|
void test_test_lsm(void)
|
|
{
|
|
struct lsm *skel = NULL;
|
|
int err, duration = 0;
|
|
|
|
skel = lsm__open_and_load();
|
|
if (CHECK(!skel, "skel_load", "lsm skeleton failed\n"))
|
|
goto close_prog;
|
|
|
|
err = lsm__attach(skel);
|
|
if (CHECK(err, "attach", "lsm attach failed: %d\n", err))
|
|
goto close_prog;
|
|
|
|
err = exec_cmd(&skel->bss->monitored_pid);
|
|
if (CHECK(err < 0, "exec_cmd", "err %d errno %d\n", err, errno))
|
|
goto close_prog;
|
|
|
|
CHECK(skel->bss->bprm_count != 1, "bprm_count", "bprm_count = %d\n",
|
|
skel->bss->bprm_count);
|
|
|
|
skel->bss->monitored_pid = getpid();
|
|
|
|
err = stack_mprotect();
|
|
if (CHECK(errno != EPERM, "stack_mprotect", "want err=EPERM, got %d\n",
|
|
errno))
|
|
goto close_prog;
|
|
|
|
CHECK(skel->bss->mprotect_count != 1, "mprotect_count",
|
|
"mprotect_count = %d\n", skel->bss->mprotect_count);
|
|
|
|
close_prog:
|
|
lsm__destroy(skel);
|
|
}
|