mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2025-01-01 19:34:35 +08:00
9955d4940e
The ethtool API for obtaining device statistics is not intended to allow runtime changes in the number of statistics reported. It may *appear* this way, as there is an ability to request the number of stats using ethtool_get_set_count(). However, it is expected that this must always return the same value for invocations of the same device. If we don't satisfy this contract, and allow the number of stats to change during run time, we could cause invalid memory accesses or report the stat strings incorrectly. This is because the API for obtaining stats is to (1) get the size, (2) get the strings and finally (3) get the stats. Since these are each separate ethtool op commands, it is not possible to maintain consistency by holding the RTNL lock over the whole operation. This results in the potential for a race condition to occur where the size changed between any of the 3 calls. Avoid this issue by requiring that we always return the same value for a given device. We can check any values which remain constant for the life of the device, but must not report different sizes depending on runtime attributes. This patch specifically fixes the VEB statistics strings to always be reported. Other issues will be fixed in future patches. Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> |
||
|---|---|---|
| .. | ||
| i40e_adminq_cmd.h | ||
| i40e_adminq.c | ||
| i40e_adminq.h | ||
| i40e_alloc.h | ||
| i40e_client.c | ||
| i40e_client.h | ||
| i40e_common.c | ||
| i40e_dcb_nl.c | ||
| i40e_dcb.c | ||
| i40e_dcb.h | ||
| i40e_debugfs.c | ||
| i40e_devids.h | ||
| i40e_diag.c | ||
| i40e_diag.h | ||
| i40e_ethtool.c | ||
| i40e_hmc.c | ||
| i40e_hmc.h | ||
| i40e_lan_hmc.c | ||
| i40e_lan_hmc.h | ||
| i40e_main.c | ||
| i40e_nvm.c | ||
| i40e_osdep.h | ||
| i40e_prototype.h | ||
| i40e_ptp.c | ||
| i40e_register.h | ||
| i40e_status.h | ||
| i40e_trace.h | ||
| i40e_txrx.c | ||
| i40e_txrx.h | ||
| i40e_type.h | ||
| i40e_virtchnl_pf.c | ||
| i40e_virtchnl_pf.h | ||
| i40e.h | ||
| Makefile | ||