Cong Wang 95278ddaa1 net_sched: convert idrinfo->lock from spinlock to a mutex ... In commit ec3ed293e7 ("net_sched: change tcf_del_walker() to take idrinfo->lock") we move fl_hw_destroy_tmplt() to a workqueue to avoid blocking with the spinlock held. Unfortunately, this causes a lot of troubles here: 1. tcf_chain_destroy() could be called right after we queue the work but before the work runs. This is a use-after-free. 2. The chain refcnt is already 0, we can't even just hold it again. We can check refcnt==1 but it is ugly. 3. The chain with refcnt 0 is still visible in its block, which means it could be still found and used! 4. The block has a refcnt too, we can't hold it without introducing a proper API either. We can make it working but the end result is ugly. Instead of wasting time on reviewing it, let's just convert the troubling spinlock to a mutex, which allows us to use non-atomic allocations too. Fixes: ec3ed293e7 ("net_sched: change tcf_del_walker() to take idrinfo->lock") Reported-by: Ido Schimmel <idosch@idosch.org> Cc: Jamal Hadi Salim <jhs@mojatatu.com> Cc: Vlad Buslov <vladbu@mellanox.com> Cc: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Tested-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-10-05 00:36:31 -07:00
..
acpi	ACPICA: Update version to 20180810	2018-08-14 23:49:13 +02:00
asm-generic	asm-generic: io: Fix ioport_map() for !CONFIG_GENERIC_IOMAP && CONFIG_INDIRECT_PIO	2018-09-14 09:49:21 +01:00
clocksource
crypto	crypto: scatterwalk - remove scatterwalk_samebuf()	2018-08-03 18:06:04 +08:00
drm	Revert "drm/panel: Add device_link from panel device to DRM device"	2018-09-27 11:00:42 -04:00
dt-bindings	ARM: SoC: late updates	2018-08-25 14:12:36 -07:00
keys
kvm	KVM: arm/arm64: vgic-v3: Add core support for Group0 SGIs	2018-08-12 12:06:34 +01:00
linux	mlx5-updates-2018-10-03	2018-10-04 09:48:37 -07:00
math-emu
media	media: v4l: event: Prevent freeing event subscriptions while accessed	2018-10-03 06:32:51 -04:00
memory
misc
net	net_sched: convert idrinfo->lock from spinlock to a mutex	2018-10-05 00:36:31 -07:00
pcmcia	pcmcia: remove long deprecated pcmcia_request_exclusive_irq() function	2018-08-18 12:30:42 -07:00
ras
rdma	Second merge window update	2018-08-23 15:34:48 -07:00
scsi	SCSI misc on 20180815	2018-08-15 22:06:26 -07:00
soc
sound	ASoC: Fixes for v4.19	2018-09-17 18:59:21 +02:00
target
trace	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-10-03 21:00:17 -07:00
uapi	tc: Add support for configuring the taprio scheduler	2018-10-04 13:52:23 -07:00
video	fbdev changes for v4.19:	2018-08-23 15:44:58 -07:00
xen	xen/balloon: add runtime control for scrubbing ballooned out pages	2018-09-14 08:51:10 -04:00