Eric Dumazet ddec23f206 ipv6: fib6_rules: avoid possible NULL dereference in fib6_rule_action() ... [ Upstream commit d101291b26 ] syzbot is able to trigger the following crash [1], caused by unsafe ip6_dst_idev() use. Indeed ip6_dst_idev() can return NULL, and must always be checked. [1] Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN PTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] CPU: 0 PID: 31648 Comm: syz-executor.0 Not tainted 6.9.0-rc4-next-20240417-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 RIP: 0010:__fib6_rule_action net/ipv6/fib6_rules.c:237 [inline] RIP: 0010:fib6_rule_action+0x241/0x7b0 net/ipv6/fib6_rules.c:267 Code: 02 00 00 49 8d 9f d8 00 00 00 48 89 d8 48 c1 e8 03 42 80 3c 20 00 74 08 48 89 df e8 f9 32 bf f7 48 8b 1b 48 89 d8 48 c1 e8 03 <42> 80 3c 20 00 74 08 48 89 df e8 e0 32 bf f7 4c 8b 03 48 89 ef 4c RSP: 0018:ffffc9000fc1f2f0 EFLAGS: 00010246 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 1a772f98c8186700 RDX: 0000000000000003 RSI: ffffffff8bcac4e0 RDI: ffffffff8c1f9760 RBP: ffff8880673fb980 R08: ffffffff8fac15ef R09: 1ffffffff1f582bd R10: dffffc0000000000 R11: fffffbfff1f582be R12: dffffc0000000000 R13: 0000000000000080 R14: ffff888076509000 R15: ffff88807a029a00 FS: 00007f55e82ca6c0(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000001b31d23000 CR3: 0000000022b66000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> fib_rules_lookup+0x62c/0xdb0 net/core/fib_rules.c:317 fib6_rule_lookup+0x1fd/0x790 net/ipv6/fib6_rules.c:108 ip6_route_output_flags_noref net/ipv6/route.c:2637 [inline] ip6_route_output_flags+0x38e/0x610 net/ipv6/route.c:2649 ip6_route_output include/net/ip6_route.h:93 [inline] ip6_dst_lookup_tail+0x189/0x11a0 net/ipv6/ip6_output.c:1120 ip6_dst_lookup_flow+0xb9/0x180 net/ipv6/ip6_output.c:1250 sctp_v6_get_dst+0x792/0x1e20 net/sctp/ipv6.c:326 sctp_transport_route+0x12c/0x2e0 net/sctp/transport.c:455 sctp_assoc_add_peer+0x614/0x15c0 net/sctp/associola.c:662 sctp_connect_new_asoc+0x31d/0x6c0 net/sctp/socket.c:1099 __sctp_connect+0x66d/0xe30 net/sctp/socket.c:1197 sctp_connect net/sctp/socket.c:4819 [inline] sctp_inet_connect+0x149/0x1f0 net/sctp/socket.c:4834 __sys_connect_file net/socket.c:2048 [inline] __sys_connect+0x2df/0x310 net/socket.c:2065 __do_sys_connect net/socket.c:2075 [inline] __se_sys_connect net/socket.c:2072 [inline] __x64_sys_connect+0x7a/0x90 net/socket.c:2072 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Fixes: 5e5f3f0f80 ("[IPV6] ADDRCONF: Convert ipv6_get_saddr() to ipv6_dev_get_saddr().") Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Simon Horman <horms@kernel.org> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20240507163145.835254-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-05-17 11:43:54 +02:00
..
ila	ila: do not generate empty messages in ila_xlat_nl_cmd_get_mapping()	2023-03-17 08:32:50 +01:00
netfilter	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
addrconf_core.c	ipv6: Ensure natural alignment of const ipv6 loopback and router addresses	2024-02-23 08:25:04 +01:00
addrconf.c	ipv6: fix race condition between ipv6_get_ifaddr and ipv6_del_addr	2024-05-02 16:18:28 +02:00
addrlabel.c	ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network	2022-11-25 17:42:05 +01:00
af_inet6.c	dccp: Call inet6_destroy_sock() via sk->sk_destruct().	2023-04-26 11:24:05 +02:00
ah6.c	ah6: fix error return code in ah6_input()	2020-11-24 13:28:55 +01:00
anycast.c	ipv6: fix memory leaks on IPV6_ADDRFORM path	2020-08-11 15:33:39 +02:00
calipso.c	cipso,calipso: resolve a number of problems with the DOI refcounts	2021-03-17 17:03:35 +01:00
datagram.c	ipv6: Fix datagram socket connection with DSCP.	2023-02-22 12:50:41 +01:00
esp6_offload.c	xfrm: Linearize the skb after offloading if needed.	2023-06-28 10:18:38 +02:00
esp6.c	net: ipv6: fix return value check in esp_remove_trailer	2023-10-25 11:53:21 +02:00
exthdrs_core.c	ipv6: Fix out-of-bounds access in ipv6_find_tlv()	2023-05-30 12:44:10 +01:00
exthdrs_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
exthdrs.c	ipv6: fix out-of-bound access in ip6_parse_tlv()	2021-07-14 16:53:33 +02:00
fib6_notifier.c
fib6_rules.c	ipv6: fib6_rules: avoid possible NULL dereference in fib6_rule_action()	2024-05-17 11:43:54 +02:00
fou6.c
icmp.c	icmp6: Fix null-ptr-deref of ip6_null_entry->rt6i_idev in icmp6_dev().	2023-07-27 08:37:31 +02:00
inet6_connection_sock.c	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:18:58 +01:00
inet6_hashtables.c	secure_seq: use the 64 bits of the siphash for port offset calculation	2022-06-06 08:33:49 +02:00
ip6_checksum.c
ip6_fib.c	ipv6: fib: hide unused 'pn' variable	2024-05-02 16:18:28 +02:00
ip6_flowlabel.c	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
ip6_gre.c	erspan: make sure erspan_base_hdr is present in skb->head	2024-04-13 12:51:36 +02:00
ip6_icmp.c	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-03-04 10:26:53 +01:00
ip6_input.c	tcp/udp: Make early_demux back namespacified.	2022-11-10 17:57:55 +01:00
ip6_offload.c	gso: do not skip outer ip header in case of ipip and net_failover	2022-03-02 11:41:06 +01:00
ip6_offload.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ip6_output.c	net-timestamp: extend SOF_TIMESTAMPING_OPT_ID to HW timestamps	2024-01-15 18:25:26 +01:00
ip6_tunnel.c	ip6_tunnel: fix NEXTHDR_FRAGMENT handling in ip6_tnl_parse_tlv_enc_lim()	2024-01-25 14:34:26 -08:00
ip6_udp_tunnel.c
ip6_vti.c	ip6_vti: fix slab-use-after-free in decode_session6	2023-08-30 16:27:16 +02:00
ip6mr.c	ip6mr: Fix skb_under_panic in ip6mr_cache_report()	2023-08-11 11:53:57 +02:00
ipcomp6.c	xfrm: remove type and offload_type map from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
ipv6_sockglue.c	udp: Call inet6_destroy_sock() in setsockopt(IPV6_ADDRFORM).	2023-04-26 11:24:05 +02:00
Kconfig	net: ipv6: fix kconfig dependency warning for IPV6_SEG6_HMAC	2020-09-26 18:03:13 +02:00
Makefile
mcast_snoop.c	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-05-14 09:44:32 +02:00
mcast.c	mld: fix panic in mld_newpack()	2021-06-03 08:59:14 +02:00
mip6.c	xfrm: remove type and offload_type map from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
ndisc.c	ipv6: adjust ndisc_is_useropt() to also return true for PIO	2023-08-16 18:19:22 +02:00
netfilter.c	netfilter: use actual socket sk rather than skb sk when routing harder	2020-11-18 19:20:17 +01:00
output_core.c	ipv6: use prandom_u32() for ID generation	2021-07-19 08:53:09 +02:00
ping.c	ping6: Fix send to link-local addresses with VRF.	2023-06-21 15:44:11 +02:00
proc.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-07 11:00:14 -07:00
protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
raw.c	ipv{4,6}/raw: fix output xfrm lookup wrt protocol	2023-06-05 08:17:33 +02:00
reassembly.c	ipv6: record frag_max_size in atomic fragments in input path	2021-06-03 08:59:15 +02:00
route.c	net/ipv6: avoid possible UAF in ip6_route_mpath_notify()	2024-03-15 10:48:14 -04:00
seg6_hmac.c	net: ipv6: unexport __init-annotated seg6_hmac_net_init()	2022-07-07 17:36:49 +02:00
seg6_iptunnel.c	seg6: fix skb checksum evaluation in SRH encapsulation/insertion	2022-07-21 20:59:23 +02:00
seg6_local.c	seg6: fix skb checksum in SRv6 End.B6 and End.B6.Encaps behaviors	2022-07-21 20:59:23 +02:00
seg6.c	ipv6: sr: fix possible use-after-free and null-ptr-deref	2024-03-01 13:13:37 +01:00
sit.c	sit: update dev->needed_headroom in ipip6_tunnel_bind_dev()	2023-05-17 11:35:58 +02:00
syncookies.c	dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.	2023-11-20 10:30:15 +01:00
sysctl_net_ipv6.c	ipv6: Fix sysctl max for fib_multipath_hash_policy	2020-09-12 14:18:55 +02:00
tcp_ipv6.c	inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().	2023-04-26 11:24:05 +02:00
tcpv6_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tunnel6.c
udp_impl.h	tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().	2023-04-26 11:24:05 +02:00
udp_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
udp.c	udp: preserve the connected status if only UDP cmsg	2024-05-02 16:18:37 +02:00
udplite.c	udplite: Fix NULL pointer dereference in __sk_mem_raise_allocated().	2023-05-30 12:44:09 +01:00
xfrm6_input.c	xfrm: Preserve vlan tags for transport mode software GRO	2024-05-17 11:43:53 +02:00
xfrm6_output.c	xfrm: fix tunnel model fragmentation behavior	2022-04-15 14:17:56 +02:00
xfrm6_policy.c	xfrm6: fix inet6_dev refcount underflow problem	2023-10-25 11:53:25 +02:00
xfrm6_protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm6_state.c	xfrm: remove eth_proto value from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
xfrm6_tunnel.c