linux/fs/afs
David Howells 90fa9b6452 afs: Fix uninitialised spinlock afs_volume::cb_break_lock
Fix the cb_break_lock spinlock in afs_volume struct by initialising it when
the volume record is allocated.

Also rename the lock to cb_v_break_lock to distinguish it from the lock of
the same name in the afs_server struct.

Without this, the following trace may be observed when a volume-break
callback is received:

  INFO: trying to register non-static key.
  the code is fine but needs lockdep annotation.
  turning off the locking correctness validator.
  CPU: 2 PID: 50 Comm: kworker/2:1 Not tainted 5.2.0-rc1-fscache+ #3045
  Hardware name: ASUS All Series/H97-PLUS, BIOS 2306 10/09/2014
  Workqueue: afs SRXAFSCB_CallBack
  Call Trace:
   dump_stack+0x67/0x8e
   register_lock_class+0x23b/0x421
   ? check_usage_forwards+0x13c/0x13c
   __lock_acquire+0x89/0xf73
   lock_acquire+0x13b/0x166
   ? afs_break_callbacks+0x1b2/0x3dd
   _raw_write_lock+0x2c/0x36
   ? afs_break_callbacks+0x1b2/0x3dd
   afs_break_callbacks+0x1b2/0x3dd
   ? trace_event_raw_event_afs_server+0x61/0xac
   SRXAFSCB_CallBack+0x11f/0x16c
   process_one_work+0x2c5/0x4ee
   ? worker_thread+0x234/0x2ac
   worker_thread+0x1d8/0x2ac
   ? cancel_delayed_work_sync+0xf/0xf
   kthread+0x11f/0x127
   ? kthread_park+0x76/0x76
   ret_from_fork+0x24/0x30

Fixes: 68251f0a68 ("afs: Fix whole-volume callback handling")
Signed-off-by: David Howells <dhowells@redhat.com>
2019-06-20 16:49:35 +01:00
..
addr_list.c dns_resolver: Allow used keys to be invalidated 2019-05-15 17:35:54 +01:00
afs_cm.h afs: support the CB.ProbeUuid RPC op 2008-04-29 08:06:26 -07:00
afs_fs.h afs: implement acl setting 2019-05-07 16:48:44 +01:00
afs_vl.h afs: Make use of the YFS service upgrade to fully support IPv6 2017-11-13 15:38:19 +00:00
afs.h afs: Fix application of the results of a inline bulk status fetch 2019-05-16 22:23:21 +01:00
cache.c afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS 2018-10-24 00:41:08 +01:00
callback.c afs: Fix uninitialised spinlock afs_volume::cb_break_lock 2019-06-20 16:49:35 +01:00
cell.c afs: Fix cell DNS lookup 2019-05-16 12:58:23 +01:00
cmservice.c afs: Get rid of afs_call::reply[] 2019-05-16 16:25:21 +01:00
dir_edit.c afs: Locally edit directory data for mkdir/create/unlink/... 2018-04-09 21:54:48 +01:00
dir_silly.c afs: Fix application of status and callback to be under same lock 2019-05-16 16:25:21 +01:00
dir.c afs: Fix application of the results of a inline bulk status fetch 2019-05-16 22:23:21 +01:00
dynroot.c afs: Make dynamic root population wait uninterruptibly for proc_cells_lock 2019-05-16 16:25:21 +01:00
file.c afs: Fix application of status and callback to be under same lock 2019-05-16 16:25:21 +01:00
flock.c afs: Fix application of status and callback to be under same lock 2019-05-16 16:25:21 +01:00
fs_probe.c afs: Get rid of afs_call::reply[] 2019-05-16 16:25:21 +01:00
fsclient.c afs: Fix unlink to handle YFS.RemoveFile2 better 2019-05-16 22:23:21 +01:00
inode.c afs: Fix over zealous "vnode modified" warnings 2019-06-20 16:49:34 +01:00
internal.h afs: Fix uninitialised spinlock afs_volume::cb_break_lock 2019-06-20 16:49:35 +01:00
Kconfig afs: Allow dumping of server cursor on operation failure 2018-10-24 00:41:09 +01:00
main.c afs: Fix cell proc list 2018-10-12 13:18:57 +02:00
Makefile afs: Implement sillyrename for unlink and rename 2019-04-25 14:26:51 +01:00
misc.c afs: Mark expected switch fall-throughs 2019-04-08 18:35:56 -05:00
mntpt.c afs: Use fs_context to pass parameters over automount 2019-02-28 03:29:39 -05:00
netdevices.c afs: Implement network namespacing 2018-05-23 12:01:15 +01:00
proc.c afs: Fix afs_cell records to always have a VL server list record 2019-05-15 17:35:53 +01:00
protocol_yfs.h afs: Get YFS ACLs and information through xattrs 2019-05-07 16:48:44 +01:00
rotate.c afs: Make vnode->cb_interest RCU safe 2019-05-16 22:23:21 +01:00
rxrpc.c afs: Always get the reply time 2019-05-16 16:25:21 +01:00
security.c afs: Make vnode->cb_interest RCU safe 2019-05-16 22:23:21 +01:00
server_list.c afs: Use struct_size() in kzalloc() 2019-01-10 17:12:05 +00:00
server.c afs: Make some RPC operations non-interruptible 2019-05-16 16:25:20 +01:00
super.c afs: Pass pre-fetch server and volume break counts into afs_iget5_set() 2019-05-16 22:23:21 +01:00
vl_list.c afs: Fix afs_cell records to always have a VL server list record 2019-05-15 17:35:53 +01:00
vl_probe.c afs: Get rid of afs_call::reply[] 2019-05-16 16:25:21 +01:00
vl_rotate.c afs: Fix cell DNS lookup 2019-05-16 12:58:23 +01:00
vlclient.c afs: Always get the reply time 2019-05-16 16:25:21 +01:00
volume.c afs: Fix uninitialised spinlock afs_volume::cb_break_lock 2019-06-20 16:49:35 +01:00
write.c afs: Fix application of status and callback to be under same lock 2019-05-16 16:25:21 +01:00
xattr.c afs: Fix application of status and callback to be under same lock 2019-05-16 16:25:21 +01:00
xdr_fs.h afs: Adjust the directory XDR structures 2018-04-09 21:54:48 +01:00
yfsclient.c afs: Fix unlink to handle YFS.RemoveFile2 better 2019-05-16 22:23:21 +01:00