Go to file
Takashi Sakamoto 90753a38bc firewire: core: fix invalid port index for parent device
commit f6a6780e0b upstream.

In a commit 24b7f8e5cd ("firewire: core: use helper functions for self
ID sequence"), the enumeration over self ID sequence was refactored with
some helper functions with KUnit tests. These helper functions are
guaranteed to work expectedly by the KUnit tests, however their application
includes a mistake to assign invalid value to the index of port connected
to parent device.

This bug affects the case that any extra node devices which has three or
more ports are connected to 1394 OHCI controller. In the case, the path
to update the tree cache could hits WARN_ON(), and gets general protection
fault due to the access to invalid address computed by the invalid value.

This commit fixes the bug to assign correct port index.

Cc: stable@vger.kernel.org
Reported-by: Edmund Raile <edmund.raile@proton.me>
Closes: https://lore.kernel.org/lkml/8a9902a4ece9329af1e1e42f5fea76861f0bf0e8.camel@proton.me/
Fixes: 24b7f8e5cd ("firewire: core: use helper functions for self ID sequence")
Link: https://lore.kernel.org/r/20241025034137.99317-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-01 02:02:41 +01:00
arch KVM: arm64: Don't eagerly teardown the vgic on init error 2024-11-01 02:02:41 +01:00
block elevator: Remove argument from elevator_find_get 2024-11-01 02:02:26 +01:00
certs kbuild: use $(src) instead of $(srctree)/$(src) for source directory 2024-05-10 04:34:52 +09:00
crypto crypto: simd - Do not call crypto_alloc_tfm during registration 2024-10-10 12:03:13 +02:00
Documentation ASoC: dt-bindings: davinci-mcasp: Fix interrupt properties 2024-11-01 02:02:38 +01:00
drivers firewire: core: fix invalid port index for parent device 2024-11-01 02:02:41 +01:00
fs openat2: explicitly return -E2BIG for (usize > PAGE_SIZE) 2024-11-01 02:02:41 +01:00
include fs: pass offset and result to backing_file end_write() callback 2024-11-01 02:02:38 +01:00
init Rust fixes for v6.11 2024-08-16 11:24:06 -07:00
io_uring io_uring/sqpoll: ensure task state is TASK_RUNNING when running task_work 2024-10-22 15:51:24 +02:00
ipc sysctl: treewide: constify the ctl_table argument of proc_handlers 2024-07-24 20:59:29 +02:00
kernel bpf: fix do_misc_fixups() for bpf_get_branch_snapshot() 2024-11-01 02:02:37 +01:00
lib objpool: fix choosing allocation for percpu slots 2024-11-01 02:02:34 +01:00
LICENSES LICENSES: Add the copyleft-next-0.3.1 license 2022-11-08 15:44:01 +01:00
mm mm: don't install PMD mappings when THPs are disabled by the hw/process/vma 2024-11-01 02:02:33 +01:00
net Bluetooth: ISO: Fix UAF on iso_sock_timeout 2024-11-01 02:02:37 +01:00
rust rust: sync: require T: Sync for LockedBy::access 2024-10-10 12:03:47 +02:00
samples samples/bpf: Fix compilation errors with cf-protection option 2024-10-04 16:37:57 +02:00
scripts kconfig: qconf: fix buffer overflow in debug links 2024-10-10 12:04:13 +02:00
security tomoyo: fallback to realpath if symlink's pathname does not exist 2024-10-10 12:04:05 +02:00
sound ALSA: hda/realtek: Update default depop procedure 2024-11-01 02:02:39 +01:00
tools bpf: Add the missing BPF_LINK_TYPE invocation for sockmap 2024-11-01 02:02:38 +01:00
usr initramfs: shorten cmd_initfs in usr/Makefile 2024-07-16 01:07:52 +09:00
virt KVM: Use dedicated mutex to protect kvm_usage_count to avoid deadlock 2024-10-04 16:38:33 +02:00
.clang-format Docs: Move clang-format from process/ to dev-tools/ 2024-06-26 16:36:00 -06:00
.cocciconfig
.editorconfig .editorconfig: remove trim_trailing_whitespace option 2024-06-13 16:47:52 +02:00
.get_maintainer.ignore Add Jeff Kirsher to .get_maintainer.ignore 2024-03-08 11:36:54 +00:00
.gitattributes .gitattributes: set diff driver for Rust source code files 2023-05-31 17:48:25 +02:00
.gitignore Remove *.orig pattern from .gitignore 2024-10-04 16:38:29 +02:00
.mailmap sound fixes for 6.11 2024-09-14 11:54:24 +02:00
.rustfmt.toml rust: add .rustfmt.toml 2022-09-28 09:02:20 +02:00
COPYING COPYING: state that all contributions really are covered by this file 2020-02-10 13:32:20 -08:00
CREDITS tracing: Update of MAINTAINERS and CREDITS file 2024-07-18 14:08:42 -07:00
Kbuild Kbuild updates for v6.1 2022-10-10 12:00:45 -07:00
Kconfig kbuild: ensure full rebuild when the compiler is updated 2020-05-12 13:28:33 +09:00
MAINTAINERS sound fixes for 6.11 2024-09-14 11:54:24 +02:00
Makefile Linux 6.11.5 2024-10-22 15:51:37 +02:00
README README: Fix spelling 2024-03-18 03:36:32 -06:00

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the reStructuredText markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.