Mina Almasry 173e7622cc Revert "net: mirror skb frag ref/unref helpers" ... This reverts commit a580ea994f. This revert is to resolve Dragos's report of page_pool leak here: https://lore.kernel.org/lkml/20240424165646.1625690-2-dtatulea@nvidia.com/ The reverted patch interacts very badly with commit 2cc3aeb5ec ("skbuff: Fix a potential race while recycling page_pool packets"). The reverted commit hopes that the pp_recycle + is_pp_page variables do not change between the skb_frag_ref and skb_frag_unref operation. If such a change occurs, the skb_frag_ref/unref will not operate on the same reference type. In the case of Dragos's report, the grabbed ref was a pp ref, but the unref was a page ref, because the pp_recycle setting on the skb was changed. Attempting to fix this issue on the fly is risky. Lets revert and I hope to reland this with better understanding and testing to ensure we don't regress some edge case while streamlining skb reffing. Fixes: a580ea994f ("net: mirror skb frag ref/unref helpers") Reported-by: Dragos Tatulea <dtatulea@nvidia.com> Signed-off-by: Mina Almasry <almasrymina@google.com> Link: https://lore.kernel.org/r/20240502175423.2456544-1-almasrymina@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-05-03 16:05:53 -07:00
..
bpf_sk_storage.c	netlink: introduce type-checking attribute iteration	2024-03-29 15:06:02 -07:00
datagram.c	net: remove skb_free_datagram_locked()	2024-03-26 15:37:24 +01:00
dev_addr_lists_test.c	net: dev_addr_lists: move locking out of init/exit in kunit	2024-04-15 10:26:35 +01:00
dev_addr_lists.c	net: extract a few internals from netdevice.h	2022-04-07 20:32:09 -07:00
dev_ioctl.c	net: partial revert of the "Make timestamping selectable: series	2023-11-18 18:42:37 -08:00
dev.c	net: no longer acquire RTNL in threaded_show()	2024-05-03 15:14:01 -07:00
dev.h	net: move sysctl_skb_defer_max to net_hotdata	2024-04-30 18:46:52 -07:00
drop_monitor.c	drop_monitor: replace spin_lock by raw_spin_lock	2024-04-15 09:54:15 +01:00
dst_cache.c	inet: introduce dst_rtable() helper	2024-04-30 18:32:38 -07:00
dst.c	net: dst: Make dst_destroy() static and return void.	2024-02-06 11:45:53 +01:00
failover.c	net: failover: use IFF_NO_ADDRCONF flag to prevent ipv6 addrconf	2022-12-12 15:18:25 -08:00
fib_notifier.c
fib_rules.c	fib: rules: no longer hold RTNL in fib_nl_dumprule()	2024-04-12 19:09:31 -07:00
filter.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-05-02 12:06:25 -07:00
flow_dissector.c	ip_tunnel: convert __be16 tunnel flags to bitmaps	2024-04-01 10:49:28 +01:00
flow_offload.c	tc: flower: Enable offload support IPSEC SPI field.	2023-08-02 10:09:32 +01:00
gen_estimator.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
gen_stats.c	net: Remove the obsolte u64_stats_fetch_*_irq() users (net).	2022-10-28 20:13:54 -07:00
gro_cells.c	net: move netdev_max_backlog to net_hotdata	2024-03-07 21:12:42 -08:00
gro.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-05-02 12:06:25 -07:00
gso.c	net: introduce struct net_hotdata	2024-03-07 21:12:41 -08:00
hotdata.c	net: move sysctl_mem_pcpu_rsv to net_hotdata	2024-04-30 18:46:52 -07:00
hwbm.c
link_watch.c	net: add netdev_set_operstate() helper	2024-02-14 11:20:13 +00:00
lwt_bpf.c	lwt: Fix return values of BPF xmit ops	2023-08-18 16:05:26 +02:00
lwtunnel.c	xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available	2022-10-12 10:45:51 +02:00
Makefile	net: net_test: add tests for IP tunnel flags conversion helpers	2024-04-01 10:49:28 +01:00
neighbour.c	net: Remove the now superfluous sentinel elements from ctl_table array	2024-05-03 13:29:41 +01:00
net_namespace.c	netns: no longer hold RTNL in rtnl_net_dumpid()	2024-04-17 18:30:28 -07:00
net_test.c	pfcp: always set pfcp metadata	2024-04-01 10:49:28 +01:00
net-procfs.c	net: make softnet_data.dropped an atomic_t	2024-04-01 11:28:32 +01:00
net-sysfs.c	net: no longer acquire RTNL in threaded_show()	2024-05-03 15:14:01 -07:00
net-sysfs.h
net-traces.c	udp6: add a missing call into udp_fail_queue_rcv_skb tracepoint	2023-07-07 09:16:52 +01:00
netclassid_cgroup.c	cgroup, netclassid: on modifying netclassid in cgroup, only consider the main process.	2023-10-16 16:36:53 -07:00
netdev-genl-gen.c	netdev: support dumping a single netdev in qstats	2024-04-23 10:09:49 -07:00
netdev-genl-gen.h	netdev: add per-queue statistics	2024-03-07 21:13:25 -08:00
netdev-genl.c	netdev: add queue stats	2024-04-30 10:51:33 +02:00
netevent.c
netpoll.c	netpoll: Fix race condition in netpoll_owner_active	2024-04-30 19:03:47 -07:00
netprio_cgroup.c	bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode	2021-09-13 16:35:58 -07:00
of_net.c	net: Explicitly include correct DT includes	2023-07-27 20:33:16 -07:00
page_pool_priv.h	net: page_pool: report when page pool was destroyed	2023-11-28 15:48:39 +01:00
page_pool_user.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-03-07 10:29:36 -08:00
page_pool.c	net: page_pool: support error injection	2024-04-30 08:15:31 -07:00
pktgen.c	net: pktgen: Use wait_event_freezable_timeout() for freezable kthread	2023-12-27 14:34:52 +00:00
ptp_classifier.c	ptp: Add generic PTP is_sync() function	2022-03-07 11:31:34 +00:00
request_sock.c	tcp: make sure init the accept_queue's spinlocks once	2024-01-19 21:13:25 -08:00
rtnetlink.c	rtnetlink: use for_each_netdev_dump() in rtnl_stats_dump()	2024-05-03 15:03:42 -07:00
scm.c	af_unix: Link struct unix_edge when queuing skb.	2024-03-29 08:27:50 -07:00
secure_seq.c	tcp: Fix data-races around sysctl knobs related to SYN option.	2022-07-20 10:14:49 +01:00
selftests.c	net: fill in MODULE_DESCRIPTION()s under net/core	2023-10-28 11:29:27 +01:00
skbuff.c	Revert "net: mirror skb frag ref/unref helpers"	2024-05-03 16:05:53 -07:00
skmsg.c	bpf, skmsg: Fix NULL pointer dereference in sk_psock_skb_ingress_enqueue	2024-04-08 09:18:22 +02:00
sock_destructor.h	skb_expand_head() adjust skb->truesize incorrectly	2021-10-22 12:35:51 -07:00
sock_diag.c	sock_diag: remove sock_diag_mutex	2024-01-23 15:13:55 +01:00
sock_map.c	bpf-next-for-netdev	2024-04-29 13:12:19 -07:00
sock_reuseport.c	soreuseport: Fix socket selection for SO_INCOMING_CPU.	2022-10-25 11:35:16 +02:00
sock.c	net: move sysctl_mem_pcpu_rsv to net_hotdata	2024-04-30 18:46:52 -07:00
stream.c	net: Return error from sk_stream_wait_connect() if sk_wait_event() fails	2023-12-15 10:48:51 +00:00
sysctl_net_core.c	net: Remove the now superfluous sentinel elements from ctl_table array	2024-05-03 13:29:41 +01:00
timestamping.c	net: partial revert of the "Make timestamping selectable: series	2023-11-18 18:42:37 -08:00
tso.c	net: tso: inline tso_count_descs()	2022-12-12 15:04:39 -08:00
utils.c	net: core: inet[46]_pton strlen len types	2022-11-01 21:14:39 -07:00
xdp.c	net: move skbuff_cache(s) to net_hotdata	2024-03-07 21:12:42 -08:00