Jens Axboe 8e2e1faf28 io_uring: only post events in io_poll_remove_all() if we completed some ... syzbot reports this crash: BUG: unable to handle page fault for address: ffffffffffffffe8 PGD f96e17067 P4D f96e17067 PUD f96e19067 PMD 0 Oops: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN PTI CPU: 55 PID: 211750 Comm: trinity-c127 Tainted: G B L 5.7.0-rc1-next-20200413 #4 Hardware name: HP ProLiant DL380 Gen9/ProLiant DL380 Gen9, BIOS P89 04/12/2017 RIP: 0010:__wake_up_common+0x98/0x290 el/sched/wait.c:87 Code: 40 4d 8d 78 e8 49 8d 7f 18 49 39 fd 0f 84 80 00 00 00 e8 6b bd 2b 00 49 8b 5f 18 45 31 e4 48 83 eb 18 4c 89 ff e8 08 bc 2b 00 <45> 8b 37 41 f6 c6 04 75 71 49 8d 7f 10 e8 46 bd 2b 00 49 8b 47 10 RSP: 0018:ffffc9000adbfaf0 EFLAGS: 00010046 RAX: 0000000000000000 RBX: ffffffffffffffe8 RCX: ffffffffaa9636b8 RDX: 0000000000000003 RSI: dffffc0000000000 RDI: ffffffffffffffe8 RBP: ffffc9000adbfb40 R08: fffffbfff582c5fd R09: fffffbfff582c5fd R10: ffffffffac162fe3 R11: fffffbfff582c5fc R12: 0000000000000000 R13: ffff888ef82b0960 R14: ffffc9000adbfb80 R15: ffffffffffffffe8 FS: 00007fdcba4c4740(0000) GS:ffff889033780000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffffffffe8 CR3: 0000000f776a0004 CR4: 00000000001606e0 Call Trace: __wake_up_common_lock+0xea/0x150 ommon_lock at kernel/sched/wait.c:124 ? __wake_up_common+0x290/0x290 ? lockdep_hardirqs_on+0x16/0x2c0 __wake_up+0x13/0x20 io_cqring_ev_posted+0x75/0xe0 v_posted at fs/io_uring.c:1160 io_ring_ctx_wait_and_kill+0x1c0/0x2f0 l at fs/io_uring.c:7305 io_uring_create+0xa8d/0x13b0 ? io_req_defer_prep+0x990/0x990 ? __kasan_check_write+0x14/0x20 io_uring_setup+0xb8/0x130 ? io_uring_create+0x13b0/0x13b0 ? check_flags.part.28+0x220/0x220 ? lockdep_hardirqs_on+0x16/0x2c0 __x64_sys_io_uring_setup+0x31/0x40 do_syscall_64+0xcc/0xaf0 ? syscall_return_slowpath+0x580/0x580 ? lockdep_hardirqs_off+0x1f/0x140 ? entry_SYSCALL_64_after_hwframe+0x3e/0xb3 ? trace_hardirqs_off_caller+0x3a/0x150 ? trace_hardirqs_off_thunk+0x1a/0x1c entry_SYSCALL_64_after_hwframe+0x49/0xb3 RIP: 0033:0x7fdcb9dd76ed Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 6b 57 2c 00 f7 d8 64 89 01 48 RSP: 002b:00007ffe7fd4e4f8 EFLAGS: 00000246 ORIG_RAX: 00000000000001a9 RAX: ffffffffffffffda RBX: 00000000000001a9 RCX: 00007fdcb9dd76ed RDX: fffffffffffffffc RSI: 0000000000000000 RDI: 0000000000005d54 RBP: 00000000000001a9 R08: 0000000e31d3caa7 R09: 0082400004004000 R10: ffffffffffffffff R11: 0000000000000246 R12: 0000000000000002 R13: 00007fdcb842e058 R14: 00007fdcba4c46c0 R15: 00007fdcb842e000 Modules linked in: bridge stp llc nfnetlink cn brd vfat fat ext4 crc16 mbcache jbd2 loop kvm_intel kvm irqbypass intel_cstate intel_uncore dax_pmem intel_rapl_perf dax_pmem_core ip_tables x_tables xfs sd_mod tg3 firmware_class libphy hpsa scsi_transport_sas dm_mirror dm_region_hash dm_log dm_mod [last unloaded: binfmt_misc] CR2: ffffffffffffffe8 ---[ end trace f9502383d57e0e22 ]--- RIP: 0010:__wake_up_common+0x98/0x290 Code: 40 4d 8d 78 e8 49 8d 7f 18 49 39 fd 0f 84 80 00 00 00 e8 6b bd 2b 00 49 8b 5f 18 45 31 e4 48 83 eb 18 4c 89 ff e8 08 bc 2b 00 <45> 8b 37 41 f6 c6 04 75 71 49 8d 7f 10 e8 46 bd 2b 00 49 8b 47 10 RSP: 0018:ffffc9000adbfaf0 EFLAGS: 00010046 RAX: 0000000000000000 RBX: ffffffffffffffe8 RCX: ffffffffaa9636b8 RDX: 0000000000000003 RSI: dffffc0000000000 RDI: ffffffffffffffe8 RBP: ffffc9000adbfb40 R08: fffffbfff582c5fd R09: fffffbfff582c5fd R10: ffffffffac162fe3 R11: fffffbfff582c5fc R12: 0000000000000000 R13: ffff888ef82b0960 R14: ffffc9000adbfb80 R15: ffffffffffffffe8 FS: 00007fdcba4c4740(0000) GS:ffff889033780000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffffffffe8 CR3: 0000000f776a0004 CR4: 00000000001606e0 Kernel panic - not syncing: Fatal exception Kernel Offset: 0x29800000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) ---[ end Kernel panic - not syncing: Fatal exception ]— which is due to error injection (or allocation failure) preventing the rings from being setup. On shutdown, we attempt to remove any pending requests, and for poll request, we call io_cqring_ev_posted() when we've killed poll requests. However, since the rings aren't setup, we won't find any poll requests. Make the calling of io_cqring_ev_posted() dependent on actually having completed requests. This fixes this setup corner case, and removes spurious calls if we remove poll requests and don't find any. Reported-by: Qian Cai <cai@lca.pw> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2020-04-13 17:05:14 -06:00
..
9p	9p: read only once on O_NONBLOCK	2020-03-27 09:29:56 +00:00
adfs	fs/adfs: bigdir: Fix an error code in adfs_fplus_read()	2020-01-25 11:31:59 -05:00
affs	affs: fix a memory leak in affs_remount	2019-11-18 14:26:43 +01:00
afs	afs: Fix unpinned address list during probing	2020-03-26 16:04:29 -07:00
autofs	LOOKUP_MOUNTPOINT: fold path_mountpointat() into path_lookupat()	2020-03-13 21:08:17 -04:00
befs	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
bfs	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
btrfs	btrfs: fix missing semaphore unlock in btrfs_sync_file	2020-03-25 16:29:16 +01:00
cachefiles	cachefiles: drop direct usage of ->bmap method.	2020-02-03 08:05:56 -05:00
ceph	ceph: fix snapshot directory timestamps	2020-03-30 12:42:43 +02:00
cifs	cifs: update internal module version number	2020-03-29 16:59:31 -05:00
coda	y2038: add inode timestamp clamping	2019-09-19 09:42:37 -07:00
configfs	utimes: Clamp the timestamps in notify_change()	2019-12-08 19:10:50 -05:00
cramfs	cramfs: switch to use of errofc() et.al.	2020-02-07 14:48:41 -05:00
crypto	fscrypt updates for 5.7	2020-03-31 12:58:36 -07:00
debugfs	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2020-04-01 14:47:40 -07:00
devpts	devpts_pty_kill(): don't bother with d_delete()	2019-09-03 09:30:56 -04:00
dlm	dlm: use SO_SNDTIMEO_NEW instead of SO_SNDTIMEO_OLD	2019-12-18 18:07:31 +01:00
ecryptfs	eCryptfs fixes for 5.6-rc3	2020-02-17 21:08:37 -08:00
efivarfs	efi: Use more granular check for availability for variable services	2020-02-23 21:59:42 +01:00
efs	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
erofs	erofs: handle corrupted images whose decompressed size less than it'd be	2020-03-03 23:40:52 +08:00
exfat	exfat: update file system parameter handling	2020-03-05 21:00:40 -05:00
exportfs	race in exportfs_decode_fh()	2019-11-11 09:21:59 -05:00
ext2	ext2: fix empty body warnings when -Wextra is used	2020-03-23 13:01:37 +01:00
ext4	1) Replace ext4's bmap and iopoll implementations to use iomap.	2020-04-05 10:54:03 -07:00
f2fs	f2fs-for-5.7-rc1	2020-04-07 13:48:26 -07:00
fat	fat: fix uninit-memory access for partial initialized inode	2020-03-06 07:06:09 -06:00
freevxfs	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
fscache	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
fuse	fuse: fix stack use after return	2020-02-13 09:16:07 +01:00
gfs2	We've got a lot of patches (39) for this merge window. Most of these patches	2020-03-31 14:16:03 -07:00
hfs	hfs/hfsplus: use 64-bit inode timestamps	2019-12-18 18:07:32 +01:00
hfsplus	hfsplus: fix crash and filesystem corruption when deleting files	2020-04-10 15:36:20 -07:00
hostfs	hostfs: Use kasprintf() instead of fixed buffer formatting	2020-03-29 23:23:00 +02:00
hpfs	fs: compat_ioctl: move FITRIM emulation into file systems	2019-10-23 17:23:46 +02:00
hugetlbfs	hugetlbfs: Use i_mmap_rwsem to address page fault/truncate race	2020-04-02 09:35:32 -07:00
iomap	Bug fixes for 5.7:	2020-04-08 21:37:18 -07:00
isofs	y2038: add inode timestamp clamping	2019-09-19 09:42:37 -07:00
jbd2	jbd2: improve comments about freeing data buffers whose page mapping is NULL	2020-03-05 20:25:05 -05:00
jffs2	fs_parse: fold fs_parameter_desc/fs_parameter_spec	2020-02-07 14:48:37 -05:00
jfs	Trivial cleanup for jfs	2020-02-05 05:28:20 +00:00
kernfs	kernfs: Add option to enable user xattrs	2020-03-16 15:53:47 -04:00
lockd	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
minix	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
nfs	NFS client updates for Linux 5.7	2020-04-07 13:51:39 -07:00
nfs_common	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
nfsd	nfsd: fsnotify on rmdir under nfsd/clients/	2020-03-19 11:33:42 -04:00
nilfs2	fs: compat_ioctl: move FITRIM emulation into file systems	2019-10-23 17:23:46 +02:00
nls	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
notify	fanotify: Fix the checks in fanotify_fsid_equal	2020-03-30 12:40:53 +02:00
ntfs	fs/buffer: Make BH_Uptodate_Lock bit_spin_lock a regular spinlock_t	2020-03-28 13:21:08 +01:00
ocfs2	ocfs2: no need try to truncate file beyond i_size	2020-04-10 15:36:21 -07:00
omfs	fs: omfs: Initialize filesystem timestamp ranges	2019-08-30 08:11:25 -07:00
openpromfs	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
orangefs	orangefs: don't mess with I_DIRTY_TIMES in orangefs_flush	2020-04-08 09:39:11 -04:00
overlayfs	ovl: enable xino automatically in more cases	2020-03-27 16:51:02 +01:00
proc	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2020-04-10 12:59:56 -07:00
pstore	pstore/ram: Replace zero-length array with flexible-array member	2020-03-09 14:45:40 -07:00
qnx4	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
qnx6	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
quota	\n	2020-01-30 15:37:41 -08:00
ramfs	fs_parse: fold fs_parameter_desc/fs_parameter_spec	2020-02-07 14:48:37 -05:00
reiserfs	reiserfs: clean up several indentation issues	2020-04-07 10:43:44 -07:00
romfs	Merge branch 'work.mount2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-09-19 10:06:57 -07:00
squashfs	Merge branch 'work.mount2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-09-19 10:06:57 -07:00
sysfs	sysfs: remove redundant __compat_only_sysfs_link_entry_to_kobj fn	2020-04-05 11:34:35 -07:00
sysv	fs: sysv: Initialize filesystem timestamp ranges	2019-08-30 07:27:18 -07:00
tracefs	simple_recursive_removal(): kernel-side rm -rf for ramfs-style filesystems	2019-12-10 22:29:58 -05:00
ubifs	This pull request contains fixes for UBI and UBIFS:	2020-04-07 12:40:56 -07:00
udf	change email address for Pali Rohár	2020-04-10 15:36:22 -07:00
ufs	y2038: add inode timestamp clamping	2019-09-19 09:42:37 -07:00
unicode	.gitignore: add SPDX License Identifier	2020-03-25 11:50:48 +01:00
vboxsf	fs: Add VirtualBox guest shared folder (vboxsf) support	2020-02-08 17:34:58 -05:00
verity	fs-verity: use u64_to_user_ptr()	2020-01-14 13:28:28 -08:00
xfs	xfs: reflink should force the log out if mounted with wsync	2020-04-06 08:44:39 -07:00
zonefs	zonfs: Fix handling of read-only zones	2020-03-25 11:28:26 +09:00
aio.c	aio: prevent potential eventfd recursion on poll	2020-02-03 17:27:47 -07:00
anon_inodes.c	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
attr.c	utimes: Clamp the timestamps in notify_change()	2019-12-08 19:10:50 -05:00
bad_inode.c
binfmt_aout.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
binfmt_elf_fdpic.c	y2038: elfcore: Use __kernel_old_timeval for process times	2019-11-15 14:38:29 +01:00
binfmt_elf.c	fs/binfmt_elf.c: don't free interpreter's ELF pheaders on common path	2020-04-07 10:43:44 -07:00
binfmt_em86.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
binfmt_flat.c	fs/binfmt_flat.c: remove set but not used variable 'inode'	2019-07-16 19:23:22 -07:00
binfmt_misc.c	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
binfmt_script.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
block_dev.c	New code for 5.7:	2020-04-02 12:59:36 -07:00
buffer.c	Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2020-03-30 16:17:15 -07:00
char_dev.c	chardev: Avoid potential use-after-free in 'chrdev_open()'	2020-01-06 20:10:26 +01:00
compat_binfmt_elf.c	y2038: elfcore: Use __kernel_old_timeval for process times	2019-11-15 14:38:29 +01:00
compat.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
coredump.c	pipe: use exclusive waits when reading or writing	2020-02-08 11:39:19 -08:00
d_path.c	[PATCH] fix d_absolute_path() interplay with fsmount()	2019-08-30 19:31:09 -04:00
dax.c	dax,iomap: Add helper dax_iomap_zero() to zero a range	2020-04-02 19:15:03 -07:00
dcache.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-12-08 11:08:28 -08:00
dcookies.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
direct-io.c	fs/direct-io.c: include fs/internal.h for missing prototype	2020-01-04 13:55:09 -08:00
drop_caches.c	fs: avoid softlockups in s_inodes iterators	2019-12-18 00:03:01 -05:00
eventfd.c	eventfd: track eventfd_signal() recursion depth	2020-02-03 17:27:38 -07:00
eventpoll.c	fs/epoll: make nesting accounting safe for -rt kernel	2020-04-07 10:43:44 -07:00
exec.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2020-04-02 11:22:17 -07:00
fcntl.c	fcntl: Distribute switch variables for initialization	2020-03-03 10:55:06 -05:00
fhandle.c	fs/handle.c - fix up kerneldoc	2019-08-07 21:51:47 -04:00
file_table.c	vfs: Export flush_delayed_fput for use by knfsd.	2019-08-19 11:00:39 -04:00
file.c	io_uring: make sure openat/openat2 honor rlimit nofile	2020-03-20 08:47:27 -06:00
filesystems.c	fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()	2020-04-10 15:36:22 -07:00
fs_context.c	add prefix to fs_context->log	2020-02-07 14:48:35 -05:00
fs_parser.c	fs_parse: remove pr_notice() about each validation	2020-04-02 09:35:26 -07:00
fs_pin.c	switch the remnants of releasing the mountpoint away from fs_pin	2019-07-16 22:52:37 -04:00
fs_struct.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
fs_types.c
fs-writeback.c	memcg: fix a crash in wb_workfn when a device disappears	2020-01-31 10:30:36 -08:00
fsopen.c	add prefix to fs_context->log	2020-02-07 14:48:35 -05:00
inode.c	futex: Fix inode life-time issue	2020-03-06 11:06:15 +01:00
internal.h	Merge branch 'work.dotdot1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-04-02 12:30:08 -07:00
io_uring.c	io_uring: only post events in io_poll_remove_all() if we completed some	2020-04-13 17:05:14 -06:00
io-wq.c	io_uring: use io-wq manager as backup task if task is exiting	2020-04-03 11:35:57 -06:00
io-wq.h	io_uring: use io-wq manager as backup task if task is exiting	2020-04-03 11:35:57 -06:00
ioctl.c	compat-ioctl fix for v5.6	2020-02-08 13:44:41 -08:00
Kconfig	exfat: add Kconfig and Makefile	2020-03-05 21:00:40 -05:00
Kconfig.binfmt	binfmt_flat: make support for old format binaries optional	2019-06-24 09:16:47 +10:00
libfs.c	libfs: fix infoleak in simple_attr_read()	2020-03-24 13:27:16 +01:00
locks.c	locks: reinstate locks_delete_block optimization	2020-03-18 13:03:38 -07:00
Makefile	exfat: add Kconfig and Makefile	2020-03-05 21:00:40 -05:00
mbcache.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
mount.h	switch the remnants of releasing the mountpoint away from fs_pin	2019-07-16 22:52:37 -04:00
mpage.c	fs: move guard_bio_eod() after bio_set_op_attrs	2020-01-09 08:16:12 -07:00
namei.c	fix a braino in legitimize_path()	2020-04-06 10:38:59 -04:00
namespace.c	LOOKUP_MOUNTPOINT: fold path_mountpointat() into path_lookupat()	2020-03-13 21:08:17 -04:00
no-block.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
nsfs.c	fs/nsfs.c: Added ns_match	2020-03-12 17:33:11 -07:00
open.c	Merge branch 'work.dotdot1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-04-02 12:30:08 -07:00
pipe.c	mm: kmem: rename memcg_kmem_(un)charge() into memcg_kmem_(un)charge_page()	2020-04-02 09:35:28 -07:00
pnode.c	fs/namespace: fix unprivileged mount propagation	2019-06-17 17:36:09 -04:00
pnode.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 209	2019-05-30 11:29:53 -07:00
posix_acl.c	fs/posix_acl.c: fix kernel-doc warnings	2020-01-04 13:55:09 -08:00
proc_namespace.c	vfs: subtype handling moved to fuse	2019-09-06 21:28:49 +02:00
read_write.c	powerpc: Add back __ARCH_WANT_SYS_LLSEEK macro	2020-04-03 00:09:59 +11:00
readdir.c	readdir: make user_access_begin() use the real access range	2020-01-23 10:15:28 -08:00
select.c	y2038: syscalls: change remaining timeval to __kernel_old_timeval	2019-11-15 14:38:29 +01:00
seq_file.c	fs/seq_file.c: seq_read(): add info message about buggy .next functions	2020-04-10 15:36:22 -07:00
signalfd.c
splice.c	splice: make do_splice public	2020-03-02 14:04:31 -07:00
stack.c	sched/rt, fs: Use CONFIG_PREEMPTION	2019-12-08 14:37:36 +01:00
stat.c	fs: make two stat prep helpers available	2020-01-20 17:03:54 -07:00
statfs.c	vfs: Fix EOVERFLOW testing in put_compat_statfs64	2019-10-03 14:21:35 -07:00
super.c	fs: call fsnotify_sb_delete after evict_inodes	2019-12-18 00:03:01 -05:00
sync.c
timerfd.c	timerfd: Make timerfd_settime() time namespace aware	2020-01-14 12:20:53 +01:00
userfaultfd.c	userfaultfd: wp: declare _UFFDIO_WRITEPROTECT conditionally	2020-04-07 10:43:40 -07:00
utimes.c	utimes: Clamp the timestamps in notify_change()	2019-12-08 19:10:50 -05:00
xattr.c	kernfs: Add removed_size out param for simple_xattr_set	2020-03-16 15:53:47 -04:00