linux/drivers/net/ethernet/broadcom/genet
Heiner Kallweit 28b2e0d2cd net: phy: remove parameter new_link from phy_mac_interrupt()
I see two issues with parameter new_link:

1. It's not needed. See also phy_interrupt(), works w/o this parameter.
   phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the
   state machine which then calls phy_read_status. And phy_read_status
   updates the link state.

2. phy_mac_interrupt is used in interrupt context and getting the link
   state may sleep (at least when having to access the PHY registers
   via MDIO bus).

So let's remove it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-01-15 13:45:03 -05:00
..
bcmgenet_wol.c net: bcmgenet: remove handling of wol interrupts from isr0 2017-03-13 21:51:50 -07:00
bcmgenet.c net: phy: remove parameter new_link from phy_mac_interrupt() 2018-01-15 13:45:03 -05:00
bcmgenet.h net: bcmgenet: use dev->phydev instead of priv->phydev 2017-10-26 10:14:54 +09:00
bcmmii.c net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit() 2017-11-01 11:56:14 +09:00
Makefile net: bcmgenet: add Wake-on-LAN support code 2014-07-21 16:04:31 -07:00