Honggang Li 8c490669de RDMA/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings ... ipoib_dev_init accesses the wrong private data for the IPoIB device. Commit cd565b4b51 (IB/IPoIB: Support acceleration options callbacks) changed ipoib_priv from being identical to netdev_priv to being an area inside of, but not the same pointer as, the netdev_priv pointer. As such, the struct we want is the ipoib_priv area, not the netdev_priv area, so use the right accessor, otherwise we kernel panic. [ 27.271938] IPv6: ADDRCONF(NETDEV_CHANGE): mlx5_ib0.8006: link becomes ready [ 28.156790] BUG: unable to handle kernel NULL pointer dereference at 000000000000067c [ 28.166309] IP: ib_query_port+0x30/0x180 [ib_core] ... [ 28.306282] RIP: 0010:ib_query_port+0x30/0x180 [ib_core] ... [ 28.393337] Call Trace: [ 28.397594] ipoib_get_link_ksettings+0x66/0xe0 [ib_ipoib] [ 28.405274] __ethtool_get_link_ksettings+0xa0/0x1c0 [ 28.412353] speed_show+0x74/0xa0 [ 28.417503] dev_attr_show+0x20/0x50 [ 28.422922] ? mutex_lock+0x12/0x40 [ 28.428179] sysfs_kf_seq_show+0xbf/0x1a0 [ 28.434002] kernfs_seq_show+0x21/0x30 [ 28.439470] seq_read+0x116/0x3b0 [ 28.444445] ? do_filp_open+0xa5/0x100 [ 28.449774] kernfs_fop_read+0xff/0x180 [ 28.455220] __vfs_read+0x37/0x150 [ 28.460167] ? security_file_permission+0x9d/0xc0 [ 28.466560] vfs_read+0x8c/0x130 [ 28.471318] SyS_read+0x55/0xc0 [ 28.475950] do_syscall_64+0x67/0x150 [ 28.481163] entry_SYSCALL64_slow_path+0x25/0x25 ... [ 28.584493] ---[ end trace 3549968a4bf0aa5d ]--- Fixes: cd565b4b51 (IB/IPoIB: Support acceleration options callbacks) Fixes: 0d7e2d2166 (IB/ipoib: add get_link_ksettings in ethtool) Signed-off-by: Honggang Li <honli@redhat.com> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> Reviewed-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Doug Ledford <dledford@redhat.com>		2017-06-01 17:20:09 -04:00
..
ipoib_cm.c	IB/SA: Rename ib_sa_path_rec to sa_path_rec	2017-05-01 14:37:28 -04:00
ipoib_ethtool.c	RDMA/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings	2017-06-01 17:20:09 -04:00
ipoib_fs.c	IB/SA: Add OPA path record type	2017-05-01 14:39:02 -04:00
ipoib_ib.c	IB/core: Rename ib_destroy_ah to rdma_destroy_ah	2017-05-01 14:32:43 -04:00
ipoib_main.c	IB/SA: Add support to query OPA path records	2017-05-01 14:39:02 -04:00
ipoib_multicast.c	IB/core: Define 'ib' and 'roce' rdma_ah_attr types	2017-05-01 14:32:43 -04:00
ipoib_netlink.c	IB/IPoIB: Support acceleration options callbacks	2017-04-20 15:19:44 -04:00
ipoib_verbs.c	IB/IPoIB: Support acceleration options callbacks	2017-04-20 15:19:44 -04:00
ipoib_vlan.c	IB/IPoIB: Support acceleration options callbacks	2017-04-20 15:19:44 -04:00
ipoib.h	IB/SA: Rename ib_sa_path_rec to sa_path_rec	2017-05-01 14:37:28 -04:00
Kconfig	kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT	2011-01-20 17:02:05 -08:00
Makefile	IB/ipoib: Add rtnl_link_ops support	2012-09-20 16:49:17 -04:00