linux/drivers/mailbox
Jason-JH.Lin a8bd68e432 mailbox: mtk-cmdq: Move devm_mbox_controller_register() after devm_pm_runtime_enable()
When mtk-cmdq unbinds, a WARN_ON message with condition
pm_runtime_get_sync() < 0 occurs.

According to the call tracei below:
  cmdq_mbox_shutdown
  mbox_free_channel
  mbox_controller_unregister
  __devm_mbox_controller_unregister
  ...

The root cause can be deduced to be calling pm_runtime_get_sync() after
calling pm_runtime_disable() as observed below:
1. CMDQ driver uses devm_mbox_controller_register() in cmdq_probe()
   to bind the cmdq device to the mbox_controller, so
   devm_mbox_controller_unregister() will automatically unregister
   the device bound to the mailbox controller when the device-managed
   resource is removed. That means devm_mbox_controller_unregister()
   and cmdq_mbox_shoutdown() will be called after cmdq_remove().
2. CMDQ driver also uses devm_pm_runtime_enable() in cmdq_probe() after
   devm_mbox_controller_register(), so that devm_pm_runtime_disable()
   will be called after cmdq_remove(), but before
   devm_mbox_controller_unregister().

To fix this problem, cmdq_probe() needs to move
devm_mbox_controller_register() after devm_pm_runtime_enable() to make
devm_pm_runtime_disable() be called after
devm_mbox_controller_unregister().

Fixes: 623a6143a8 ("mailbox: mediatek: Add Mediatek CMDQ driver")
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
2024-07-19 21:25:23 -05:00
..
arm_mhu_db.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
arm_mhu.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
arm_mhuv2.c mailbox: arm_mhuv2: Fix a bug for mhuv2_sender_interrupt 2024-01-13 23:08:50 -06:00
arm_mhuv3.c mailbox: arm_mhuv3: Add driver 2024-05-19 22:30:09 -05:00
armada-37xx-rwtm-mailbox.c treewide: change my e-mail address, fix my name 2021-04-09 14:54:23 -07:00
bcm2835-mailbox.c mailbox: bcm2835: Make use of the helper function devm_platform_ioremap_resource() 2021-10-16 14:39:48 -05:00
bcm-flexrm-mailbox.c irqchip: Convert all platform MSI users to the new API 2024-02-15 17:55:40 +01:00
bcm-pdc-mailbox.c mailbox: bcm-pdc: remove unused struct 'pdc_dma_map' 2024-07-10 13:24:55 -05:00
hi3660-mailbox.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
hi6220-mailbox.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
imx-mailbox.c mailbox: imx: fix TXDB_V2 channel race condition 2024-07-10 13:24:55 -05:00
Kconfig mailbox: qcom-cpucp: fix 64BIT dependency 2024-07-19 21:21:06 -05:00
mailbox-altera.c mailbox: altera: Make use of the helper function devm_platform_ioremap_resource() 2021-10-16 14:39:48 -05:00
mailbox-mpfs.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
mailbox-sti.c mailbox: Use device_get_match_data() 2023-10-15 12:39:16 -05:00
mailbox-test.c mailbox: mailbox-test: Convert to platform remove callback returning void 2024-01-13 23:08:51 -06:00
mailbox-xgene-slimpro.c mailbox: xgene-slimpro: Make use of the helper function devm_platform_ioremap_resource() 2021-10-16 14:39:49 -05:00
mailbox.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
mailbox.h mailbox: fix various typos in comments 2021-04-13 20:07:35 -05:00
Makefile mailbox: Add support for QTI CPUCP mailbox controller 2024-07-10 13:24:55 -05:00
mtk-adsp-mailbox.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
mtk-cmdq-mailbox.c mailbox: mtk-cmdq: Move devm_mbox_controller_register() after devm_pm_runtime_enable() 2024-07-19 21:25:23 -05:00
omap-mailbox.c mailbox: omap: Fix mailbox interrupt sharing 2024-07-10 13:24:55 -05:00
pcc.c mailbox: pcc: Support shared interrupt for multiple subspaces 2023-09-11 10:31:17 +01:00
pl320-ipc.c mailbox: fix various typos in comments 2021-04-13 20:07:35 -05:00
platform_mhu.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
qcom-apcs-ipc-mailbox.c mailbox: qcom-apcs-ipc: Convert to platform remove callback returning void 2024-01-13 23:08:51 -06:00
qcom-cpucp-mbox.c mailbox: Add support for QTI CPUCP mailbox controller 2024-07-10 13:24:55 -05:00
qcom-ipcc.c mailbox: qcom-ipcc: Convert to platform remove callback returning void 2024-01-13 23:08:51 -06:00
rockchip-mailbox.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
sprd-mailbox.c mailbox: Explicitly include correct DT includes 2023-09-05 10:10:58 -05:00
stm32-ipcc.c mailbox: stm32-ipcc: Convert to platform remove callback returning void 2024-01-13 23:08:51 -06:00
sun6i-msgbox.c mailbox: sun6i-msgbox: Convert to platform remove callback returning void 2024-01-13 23:08:51 -06:00
tegra-hsp.c mailbox: tegra-hsp: Convert to platform remove callback returning void 2024-01-13 23:08:51 -06:00
ti-msgmgr.c mailbox: Use device_get_match_data() 2023-10-15 12:39:16 -05:00
zynqmp-ipi-mailbox.c mailbox: zynqmp-ipi: Make polling period configurable 2024-07-19 21:23:16 -05:00