korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-15 00:04:15 +08:00
Code Issues Packages Projects Releases Wiki Activity
889f0346d4
linux/drivers
History
Cezar Bulinaru 4f61f133f3 net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null 
Fixes a NULL pointer derefence bug triggered from tap driver.
When tap_get_user calls virtio_net_hdr_to_skb the skb->dev is null
(in tap.c skb->dev is set after the call to virtio_net_hdr_to_skb)
virtio_net_hdr_to_skb calls dev_parse_header_protocol which
needs skb->dev field to be valid.

The line that trigers the bug is in dev_parse_header_protocol
(dev is at offset 0x10 from skb and is stored in RAX register)
  if (!dev->header_ops || !dev->header_ops->parse_protocol)
  22e1:   mov    0x10(%rbx),%rax
  22e5:	  mov    0x230(%rax),%rax

Setting skb->dev before the call in tap.c fixes the issue.

BUG: kernel NULL pointer dereference, address: 0000000000000230
RIP: 0010:virtio_net_hdr_to_skb.constprop.0+0x335/0x410 [tap]
Code: c0 0f 85 b7 fd ff ff eb d4 41 39 c6 77 cf 29 c6 48 89 df 44 01 f6 e8 7a 79 83 c1 48 85 c0 0f 85 d9 fd ff ff eb b7 48 8b 43 10 <48> 8b 80 30 02 00 00 48 85 c0 74 55 48 8b 40 28 48 85 c0 74 4c 48
RSP: 0018:ffffc90005c27c38 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff888298f25300 RCX: 0000000000000010
RDX: 0000000000000005 RSI: ffffc90005c27cb6 RDI: ffff888298f25300
RBP: ffffc90005c27c80 R08: 00000000ffffffea R09: 00000000000007e8
R10: ffff88858ec77458 R11: 0000000000000000 R12: 0000000000000001
R13: 0000000000000014 R14: ffffc90005c27e08 R15: ffffc90005c27cb6
FS:  0000000000000000(0000) GS:ffff88858ec40000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000230 CR3: 0000000281408006 CR4: 00000000003706e0
Call Trace:
 tap_get_user+0x3f1/0x540 [tap]
 tap_sendmsg+0x56/0x362 [tap]
 ? get_tx_bufs+0xc2/0x1e0 [vhost_net]
 handle_tx_copy+0x114/0x670 [vhost_net]
 handle_tx+0xb0/0xe0 [vhost_net]
 handle_tx_kick+0x15/0x20 [vhost_net]
 vhost_worker+0x7b/0xc0 [vhost]
 ? vhost_vring_call_reset+0x40/0x40 [vhost]
 kthread+0xfa/0x120
 ? kthread_complete_and_exit+0x20/0x20
 ret_from_fork+0x1f/0x30

Fixes: 924a9bc362 ("net: check if protocol extracted by virtio_net_hdr_set_proto is correct")
Signed-off-by: Cezar Bulinaru <cbulinaru@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-08-05 08:56:35 +01:00
..
accessibility Revert "speakup: Generate speakupmap.h automatically" 2022-05-20 21:07:05 +02:00
acpi EFI updates for v5.20 2022-08-03 14:38:02 -07:00
amba ARM: 9207/1: amba: fix refcount underflow if amba_device_add() fails 2022-07-14 13:17:48 +01:00
android fix for breakage in #work.fd this window 2022-06-05 17:14:03 -07:00
ata ATA changes for 5.20-rc1 2022-08-03 15:26:04 -07:00
atm atm: he: Use the bitmap API to allocate bitmaps 2022-07-11 19:49:53 -07:00
auxdisplay
base Power management updates for 5.20-rc1 2022-08-02 11:17:00 -07:00
bcma bcma: gpio: Switch to use fwnode instead of of_node 2022-05-09 14:41:43 +03:00
block for-5.20/block-2022-07-29 2022-08-02 13:46:35 -07:00
bluetooth Bluetooth: btusb: Detect if an ACL packet is in fact an ISO packet 2022-07-22 17:14:37 -07:00
bus Merge branch 'acpi-bus' 2022-07-29 19:58:52 +02:00
cdrom block: remove blk_cleanup_disk 2022-06-28 06:33:15 -06:00
char This update includes the following changes: 2022-08-02 17:45:14 -07:00
clk linux-kselftest-kunit-5.20-rc1 2022-08-02 19:34:45 -07:00
clocksource - Add the missing DT bindings for the MTU nomadik timer (Linus 2022-07-28 12:33:34 +02:00
comedi comedi: vmk80xx: fix expression for tx buffer size 2022-06-10 15:21:23 +02:00
connector
counter
cpufreq Merge branches 'pm-core', 'pm-sleep', 'powercap', 'pm-domains' and 'pm-em' 2022-07-29 19:33:13 +02:00
cpuidle RCU pull request for v5.20 (or whatever) 2022-08-02 19:12:45 -07:00
crypto This update includes the following changes: 2022-08-02 17:45:14 -07:00
cxl cxl/mbox: Fix missing variable payload checks in cmd size validation 2022-06-28 22:03:18 -07:00
dax dax: add .recovery_write dax_operation 2022-05-16 13:37:59 -07:00
dca
devfreq PM / devfreq: tegra30: Add error message for devm_devfreq_add_device() 2022-07-15 11:40:08 +09:00
dio drivers: dio: add missing iounmap() in dio_init() 2022-05-19 18:56:51 +02:00
dma dmaengine: lgm: Fix an error handling path in intel_ldma_probe() 2022-07-06 10:53:25 +05:30
dma-buf Saner handling of "lseek should fail with ESPIPE" - gets rid of 2022-08-03 11:35:20 -07:00
edac EDAC/ghes: Set the DIMM label unconditionally 2022-07-27 10:42:52 +02:00
eisa
extcon extcon: Modify extcon device to be created after driver data is set 2022-05-13 17:03:41 +09:00
firewire firewire: net: Make use of get_unaligned_be48(), put_unaligned_be48() 2022-07-28 22:21:54 -07:00
firmware EFI efivars sysfs interface removal 2022-08-03 14:41:36 -07:00
fpga fpga: dfl: Allow Port to be linked to FME's DFL 2022-05-10 16:05:38 +08:00
fsi
gnss
gpio Updates for interrupt core and drivers: 2022-08-01 12:48:15 -07:00
gpu Saner handling of "lseek should fail with ESPIPE" - gets rid of 2022-08-03 11:35:20 -07:00
greybus
hid HID: hyperv: Correctly access fields declared as __le16 2022-06-08 12:28:13 +00:00
hsi
hte hte: Uninitialized variable in hte_ts_get() 2022-05-20 15:54:41 +02:00
hv Drivers: hv: vmbus: Release cpu lock in error case 2022-06-10 08:41:28 +00:00
hwmon hwmon updates for v5.20 2022-08-02 11:07:04 -07:00
hwspinlock
hwtracing coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier 2022-05-09 16:03:24 +01:00
i2c ARM: SoC drivers for 6.0 2022-08-02 08:10:10 -07:00
i3c i3c: master: svc: fix returnvar.cocci warning 2022-05-17 22:34:42 +02:00
idle Power management updates for 5.20-rc1 2022-08-02 11:17:00 -07:00
iio 1st set of IIO fixes for the 5.19 cycle. 2022-06-20 09:49:52 +02:00
infiniband Networking changes for 6.0. 2022-08-03 16:29:08 -07:00
input EFI updates for v5.20 2022-08-03 14:38:02 -07:00
interconnect Char / Misc / Other smaller driver subsystem updates for 5.19-rc1 2022-06-03 11:36:34 -07:00
iommu Updates for interrupt core and drivers: 2022-08-01 12:48:15 -07:00
ipack
irqchip ARM: new SoC support for 6.0 2022-08-02 08:29:18 -07:00
isdn isdn: mISDN: hfcsusb: drop unexpected word "the" in the comments 2022-06-22 18:20:46 -07:00
leds ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
macintosh macintosh: via-pmu and via-cuda need RTC_LIB 2022-05-22 15:58:30 +10:00
mailbox mailbox: qcom-ipcc: Fix -Wunused-function with CONFIG_PM_SLEEP=n 2022-05-24 08:08:24 -05:00
mcb
md hardening updates for v5.20-rc1 2022-08-02 14:38:59 -07:00
media USB / Thunderbolt changes for 5.19-rc1 2022-06-03 11:17:49 -07:00
memory memory: tegra: Changes for v5.20-rc1 2022-07-12 22:53:08 +02:00
memstick block: remove blk_cleanup_disk 2022-06-28 06:33:15 -06:00
message
mfd ACPI updates for 5.20-rc1 2022-08-02 11:12:25 -07:00
misc Folio changes for 6.0 2022-08-03 10:35:43 -07:00
mmc linux-kselftest-kunit-5.20-rc1 2022-08-02 19:34:45 -07:00
most
mtd for-5.20/block-2022-07-29 2022-08-02 13:46:35 -07:00
mux
net net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null 2022-08-05 08:56:35 +01:00
nfc NFC: nxp-nci: add error reporting 2022-07-13 18:52:12 -07:00
ntb
nubus
nvdimm for-5.20/block-2022-07-29 2022-08-02 13:46:35 -07:00
nvme iov_iter work, part 1 - isolated cleanups and optimizations. 2022-08-03 13:50:22 -07:00
nvmem nvmem: sfp: Add support for TA 2.1 devices 2022-05-09 15:46:29 +02:00
of x86/kexec: Carry forward IMA measurement log on kexec 2022-07-01 15:22:16 +02:00
opp PM: EM: convert power field to micro-Watts precision and align drivers 2022-07-15 19:17:30 +02:00
parisc genirq: Add and use an irq_data_update_affinity helper 2022-07-07 09:38:04 +01:00
parport
pci PCI: hv: Take a const cpumask in hv_compose_msi_req_get_cpu() 2022-07-08 08:44:15 +01:00
pcmcia ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
peci
perf drivers/perf: arm_spe: Fix consistency of SYS_PMSCR_EL1.CX 2022-07-19 18:50:09 +01:00
phy phy: brcm-sata: bcmbca: Replace ARCH_BCM_63XX with ARCH_BCMBCA 2022-07-08 14:09:58 -07:00
pinctrl Updates for interrupt core and drivers: 2022-08-01 12:48:15 -07:00
platform Merge branch 'acpi-bus' 2022-07-29 19:58:52 +02:00
pnp
power power: supply: core: Fix boundary conditions in interpolation 2022-06-09 21:08:38 +02:00
powercap Power management updates for 5.20-rc1 2022-08-02 11:17:00 -07:00
pps
ps3
ptp Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2022-07-28 18:21:16 -07:00
pwm pwm: lpc18xx: Fix period handling 2022-07-29 13:41:18 +02:00
rapidio
ras
regulator regulator: Consumer load management improvements 2022-07-28 00:01:30 +01:00
remoteproc remoteproc: imx_rproc: Support i.MX93 2022-05-09 09:29:25 -06:00
reset Merge branch 'nuvoton/newsoc' into arm/newsoc 2022-07-19 15:42:00 +02:00
rpmsg Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
rtc ARM: multiplatform changes, part 2 2022-06-02 15:23:54 -07:00
s390 Networking changes for 6.0. 2022-08-03 16:29:08 -07:00
sbus
scsi for-5.20/block-2022-07-29 2022-08-02 13:46:35 -07:00
sh genirq: Add and use an irq_data_update_affinity helper 2022-07-07 09:38:04 +01:00
siox
slimbus Driver core changes for 5.19-rc1 2022-06-03 11:48:47 -07:00
soc ARM: SoC drivers for 6.0 2022-08-02 08:10:10 -07:00
soundwire soundwire: Use acpi_dev_for_each_child() 2022-06-23 20:53:06 +02:00
spi spi: Updates for v5.20 2022-08-02 10:55:04 -07:00
spmi
ssb ssb: remove unreachable code 2022-05-11 08:29:11 +03:00
staging Networking changes for 6.0. 2022-08-03 16:29:08 -07:00
target for-5.20/block-2022-07-29 2022-08-02 13:46:35 -07:00
tc
tee tee: tee_get_drvdata(): fix description of return value 2022-07-08 10:51:24 +02:00
thermal Thermal control updates for 5.20-rc1 2022-08-02 11:27:53 -07:00
thunderbolt linux-kselftest-kunit-5.20-rc1 2022-08-02 19:34:45 -07:00
tty ARM: SoC drivers for 6.0 2022-08-02 08:10:10 -07:00
ufs for-5.20/block-2022-07-29 2022-08-02 13:46:35 -07:00
uio uio: dfl: add HSSI subsystem feature id 2022-05-09 15:42:57 +02:00
usb Merge branch 'acpi-bus' 2022-07-29 19:58:52 +02:00
vdpa vduse: Tie vduse mgmtdev and its device 2022-06-24 02:49:48 -04:00
vfio Saner handling of "lseek should fail with ESPIPE" - gets rid of 2022-08-03 11:35:20 -07:00
vhost vhost-vdpa: call vhost_vdpa_cleanup during the release 2022-06-27 08:05:35 -04:00
video fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible() 2022-07-07 10:52:35 +02:00
virt linux-kselftest-kunit-5.20-rc1 2022-08-02 19:34:45 -07:00
virtio Folio changes for 6.0 2022-08-03 10:35:43 -07:00
vlynq
vme
w1
watchdog watchdog: gxp: Add missing MODULE_LICENSE 2022-06-09 12:20:34 +02:00
xen Updates for interrupt core and drivers: 2022-08-01 12:48:15 -07:00
zorro
Kconfig SCSI misc on 20220604 2022-06-05 09:25:12 -07:00
Makefile SCSI misc on 20220604 2022-06-05 09:25:12 -07:00