Tejun Heo 88533f990c kernfs: remove unnecessary NULL check in __kernfs_remove() ... 895a068a52 ("kernfs: make kernfs_get_active() block if the node is deactivated but not removed") added "struct kernfs_root *root = kernfs_root(kn);" at the head of the function; however, the parameter @kn is checked for later implying that the function may be called with NULL. This means that we may end up invoking kernfs_root() with NULL which will oops. None of the existing users invokes removal with NULL @kn, so this bug doesn't actually trigger. We can relocate kernfs_root() invocation after NULL check; however, allowing NULL param tends to cause more confusion than actually helping anything. As there's no existing user, let's remove the spurious NULL check. This bug was detected by smatch. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2014-01-11 15:40:19 -08:00
..
dir.c	kernfs: remove unnecessary NULL check in __kernfs_remove()	2014-01-11 15:40:19 -08:00
file.c	kernfs: remove kernfs_addrm_cxt	2014-01-10 13:48:08 -08:00
inode.c	kernfs: s/sysfs/kernfs/ in internal functions and whatever is left	2013-12-11 17:39:20 -08:00
kernfs-internal.h	kernfs: remove kernfs_addrm_cxt	2014-01-10 13:48:08 -08:00
Makefile	sysfs, kernfs: add skeletons for kernfs	2013-11-27 13:28:24 -08:00
mount.c	kernfs: s/sysfs/kernfs/ in internal functions and whatever is left	2013-12-11 17:39:20 -08:00
symlink.c	kernfs: remove kernfs_addrm_cxt	2014-01-10 13:48:08 -08:00