Jakub Sitnicki 87d9205d9a l2tp: Serialize access to sk_user_data with sk_callback_lock ... [ Upstream commit b68777d54f ] sk->sk_user_data has multiple users, which are not compatible with each other. Writers must synchronize by grabbing the sk->sk_callback_lock. l2tp currently fails to grab the lock when modifying the underlying tunnel socket fields. Fix it by adding appropriate locking. We err on the side of safety and grab the sk_callback_lock also inside the sk_destruct callback overridden by l2tp, even though there should be no refs allowing access to the sock at the time when sk_destruct gets called. v4: - serialize write to sk_user_data in l2tp sk_destruct v3: - switch from sock lock to sk_callback_lock - document write-protection for sk_user_data v2: - update Fixes to point to origin of the bug - use real names in Reported/Tested-by tags Cc: Tom Parkin <tparkin@katalix.com> Fixes: 3557baabf2 ("[L2TP]: PPP over L2TP driver core") Reported-by: Haowei Yan <g1042620637@gmail.com> Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: David S. Miller <davem@davemloft.net> Stable-dep-of: 0b2c59720e ("l2tp: close all race conditions in l2tp_tunnel_register()") Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-02-01 08:27:09 +01:00
..
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
l2tp_core.c	l2tp: Serialize access to sk_user_data with sk_callback_lock	2023-02-01 08:27:09 +01:00
l2tp_core.h	net: l2tp: reduce log level of messages in receive path, add counter instead	2021-03-03 16:55:02 -08:00
l2tp_debugfs.c	l2tp: remove tunnel and session debug flags field	2020-08-22 12:44:37 -07:00
l2tp_eth.c	l2tp: remove header length param from l2tp_xmit_skb	2020-09-03 12:19:03 -07:00
l2tp_ip6.c	ipv6: Fix signed integer overflow in l2tp_ip6_sendmsg	2022-06-22 14:21:58 +02:00
l2tp_ip.c	l2tp: Fix spelling mistakes	2021-06-07 14:08:30 -07:00
l2tp_netlink.c	net: l2tp: reduce log level of messages in receive path, add counter instead	2021-03-03 16:55:02 -08:00
l2tp_ppp.c	l2tp: Fix spelling mistakes	2021-06-07 14:08:30 -07:00
Makefile	l2tp: add tracepoint infrastructure to core	2020-08-22 12:44:37 -07:00
trace.h	l2tp: add tracepoint definitions in trace.h	2020-08-22 12:44:37 -07:00