Hans de Goede 83ac7a1c2e platform/x86: msi-laptop: Fix old-ec check for backlight registering ... Commit 2cc6c71779 ("msi-laptop: Port to new backlight interface selection API") replaced this check: if (!quirks->old_ec_model || acpi_video_backlight_support()) pr_info("Brightness ignored, ..."); else do_register(); With: if (quirks->old_ec_model || acpi_video_get_backlight_type() == acpi_backlight_vendor) do_register(); But since the do_register() part was part of the else branch, the entire condition should be inverted. So not only the 2 statements on either side of the || should be inverted, but the || itself should be replaced with a &&. In practice this has likely not been an issue because the new-ec models (old_ec_model==false) likely all support ACPI video backlight control, making acpi_video_get_backlight_type() return acpi_backlight_video turning the second part of the || also false when old_ec_model == false. Fixes: 2cc6c71779 ("msi-laptop: Port to new backlight interface selection API") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20220825141336.208597-1-hdegoede@redhat.com		2022-08-26 12:59:01 +02:00
..
chrome	platform/chrome: cros_kunit_util: add default value for msg->result	2022-07-21 08:49:28 +00:00
goldfish	platform: goldfish: pipe: Use platform_get_irq() to get the interrupt	2022-03-18 13:55:21 +01:00
mellanox	virtio: fatures, fixes	2022-08-12 09:50:34 -07:00
mips	MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.	2022-06-09 22:24:19 +02:00
olpc	platform/olpc: Fix uninitialized data in debugfs write	2022-07-28 20:40:15 +02:00
surface	platform/x86: move from strlcpy with unused retval to strscpy	2022-08-26 11:56:56 +02:00
x86	platform/x86: msi-laptop: Fix old-ec check for backlight registering	2022-08-26 12:59:01 +02:00
Kconfig	platform/x86: Kconfig: Remove unnecessary "if X86"	2022-06-27 09:37:49 +02:00
Makefile	platform: Add Surface platform directory	2020-10-27 12:51:03 +01:00