korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 12:28:41 +08:00
Code Issues Packages Projects Releases Wiki Activity
82982175be
linux/drivers/bcma
History
Zenghui Yu 5debec63a2 bcma: Fix memory leak for internally-handled cores 
[ Upstream commit b63aed3ff1 ]

kmemleak reported that dev_name() of internally-handled cores were leaked
on driver unbinding. Let's use device_initialize() to take refcounts for
them and put_device() to properly free the related stuff.

While looking at it, there's another potential issue for those which should
be *registered* into driver core. If device_register() failed, we put
device once and freed bcma_device structures. In bcma_unregister_cores(),
they're treated as unregistered and we hit both UAF and double-free. That
smells not good and has also been fixed now.

Fixes: ab54bc8460 ("bcma: fill core details for every device")
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210727025232.663-2-yuzenghui@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-09-15 09:47:37 +02:00
..
bcma_private.h bcma: use dev_* printing functions 2019-01-10 13:39:19 +02:00
core.c
driver_chipcommon_b.c
driver_chipcommon_nflash.c
driver_chipcommon_pflash.c
driver_chipcommon_pmu.c bcma: Replace mdelay with usleep_range in bcma_pmu_resources_init 2018-02-27 15:52:13 +02:00
driver_chipcommon_sflash.c
driver_chipcommon.c
driver_gmac_cmn.c
driver_gpio.c bcma: keep a direct pointer to the struct device 2019-01-10 13:39:18 +02:00
driver_mips.c bcma: remove two unused variables 2019-09-03 16:37:53 +03:00
driver_pci_host.c
driver_pci.c bcma: fix incorrect update of BCMA_CORE_PCI_MDIO_DATA 2019-09-03 16:44:02 +03:00
driver_pcie2.c bcma: Adjust block comment 2017-12-07 15:33:02 +02:00
host_pci.c bcma: Use dev_get_drvdata 2019-08-06 15:25:28 +03:00
host_soc.c bcma: keep a direct pointer to the struct device 2019-01-10 13:39:18 +02:00
Kconfig bcma: Allow selection of this driver when COMPILE_TEST=y 2018-07-18 09:34:19 +02:00
main.c bcma: Fix memory leak for internally-handled cores 2021-09-15 09:47:37 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
README
scan.c
scan.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
sprom.c bcma: make arrays pwr_info_offset and sprom_sizes static const, shrinks object size 2019-09-13 16:44:49 +03:00
TODO

README 

Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
however from programming point of view there is nothing AMBA specific we use.

Standard AMBA drivers are platform specific, have hardcoded addresses and use
AMBA standard fields like CID and PID.

In case of Broadcom's cards every device consists of:
1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
   and PIDs (0x103BB369), but we do not use that info for anything. One of that
   devices is used for managing Broadcom specific core.

Addresses of AMBA devices are not hardcoded in driver and have to be read from
EPROM.

In this situation we decided to introduce separated bus. It can contain up to
16 devices identified by Broadcom specific fields: manufacturer, id, revision
and class.