mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-05 10:04:12 +08:00
ddf1c4b394
Current code does not setup CPU dai (causing -EIO errors on playback)
and does not pass SND_SOC_DAIFMT_I2S to codec fmt (causing i2s-hifi
errors). Fix both errors to enable HDMI audio playback on SM8250. Tested
on RB5 platform.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: aa2e278554
("ASoC: qcom: sm8250: add sound card qrb5165-rb5 support")
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20201119123145.709891-1-dmitry.baryshkov@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
230 lines
5.8 KiB
C
230 lines
5.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
// Copyright (c) 2020, Linaro Limited
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/of_device.h>
|
|
#include <sound/soc.h>
|
|
#include <sound/soc-dapm.h>
|
|
#include <sound/pcm.h>
|
|
#include <linux/soundwire/sdw.h>
|
|
#include "qdsp6/q6afe.h"
|
|
#include "common.h"
|
|
|
|
#define DRIVER_NAME "sm8250"
|
|
#define MI2S_BCLK_RATE 1536000
|
|
|
|
struct sm8250_snd_data {
|
|
bool stream_prepared[AFE_PORT_MAX];
|
|
struct snd_soc_card *card;
|
|
struct sdw_stream_runtime *sruntime[AFE_PORT_MAX];
|
|
};
|
|
|
|
static int sm8250_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
|
|
struct snd_pcm_hw_params *params)
|
|
{
|
|
struct snd_interval *rate = hw_param_interval(params,
|
|
SNDRV_PCM_HW_PARAM_RATE);
|
|
struct snd_interval *channels = hw_param_interval(params,
|
|
SNDRV_PCM_HW_PARAM_CHANNELS);
|
|
|
|
rate->min = rate->max = 48000;
|
|
channels->min = channels->max = 2;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int sm8250_snd_startup(struct snd_pcm_substream *substream)
|
|
{
|
|
unsigned int fmt = SND_SOC_DAIFMT_CBS_CFS;
|
|
unsigned int codec_dai_fmt = SND_SOC_DAIFMT_CBS_CFS;
|
|
struct snd_soc_pcm_runtime *rtd = substream->private_data;
|
|
struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
|
|
struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
|
|
|
|
switch (cpu_dai->id) {
|
|
case TERTIARY_MI2S_RX:
|
|
codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
|
|
snd_soc_dai_set_sysclk(cpu_dai,
|
|
Q6AFE_LPASS_CLK_ID_TER_MI2S_IBIT,
|
|
MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
|
|
snd_soc_dai_set_fmt(cpu_dai, fmt);
|
|
snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int sm8250_snd_hw_params(struct snd_pcm_substream *substream,
|
|
struct snd_pcm_hw_params *params)
|
|
{
|
|
struct snd_soc_pcm_runtime *rtd = substream->private_data;
|
|
struct snd_soc_dai *codec_dai;
|
|
struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
|
|
struct sm8250_snd_data *pdata = snd_soc_card_get_drvdata(rtd->card);
|
|
struct sdw_stream_runtime *sruntime;
|
|
int i;
|
|
|
|
switch (cpu_dai->id) {
|
|
case WSA_CODEC_DMA_RX_0:
|
|
for_each_rtd_codec_dais(rtd, i, codec_dai) {
|
|
sruntime = snd_soc_dai_get_sdw_stream(codec_dai,
|
|
substream->stream);
|
|
if (sruntime != ERR_PTR(-ENOTSUPP))
|
|
pdata->sruntime[cpu_dai->id] = sruntime;
|
|
}
|
|
break;
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
static int sm8250_snd_wsa_dma_prepare(struct snd_pcm_substream *substream)
|
|
{
|
|
struct snd_soc_pcm_runtime *rtd = substream->private_data;
|
|
struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
|
|
struct sm8250_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
|
|
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
|
|
int ret;
|
|
|
|
if (!sruntime)
|
|
return 0;
|
|
|
|
if (data->stream_prepared[cpu_dai->id]) {
|
|
sdw_disable_stream(sruntime);
|
|
sdw_deprepare_stream(sruntime);
|
|
data->stream_prepared[cpu_dai->id] = false;
|
|
}
|
|
|
|
ret = sdw_prepare_stream(sruntime);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/**
|
|
* NOTE: there is a strict hw requirement about the ordering of port
|
|
* enables and actual WSA881x PA enable. PA enable should only happen
|
|
* after soundwire ports are enabled if not DC on the line is
|
|
* accumulated resulting in Click/Pop Noise
|
|
* PA enable/mute are handled as part of codec DAPM and digital mute.
|
|
*/
|
|
|
|
ret = sdw_enable_stream(sruntime);
|
|
if (ret) {
|
|
sdw_deprepare_stream(sruntime);
|
|
return ret;
|
|
}
|
|
data->stream_prepared[cpu_dai->id] = true;
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int sm8250_snd_prepare(struct snd_pcm_substream *substream)
|
|
{
|
|
struct snd_soc_pcm_runtime *rtd = substream->private_data;
|
|
struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
|
|
|
|
switch (cpu_dai->id) {
|
|
case WSA_CODEC_DMA_RX_0:
|
|
case WSA_CODEC_DMA_RX_1:
|
|
return sm8250_snd_wsa_dma_prepare(substream);
|
|
default:
|
|
break;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int sm8250_snd_hw_free(struct snd_pcm_substream *substream)
|
|
{
|
|
struct snd_soc_pcm_runtime *rtd = substream->private_data;
|
|
struct sm8250_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
|
|
struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
|
|
struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
|
|
|
|
switch (cpu_dai->id) {
|
|
case WSA_CODEC_DMA_RX_0:
|
|
case WSA_CODEC_DMA_RX_1:
|
|
if (sruntime && data->stream_prepared[cpu_dai->id]) {
|
|
sdw_disable_stream(sruntime);
|
|
sdw_deprepare_stream(sruntime);
|
|
data->stream_prepared[cpu_dai->id] = false;
|
|
}
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct snd_soc_ops sm8250_be_ops = {
|
|
.startup = sm8250_snd_startup,
|
|
.hw_params = sm8250_snd_hw_params,
|
|
.hw_free = sm8250_snd_hw_free,
|
|
.prepare = sm8250_snd_prepare,
|
|
};
|
|
|
|
static void sm8250_add_be_ops(struct snd_soc_card *card)
|
|
{
|
|
struct snd_soc_dai_link *link;
|
|
int i;
|
|
|
|
for_each_card_prelinks(card, i, link) {
|
|
if (link->no_pcm == 1) {
|
|
link->be_hw_params_fixup = sm8250_be_hw_params_fixup;
|
|
link->ops = &sm8250_be_ops;
|
|
}
|
|
}
|
|
}
|
|
|
|
static int sm8250_platform_probe(struct platform_device *pdev)
|
|
{
|
|
struct snd_soc_card *card;
|
|
struct sm8250_snd_data *data;
|
|
struct device *dev = &pdev->dev;
|
|
int ret;
|
|
|
|
card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL);
|
|
if (!card)
|
|
return -ENOMEM;
|
|
|
|
/* Allocate the private data */
|
|
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
|
|
if (!data)
|
|
return -ENOMEM;
|
|
|
|
card->dev = dev;
|
|
dev_set_drvdata(dev, card);
|
|
snd_soc_card_set_drvdata(card, data);
|
|
ret = qcom_snd_parse_of(card);
|
|
if (ret)
|
|
return ret;
|
|
|
|
card->driver_name = DRIVER_NAME;
|
|
sm8250_add_be_ops(card);
|
|
return devm_snd_soc_register_card(dev, card);
|
|
}
|
|
|
|
static const struct of_device_id snd_sm8250_dt_match[] = {
|
|
{.compatible = "qcom,sm8250-sndcard"},
|
|
{.compatible = "qcom,qrb5165-rb5-sndcard"},
|
|
{}
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, snd_sm8250_dt_match);
|
|
|
|
static struct platform_driver snd_sm8250_driver = {
|
|
.probe = sm8250_platform_probe,
|
|
.driver = {
|
|
.name = "snd-sm8250",
|
|
.of_match_table = snd_sm8250_dt_match,
|
|
},
|
|
};
|
|
module_platform_driver(snd_sm8250_driver);
|
|
MODULE_AUTHOR("Srinivas Kandagatla <srinivas.kandagatla@linaro.org");
|
|
MODULE_DESCRIPTION("SM8250 ASoC Machine Driver");
|
|
MODULE_LICENSE("GPL v2");
|