linux/sound/firewire/fireface
Dan Carpenter 81c254a65c ALSA: fireface: fix locking bug in ff400_copy_msg_to_user()
The ff400_copy_msg_to_user() function drops the spin lock to call
copy_to_user().  However, if the copy_to_user() fails, then it must
take the lock again before returning.  Failure to take the lock leads
to a double unlock in the caller, hwdep_read().

Fixes: acdebd8b4c ("ALSA: fireface: implement message parser for Fireface 400")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/Y8at+W/7OGvEBY8O@kili
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2023-01-18 17:49:48 +01:00
..
amdtp-ff.c ALSA: firewire-lib: obsolete return value from context payload processing layer 2023-01-12 12:14:50 +01:00
ff-hwdep.c ALSA: fireface: add local framework to message parser 2023-01-13 09:56:37 +01:00
ff-midi.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
ff-pcm.c ALSA: firewire: Replace runtime->status->state reference to runtime->state 2022-09-27 08:47:25 +02:00
ff-proc.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
ff-protocol-former.c ALSA: fireface: fix locking bug in ff400_copy_msg_to_user() 2023-01-18 17:49:48 +01:00
ff-protocol-latter.c ALSA: fireface: pick up time stamp for request subaction of asynchronous transaction 2023-01-13 09:56:35 +01:00
ff-stream.c ALSA: fireface: perform sequence replay for media clock recovery 2021-06-01 08:19:51 +02:00
ff-transaction.c ALSA: fireface: add local framework to message parser 2023-01-13 09:56:37 +01:00
ff.c ALSA: fireface: add local framework to message parser 2023-01-13 09:56:37 +01:00
ff.h ALSA: fireface: add local framework to message parser 2023-01-13 09:56:37 +01:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00