linux

korg/linux

mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-17 09:14:19 +08:00

Go to file

Jisheng Zhang 8070274b47 net: stmmac: fix incorrect rxq\|txq_stats reference commit `133466c3bb` ("net: stmmac: use per-queue 64 bit statistics where necessary") caused one regression as found by Uwe, the backtrace looks like: INFO: trying to register non-static key. The code is fine but needs lockdep annotation, or maybe you didn't initialize this object before use? turning off the locking correctness validator. CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc1-00449-g133466c3bbe1-dirty #21 Hardware name: STM32 (Device Tree Support) unwind_backtrace from show_stack+0x18/0x1c show_stack from dump_stack_lvl+0x60/0x90 dump_stack_lvl from register_lock_class+0x98c/0x99c register_lock_class from __lock_acquire+0x74/0x293c __lock_acquire from lock_acquire+0x134/0x398 lock_acquire from stmmac_get_stats64+0x2ac/0x2fc stmmac_get_stats64 from dev_get_stats+0x44/0x130 dev_get_stats from rtnl_fill_stats+0x38/0x120 rtnl_fill_stats from rtnl_fill_ifinfo+0x834/0x17f4 rtnl_fill_ifinfo from rtmsg_ifinfo_build_skb+0xc0/0x144 rtmsg_ifinfo_build_skb from rtmsg_ifinfo+0x50/0x88 rtmsg_ifinfo from __dev_notify_flags+0xc0/0xec __dev_notify_flags from dev_change_flags+0x50/0x5c dev_change_flags from ip_auto_config+0x2f4/0x1260 ip_auto_config from do_one_initcall+0x70/0x35c do_one_initcall from kernel_init_freeable+0x2ac/0x308 kernel_init_freeable from kernel_init+0x1c/0x138 kernel_init from ret_from_fork+0x14/0x2c The reason is the rxq\|txq_stats structures are not what expected because stmmac_open() -> __stmmac_open() the structure is overwritten by "memcpy(&priv->dma_conf, dma_conf, sizeof(*dma_conf));" This causes the well initialized syncp member of rxq\|txq_stats is overwritten unexpectedly as pointed out by Johannes and Uwe. Fix this issue by moving rxq\|txq_stats back to stmmac_extra_stats. For SMP cache friendly, we also mark stmmac_txq_stats and stmmac_rxq_stats as ____cacheline_aligned_in_smp. Fixes: `133466c3bb` ("net: stmmac: use per-queue 64 bit statistics where necessary") Signed-off-by: Jisheng Zhang <jszhang@kernel.org> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230917165328.3403-1-jszhang@kernel.org Signed-off-by: Paolo Abeni <pabeni@redhat.com>		2023-09-19 10:21:15 +02:00
arch	parisc architecture fixes and enhancements for kernel v6.6-rc2:	2023-09-13 11:35:53 -07:00
block	block: fix pin count management when merging same-page segments	2023-09-06 07:32:27 -06:00
certs	certs: Reference revocation list for all keyrings	2023-08-17 20:12:41 +00:00
crypto	This update includes the following changes:	2023-08-29 11:23:29 -07:00
Documentation	Documentation: netdev: fix dead link in ax25.rst	2023-09-18 12:56:58 +01:00
drivers	net: stmmac: fix incorrect rxq\|txq_stats reference	2023-09-19 10:21:15 +02:00
fs	Tracing fixes for 6.6:	2023-09-13 11:30:11 -07:00
include	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2023-09-16 11:16:00 +01:00
init	workqueue: Changes for v6.6	2023-09-01 16:06:32 -07:00
io_uring	Revert "io_uring: fix IO hang in io_wq_put_and_exit from do_exit()"	2023-09-07 09:41:49 -06:00
ipc	Add x86 shadow stack support	2023-08-31 12:20:12 -07:00
kernel	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2023-09-16 11:16:00 +01:00
lib	linux-kselftest-kunit-6.6-rc2	2023-09-12 09:05:49 -07:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
mm	LoongArch changes for v6.6	2023-09-08 12:16:52 -07:00
net	ax25: Kconfig: Update link for linux-ax25.org	2023-09-18 12:56:58 +01:00
rust	Documentation work keeps chugging along; stuff for 6.6 includes:	2023-08-30 20:05:42 -07:00
samples	VFIO updates for v6.6-rc1	2023-08-30 20:36:01 -07:00
scripts	parisc architecture fixes and enhancements for kernel v6.6-rc2:	2023-09-13 11:35:53 -07:00
security	Landlock updates for v6.6-rc1	2023-09-08 12:06:51 -07:00
sound	sound fixes for 6.6-rc1	2023-09-08 13:07:50 -07:00
tools	selftests: hsr: Extend the testsuite to also cover HSRv1.	2023-09-18 08:26:19 +01:00
usr	initramfs: Encode dependency on KBUILD_BUILD_TIMESTAMP	2023-06-06 17:54:49 +09:00
virt	ARM:	2023-09-07 13:52:20 -07:00
.clang-format	iommu: Add for_each_group_device()	2023-05-23 08:15:51 +02:00
.cocciconfig
.get_maintainer.ignore	get_maintainer: add Alan to .get_maintainer.ignore	2022-08-20 15:17:44 -07:00
.gitattributes	.gitattributes: set diff driver for Rust source code files	2023-05-31 17:48:25 +02:00
.gitignore	kbuild: rpm-pkg: rename binkernel.spec to kernel.spec	2023-07-25 00:59:33 +09:00
.mailmap	for-linus-2023083101	2023-09-01 12:31:44 -07:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	USB: Remove Wireless USB and UWB documentation	2023-08-09 14:17:32 +02:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	MAINTAINERS: Update link for linux-ax25.org	2023-09-18 12:56:58 +01:00
Makefile	Linux 6.6-rc1	2023-09-10 16:28:41 -07:00
README	Drop all 00-INDEX files from Documentation/	2018-09-09 15:08:58 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.