Anthony DeRossi 7fdba00111 vfio: Fix container device registration life cycle ... In vfio_device_open(), vfio_device_container_register() is always called when open_count == 1. On error, vfio_device_container_unregister() is only called when open_count == 1 and close_device is set. This leaks a registration for devices without a close_device implementation. In vfio_device_fops_release(), vfio_device_container_unregister() is called unconditionally. This can cause a device to be unregistered multiple times. Treating container device registration/unregistration uniformly (always when open_count == 1) fixes both issues. Fixes: ce4b4657ff ("vfio: Replace the DMA unmapping notifier with a callback") Signed-off-by: Anthony DeRossi <ajderossi@gmail.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Reviewed-by: Yi Liu <yi.l.liu@intel.com> Link: https://lore.kernel.org/r/20221110014027.28780-2-ajderossi@gmail.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com>		2022-11-10 12:03:36 -07:00
..
fsl-mc	vfio/fsl-mc: Use the new device life cycle helpers	2022-09-21 14:15:11 -06:00
mdev	vfio/mdev: add mdev available instance checking to the core	2022-10-04 12:06:58 -06:00
pci	vfio: Add vfio_file_is_group()	2022-10-07 08:10:52 -06:00
platform	vfio/amba: Use the new device life cycle helpers	2022-09-21 14:15:11 -06:00
container.c	vfio: Change vfio_group->group_rwsem to a mutex	2022-10-04 12:06:58 -06:00
iova_bitmap.c	vfio: Add an IOVA bitmap support	2022-09-08 12:59:00 -06:00
Kconfig	vfio: Introduce the DMA logging feature support	2022-09-08 12:59:00 -06:00
Makefile	vfio: Move container code into drivers/vfio/container.c	2022-09-22 15:46:06 -06:00
vfio_iommu_spapr_tce.c	vfio/spapr_tce: Fix the comment	2022-07-22 16:24:47 -06:00
vfio_iommu_type1.c	Merge branches 'apple/dart', 'arm/mediatek', 'arm/omap', 'arm/smmu', 'virtio', 'x86/vt-d', 'x86/amd' and 'core' into next	2022-09-26 15:52:31 +02:00
vfio_main.c	vfio: Fix container device registration life cycle	2022-11-10 12:03:36 -07:00
vfio_spapr_eeh.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
vfio.h	vfio: Make the group FD disassociate from the iommu_group	2022-10-07 08:10:52 -06:00
virqfd.c	vfio/virqfd: Drain events from eventfd in virqfd_wakeup()	2020-11-15 09:49:10 -05:00