mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-22 10:34:55 +08:00
3a5ca85707
When a non-initial netns is destroyed, the usual policy is to delete
all virtual network interfaces contained, but move physical interfaces
back to the initial netns. This keeps the physical interface visible
on the system.
CAN devices are somewhat special, as they define rtnl_link_ops even
if they are physical devices. If a CAN interface is moved into a
non-initial netns, destroying that netns lets the interface vanish
instead of moving it back to the initial netns. default_device_exit()
skips CAN interfaces due to having rtnl_link_ops set. Reproducer:
ip netns add foo
ip link set can0 netns foo
ip netns delete foo
WARNING: CPU: 1 PID: 84 at net/core/dev.c:11030 ops_exit_list+0x38/0x60
CPU: 1 PID: 84 Comm: kworker/u4:2 Not tainted 5.10.19 #1
Workqueue: netns cleanup_net
[<c010e700>] (unwind_backtrace) from [<c010a1d8>] (show_stack+0x10/0x14)
[<c010a1d8>] (show_stack) from [<c086dc10>] (dump_stack+0x94/0xa8)
[<c086dc10>] (dump_stack) from [<c086b938>] (__warn+0xb8/0x114)
[<c086b938>] (__warn) from [<c086ba10>] (warn_slowpath_fmt+0x7c/0xac)
[<c086ba10>] (warn_slowpath_fmt) from [<c0629f20>] (ops_exit_list+0x38/0x60)
[<c0629f20>] (ops_exit_list) from [<c062a5c4>] (cleanup_net+0x230/0x380)
[<c062a5c4>] (cleanup_net) from [<c0142c20>] (process_one_work+0x1d8/0x438)
[<c0142c20>] (process_one_work) from [<c0142ee4>] (worker_thread+0x64/0x5a8)
[<c0142ee4>] (worker_thread) from [<c0148a98>] (kthread+0x148/0x14c)
[<c0148a98>] (kthread) from [<c0100148>] (ret_from_fork+0x14/0x2c)
To properly restore physical CAN devices to the initial netns on owning
netns exit, introduce a flag on rtnl_link_ops that can be set by drivers.
For CAN devices setting this flag, default_device_exit() considers them
non-virtual, applying the usual namespace move.
The issue was introduced in the commit mentioned below, as at that time
CAN devices did not have a dellink() operation.
Fixes: e008b5fc8d ("net: Simplfy default_device_exit and improve batching.")
Link: https://lore.kernel.org/r/20210302122423.872326-1-martin@strongswan.org
Signed-off-by: Martin Willi <martin@strongswan.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
176 lines
6.3 KiB
C
176 lines
6.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __NET_RTNETLINK_H
|
|
#define __NET_RTNETLINK_H
|
|
|
|
#include <linux/rtnetlink.h>
|
|
#include <net/netlink.h>
|
|
|
|
typedef int (*rtnl_doit_func)(struct sk_buff *, struct nlmsghdr *,
|
|
struct netlink_ext_ack *);
|
|
typedef int (*rtnl_dumpit_func)(struct sk_buff *, struct netlink_callback *);
|
|
|
|
enum rtnl_link_flags {
|
|
RTNL_FLAG_DOIT_UNLOCKED = 1,
|
|
};
|
|
|
|
void rtnl_register(int protocol, int msgtype,
|
|
rtnl_doit_func, rtnl_dumpit_func, unsigned int flags);
|
|
int rtnl_register_module(struct module *owner, int protocol, int msgtype,
|
|
rtnl_doit_func, rtnl_dumpit_func, unsigned int flags);
|
|
int rtnl_unregister(int protocol, int msgtype);
|
|
void rtnl_unregister_all(int protocol);
|
|
|
|
static inline int rtnl_msg_family(const struct nlmsghdr *nlh)
|
|
{
|
|
if (nlmsg_len(nlh) >= sizeof(struct rtgenmsg))
|
|
return ((struct rtgenmsg *) nlmsg_data(nlh))->rtgen_family;
|
|
else
|
|
return AF_UNSPEC;
|
|
}
|
|
|
|
/**
|
|
* struct rtnl_link_ops - rtnetlink link operations
|
|
*
|
|
* @list: Used internally
|
|
* @kind: Identifier
|
|
* @netns_refund: Physical device, move to init_net on netns exit
|
|
* @maxtype: Highest device specific netlink attribute number
|
|
* @policy: Netlink policy for device specific attribute validation
|
|
* @validate: Optional validation function for netlink/changelink parameters
|
|
* @priv_size: sizeof net_device private space
|
|
* @setup: net_device setup function
|
|
* @newlink: Function for configuring and registering a new device
|
|
* @changelink: Function for changing parameters of an existing device
|
|
* @dellink: Function to remove a device
|
|
* @get_size: Function to calculate required room for dumping device
|
|
* specific netlink attributes
|
|
* @fill_info: Function to dump device specific netlink attributes
|
|
* @get_xstats_size: Function to calculate required room for dumping device
|
|
* specific statistics
|
|
* @fill_xstats: Function to dump device specific statistics
|
|
* @get_num_tx_queues: Function to determine number of transmit queues
|
|
* to create when creating a new device.
|
|
* @get_num_rx_queues: Function to determine number of receive queues
|
|
* to create when creating a new device.
|
|
* @get_link_net: Function to get the i/o netns of the device
|
|
* @get_linkxstats_size: Function to calculate the required room for
|
|
* dumping device-specific extended link stats
|
|
* @fill_linkxstats: Function to dump device-specific extended link stats
|
|
*/
|
|
struct rtnl_link_ops {
|
|
struct list_head list;
|
|
|
|
const char *kind;
|
|
|
|
size_t priv_size;
|
|
void (*setup)(struct net_device *dev);
|
|
|
|
bool netns_refund;
|
|
unsigned int maxtype;
|
|
const struct nla_policy *policy;
|
|
int (*validate)(struct nlattr *tb[],
|
|
struct nlattr *data[],
|
|
struct netlink_ext_ack *extack);
|
|
|
|
int (*newlink)(struct net *src_net,
|
|
struct net_device *dev,
|
|
struct nlattr *tb[],
|
|
struct nlattr *data[],
|
|
struct netlink_ext_ack *extack);
|
|
int (*changelink)(struct net_device *dev,
|
|
struct nlattr *tb[],
|
|
struct nlattr *data[],
|
|
struct netlink_ext_ack *extack);
|
|
void (*dellink)(struct net_device *dev,
|
|
struct list_head *head);
|
|
|
|
size_t (*get_size)(const struct net_device *dev);
|
|
int (*fill_info)(struct sk_buff *skb,
|
|
const struct net_device *dev);
|
|
|
|
size_t (*get_xstats_size)(const struct net_device *dev);
|
|
int (*fill_xstats)(struct sk_buff *skb,
|
|
const struct net_device *dev);
|
|
unsigned int (*get_num_tx_queues)(void);
|
|
unsigned int (*get_num_rx_queues)(void);
|
|
|
|
unsigned int slave_maxtype;
|
|
const struct nla_policy *slave_policy;
|
|
int (*slave_changelink)(struct net_device *dev,
|
|
struct net_device *slave_dev,
|
|
struct nlattr *tb[],
|
|
struct nlattr *data[],
|
|
struct netlink_ext_ack *extack);
|
|
size_t (*get_slave_size)(const struct net_device *dev,
|
|
const struct net_device *slave_dev);
|
|
int (*fill_slave_info)(struct sk_buff *skb,
|
|
const struct net_device *dev,
|
|
const struct net_device *slave_dev);
|
|
struct net *(*get_link_net)(const struct net_device *dev);
|
|
size_t (*get_linkxstats_size)(const struct net_device *dev,
|
|
int attr);
|
|
int (*fill_linkxstats)(struct sk_buff *skb,
|
|
const struct net_device *dev,
|
|
int *prividx, int attr);
|
|
};
|
|
|
|
int __rtnl_link_register(struct rtnl_link_ops *ops);
|
|
void __rtnl_link_unregister(struct rtnl_link_ops *ops);
|
|
|
|
int rtnl_link_register(struct rtnl_link_ops *ops);
|
|
void rtnl_link_unregister(struct rtnl_link_ops *ops);
|
|
|
|
/**
|
|
* struct rtnl_af_ops - rtnetlink address family operations
|
|
*
|
|
* @list: Used internally
|
|
* @family: Address family
|
|
* @fill_link_af: Function to fill IFLA_AF_SPEC with address family
|
|
* specific netlink attributes.
|
|
* @get_link_af_size: Function to calculate size of address family specific
|
|
* netlink attributes.
|
|
* @validate_link_af: Validate a IFLA_AF_SPEC attribute, must check attr
|
|
* for invalid configuration settings.
|
|
* @set_link_af: Function to parse a IFLA_AF_SPEC attribute and modify
|
|
* net_device accordingly.
|
|
*/
|
|
struct rtnl_af_ops {
|
|
struct list_head list;
|
|
int family;
|
|
|
|
int (*fill_link_af)(struct sk_buff *skb,
|
|
const struct net_device *dev,
|
|
u32 ext_filter_mask);
|
|
size_t (*get_link_af_size)(const struct net_device *dev,
|
|
u32 ext_filter_mask);
|
|
|
|
int (*validate_link_af)(const struct net_device *dev,
|
|
const struct nlattr *attr);
|
|
int (*set_link_af)(struct net_device *dev,
|
|
const struct nlattr *attr);
|
|
|
|
int (*fill_stats_af)(struct sk_buff *skb,
|
|
const struct net_device *dev);
|
|
size_t (*get_stats_af_size)(const struct net_device *dev);
|
|
};
|
|
|
|
void rtnl_af_register(struct rtnl_af_ops *ops);
|
|
void rtnl_af_unregister(struct rtnl_af_ops *ops);
|
|
|
|
struct net *rtnl_link_get_net(struct net *src_net, struct nlattr *tb[]);
|
|
struct net_device *rtnl_create_link(struct net *net, const char *ifname,
|
|
unsigned char name_assign_type,
|
|
const struct rtnl_link_ops *ops,
|
|
struct nlattr *tb[],
|
|
struct netlink_ext_ack *extack);
|
|
int rtnl_delete_link(struct net_device *dev);
|
|
int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm);
|
|
|
|
int rtnl_nla_parse_ifla(struct nlattr **tb, const struct nlattr *head, int len,
|
|
struct netlink_ext_ack *exterr);
|
|
struct net *rtnl_get_net_ns_capable(struct sock *sk, int netnsid);
|
|
|
|
#define MODULE_ALIAS_RTNL_LINK(kind) MODULE_ALIAS("rtnl-link-" kind)
|
|
|
|
#endif
|