Davide Caratti fa4e0f8855 net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions ... the following script: # tc qdisc add dev eth0 clsact # tc filter add dev eth0 egress protocol ip matchall \ > action mpls push protocol mpls_uc label 0x355aa bos 1 causes corruption of all IP packets transmitted by eth0. On TC egress, we can't rely on the value of skb->mac_len, because it's 0 and a MPLS 'push' operation will result in an overwrite of the first 4 octets in the packet L2 header (e.g. the Destination Address if eth0 is an Ethernet); the same error pattern is present also in the MPLS 'pop' operation. Fix this error in act_mpls data plane, computing 'mac_len' as the difference between the network header and the mac header (when not at TC ingress), and use it in MPLS 'push'/'pop' core functions. v2: unbreak 'make htmldocs' because of missing documentation of 'mac_len' in skb_mpls_pop(), reported by kbuild test robot CC: Lorenzo Bianconi <lorenzo@kernel.org> Fixes: 2a2ea50870 ("net: sched: add mpls manipulation actions to TC") Reviewed-by: Simon Horman <simon.horman@netronome.com> Acked-by: John Hurley <john.hurley@netronome.com> Signed-off-by: Davide Caratti <dcaratti@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-10-15 17:14:48 -07:00
..
bpf_sk_storage.c	bpf: support cloning sk storage on accept()	2019-08-17 23:18:54 +02:00
datagram.c	tcp: annotate sk->sk_wmem_queued lockless reads	2019-10-13 10:13:08 -07:00
datagram.h	net/core: Allow the compiler to verify declaration and definition consistency	2019-03-27 13:49:44 -07:00
dev_addr_lists.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
dev_ioctl.c	net/core: Document all dev_ioctl() arguments	2019-03-27 13:49:43 -07:00
dev.c	sk_buff: drop all skb extensions on free and skb scrubbing	2019-09-27 20:40:19 +02:00
devlink.c	devlink: Fix error handling in param and info_get dumpit cb	2019-10-01 10:08:30 -07:00
drop_monitor.c	drop_monitor: Better sanitize notified packets	2019-09-16 21:39:27 +02:00
dst_cache.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
dst.c	net: print proper warning on dst underflow	2019-09-26 09:05:56 +02:00
ethtool.c	ethtool: implement Energy Detect Powerdown support via phy-tunable	2019-09-16 22:02:45 +02:00
failover.c	failover: allow name change on IFF_UP slave interfaces	2019-04-10 22:12:26 -07:00
fib_notifier.c	net: fib_notifier: move fib_notifier_ops from struct net into per-net struct	2019-09-07 17:28:22 +02:00
fib_rules.c	SPDX update for 5.2-rc4	2019-06-08 12:52:42 -07:00
filter.c	tcp: annotate sk->sk_sndbuf lockless reads	2019-10-13 10:13:08 -07:00
flow_dissector.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-08-27 14:23:31 -07:00
flow_offload.c	net: flow_offload: convert block_ing_cb_list to regular list type	2019-08-19 13:02:38 -07:00
gen_estimator.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
gen_stats.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
gro_cells.c	gro_cells: make sure device is up in gro_cells_receive()	2019-03-10 11:07:14 -07:00
hwbm.c	net: hwbm: Make the hwbm_pool lock a mutex	2019-06-09 19:40:10 -07:00
link_watch.c	net: link_watch: prevent starvation when processing linkwatch wq	2019-07-01 19:02:47 -07:00
lwt_bpf.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
lwtunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Makefile	bpf: Introduce bpf sk local storage	2019-04-27 09:07:04 -07:00
neighbour.c	net: neigh: remove redundant assignment to variable bucket	2019-07-27 13:32:06 -07:00
net_namespace.c	netns: fix NLM_F_ECHO mechanism for RTM_NEWNSID	2019-10-09 20:58:05 -07:00
net-procfs.c	treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively	2019-04-09 14:19:06 +02:00
net-sysfs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
net-sysfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
net-traces.c	page_pool: add tracepoints for page_pool with details need by XDP	2019-06-19 11:23:13 -04:00
netclassid_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netevent.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netpoll.c	net: fix skb use after free in netpoll	2019-08-27 20:52:02 -07:00
netprio_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
page_pool.c	page_pool: fix logic in __page_pool_get_cached	2019-08-15 12:27:36 -07:00
pktgen.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2019-09-18 12:34:53 -07:00
ptp_classifier.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
request_sock.c	tcp: add rcu protection around tp->fastopen_rsk	2019-10-13 10:13:08 -07:00
rtnetlink.c	rtnetlink: skip metrics loop for dst_default_metrics	2019-06-26 13:14:59 -07:00
scm.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
secure_seq.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
skbuff.c	net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions	2019-10-15 17:14:48 -07:00
skmsg.c	net/core/skmsg: Delete an unnecessary check before the function call “consume_skb”	2019-08-24 16:24:53 -07:00
sock_diag.c	sock: make cookie generation global instead of per netns	2019-08-09 13:14:46 -07:00
sock_map.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-15 14:17:27 +02:00
sock_reuseport.c	udp: correct reuseport selection with connected sockets	2019-09-16 09:02:18 +02:00
sock.c	tcp: annotate sk->sk_wmem_queued lockless reads	2019-10-13 10:13:08 -07:00
stream.c	tcp: make sure EPOLLOUT wont be missed	2019-08-19 13:07:43 -07:00
sysctl_net_core.c	net: use listified RX for handling GRO_NORMAL skbs	2019-08-08 18:22:29 -07:00
timestamping.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tso.c	net: Use skb accessors in network core	2019-07-22 20:47:56 -07:00
utils.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xdp.c	net: core: page_pool: add user refcnt and reintroduce page_pool_destroy	2019-07-08 14:58:04 -07:00