Quentin Perret 638be56ae9 KVM: arm64: Prevent kmemleak from accessing pKVM memory ... [ Upstream commit 56961c6331 ] Commit a7259df767 ("memblock: make memblock_find_in_range method private") changed the API using which memory is reserved for the pKVM hypervisor. However, memblock_phys_alloc() differs from the original API in terms of kmemleak semantics -- the old one didn't report the reserved regions to kmemleak while the new one does. Unfortunately, when protected KVM is enabled, all kernel accesses to pKVM-private memory result in a fatal exception, which can now happen because of kmemleak scans: $ echo scan > /sys/kernel/debug/kmemleak [ 34.991354] kvm [304]: nVHE hyp BUG at: [<ffff800008fa3750>] __kvm_nvhe_handle_host_mem_abort+0x270/0x290! [ 34.991580] kvm [304]: Hyp Offset: 0xfffe8be807e00000 [ 34.991813] Kernel panic - not syncing: HYP panic: [ 34.991813] PS:600003c9 PC:0000f418011a3750 ESR:00000000f2000800 [ 34.991813] FAR:ffff000439200000 HPFAR:0000000004792000 PAR:0000000000000000 [ 34.991813] VCPU:0000000000000000 [ 34.993660] CPU: 0 PID: 304 Comm: bash Not tainted 5.19.0-rc2 #102 [ 34.994059] Hardware name: linux,dummy-virt (DT) [ 34.994452] Call trace: [ 34.994641] dump_backtrace.part.0+0xcc/0xe0 [ 34.994932] show_stack+0x18/0x6c [ 34.995094] dump_stack_lvl+0x68/0x84 [ 34.995276] dump_stack+0x18/0x34 [ 34.995484] panic+0x16c/0x354 [ 34.995673] __hyp_pgtable_total_pages+0x0/0x60 [ 34.995933] scan_block+0x74/0x12c [ 34.996129] scan_gray_list+0xd8/0x19c [ 34.996332] kmemleak_scan+0x2c8/0x580 [ 34.996535] kmemleak_write+0x340/0x4a0 [ 34.996744] full_proxy_write+0x60/0xbc [ 34.996967] vfs_write+0xc4/0x2b0 [ 34.997136] ksys_write+0x68/0xf4 [ 34.997311] __arm64_sys_write+0x20/0x2c [ 34.997532] invoke_syscall+0x48/0x114 [ 34.997779] el0_svc_common.constprop.0+0x44/0xec [ 34.998029] do_el0_svc+0x2c/0xc0 [ 34.998205] el0_svc+0x2c/0x84 [ 34.998421] el0t_64_sync_handler+0xf4/0x100 [ 34.998653] el0t_64_sync+0x18c/0x190 [ 34.999252] SMP: stopping secondary CPUs [ 35.000034] Kernel Offset: disabled [ 35.000261] CPU features: 0x800,00007831,00001086 [ 35.000642] Memory Limit: none [ 35.001329] ---[ end Kernel panic - not syncing: HYP panic: [ 35.001329] PS:600003c9 PC:0000f418011a3750 ESR:00000000f2000800 [ 35.001329] FAR:ffff000439200000 HPFAR:0000000004792000 PAR:0000000000000000 [ 35.001329] VCPU:0000000000000000 ]--- Fix this by explicitly excluding the hypervisor's memory pool from kmemleak like we already do for the hyp BSS. Cc: Mike Rapoport <rppt@kernel.org> Fixes: a7259df767 ("memblock: make memblock_find_in_range method private") Signed-off-by: Quentin Perret <qperret@google.com> Acked-by: Catalin Marinas <catalin.marinas@arm.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220616161135.3997786-1-qperret@google.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-06-29 09:03:22 +02:00
..
hyp	arm64: Use the clearbhb instruction in mitigations	2022-03-11 12:22:35 +01:00
vgic	KVM: arm64: Don't read a HW interrupt pending state in user context	2022-06-22 14:22:05 +02:00
arch_timer.c	KVM: arm64: timer: Add support for SW-based deactivation	2021-06-01 10:46:00 +01:00
arm.c	KVM: arm64: Prevent kmemleak from accessing pKVM memory	2022-06-29 09:03:22 +02:00
debug.c	KVM: arm64: MDCR_EL2 is a 64-bit register	2021-08-20 11:12:17 +01:00
fpsimd.c	KVM: arm64: Save/restore SVE state for nVHE	2021-03-18 14:23:12 +00:00
guest.c	KVM/arm64 updates for 5.15	2021-09-06 06:34:48 -04:00
handle_exit.c	KVM: arm64: Stop handle_exit() from handling HVC twice when an SError occurs	2022-02-08 18:34:06 +01:00
hypercalls.c	KVM: arm64: Allow SMCCC_ARCH_WORKAROUND_3 to be discovered and migrated	2022-03-11 12:22:35 +01:00
inject_fault.c	KVM: arm64: Move AArch32 exceptions over to AArch64 sysregs	2020-11-10 11:22:51 +00:00
irq.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 422	2019-06-05 17:37:15 +02:00
Kconfig	Merge branch kvm-arm64/generic-entry into kvmarm-master/next	2021-08-20 12:23:09 +01:00
Makefile	KVM: stats: Add fd-based API to read binary stats data	2021-06-24 11:47:57 -04:00
mmio.c	KVM: arm64: Make kvm_skip_instr() and co private to HYP	2020-11-10 08:34:24 +00:00
mmu.c	KVM: arm64: Release mmap_lock when using VM_SHARED with MTE	2021-10-05 13:22:45 +01:00
perf.c	KVM: arm64: Fix PMU probe ordering	2021-09-20 12:43:34 +01:00
pmu-emul.c	KVM: arm64: Fix PMU probe ordering	2021-09-20 12:43:34 +01:00
pmu.c	KVM: arm64: Disable PMU support in protected mode	2021-03-19 12:02:19 +00:00
psci.c	KVM: arm64: Allow SMCCC_ARCH_WORKAROUND_3 to be discovered and migrated	2022-03-11 12:22:35 +01:00
pvtime.c	KVM: arm64: Use kvm_write_guest_lock when init stolen time	2020-12-03 19:02:18 +00:00
reset.c	Merge branch kvm-arm64/psci/cpu_on into kvmarm-master/next	2021-08-20 12:23:02 +01:00
sys_regs.c	arm64: add ID_AA64ISAR2_EL1 sys register	2022-03-11 12:22:33 +01:00
sys_regs.h	KVM: arm64: Refactor sys_regs.h,c for nVHE reuse	2021-08-20 11:12:17 +01:00
trace_arm.h	KVM: Move arm64's MMU notifier trace events to generic code	2021-04-17 08:30:56 -04:00
trace_handle_exit.h	KVM: arm64: Upgrade trace_kvm_arm_set_dreg32() to 64bit	2021-08-20 11:12:18 +01:00
trace.h	KVM: arm64: Move virt/kvm/arm to arch/arm64	2020-05-16 15:03:59 +01:00
trng.c	KVM: arm64: Implement the TRNG hypervisor call	2021-01-25 22:19:31 +00:00
va_layout.c	KVM: arm64: Generate final CTR_EL0 value when running in Protected mode	2021-03-25 11:00:33 +00:00
vgic-sys-reg-v3.c	KVM: arm64: Drop is_aarch32 trap attribute	2020-11-10 11:22:52 +00:00