Eric Dumazet 75475bb51e ipv6: fix potential NULL deref in fib6_add() ... If fib6_find_prefix() returns NULL, we should silently fallback using fib6_null_entry regardless of RT6_DEBUG value. syzbot reported: WARNING: CPU: 0 PID: 5477 at net/ipv6/ip6_fib.c:1516 fib6_add+0x310d/0x3fa0 net/ipv6/ip6_fib.c:1516 Modules linked in: CPU: 0 PID: 5477 Comm: syz-executor.0 Not tainted 6.7.0-rc2-syzkaller-00029-g9b6de136b5f0 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023 RIP: 0010:fib6_add+0x310d/0x3fa0 net/ipv6/ip6_fib.c:1516 Code: 00 48 8b 54 24 68 e8 42 22 00 00 48 85 c0 74 14 49 89 c6 e8 d5 d3 c2 f7 eb 5d e8 ce d3 c2 f7 e9 ca 00 00 00 e8 c4 d3 c2 f7 90 <0f> 0b 90 48 b8 00 00 00 00 00 fc ff df 48 8b 4c 24 38 80 3c 01 00 RSP: 0018:ffffc90005067740 EFLAGS: 00010293 RAX: ffffffff89cba5bc RBX: ffffc90005067ab0 RCX: ffff88801a2e9dc0 RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000 RBP: ffffc90005067980 R08: ffffffff89cbca85 R09: 1ffff110040d4b85 R10: dffffc0000000000 R11: ffffed10040d4b86 R12: 00000000ffffffff R13: 1ffff110051c3904 R14: ffff8880206a5c00 R15: ffff888028e1c820 FS: 00007f763783c6c0(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f763783bff8 CR3: 000000007f74d000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> __ip6_ins_rt net/ipv6/route.c:1303 [inline] ip6_route_add+0x88/0x120 net/ipv6/route.c:3847 ipv6_route_ioctl+0x525/0x7b0 net/ipv6/route.c:4467 inet6_ioctl+0x21a/0x270 net/ipv6/af_inet6.c:575 sock_do_ioctl+0x152/0x460 net/socket.c:1220 sock_ioctl+0x615/0x8c0 net/socket.c:1339 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82 Fixes: 7bbfe00e02 ("ipv6: fix general protection fault in fib6_add()") Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Wei Wang <weiwan@google.com> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20231129160630.3509216-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-11-30 23:20:14 -08:00
..
ila	ila: Remove unnecessary file net/ila.h	2023-08-02 12:28:16 -07:00
netfilter	netfilter: add missing module descriptions	2023-11-08 13:52:32 +01:00
addrconf_core.c	net: rename reference+tracking helpers	2022-06-09 21:52:55 -07:00
addrconf.c	net: ipv6/addrconf: clamp preferred_lft to the minimum required	2023-10-25 18:23:06 -07:00
addrlabel.c	ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network	2022-11-07 12:26:15 +00:00
af_inet6.c	ipsec-next-2023-10-28	2023-10-30 14:36:57 -07:00
ah6.c	net: ipv6: stop checking crypto_ahash_alignmask	2023-10-27 18:04:29 +08:00
anycast.c	IPv6: add extack info for IPv6 address add/delete	2023-07-28 11:01:56 +01:00
calipso.c	cipso,calipso: resolve a number of problems with the DOI refcounts	2021-03-04 15:26:57 -08:00
datagram.c	ipv6: lockless IPV6_FLOWINFO_SEND implementation	2023-09-15 10:33:48 +01:00
esp6_offload.c	xfrm: Support GRO for IPv6 ESP in UDP encapsulation	2023-10-06 07:31:14 +02:00
esp6.c	net: ipv6: fix typo in comments	2023-10-25 10:38:07 +01:00
exthdrs_core.c	ipv6: Fix out-of-bounds access in ipv6_find_tlv()	2023-05-24 08:43:39 +01:00
exthdrs_offload.c
exthdrs.c	ipv6: exthdrs: Replace opencoded swap() implementation	2023-08-08 15:36:47 -07:00
fib6_notifier.c
fib6_rules.c	ipv6: change fib6_rules_net_exit() to batch mode	2022-02-08 20:41:34 -08:00
fou6.c
icmp.c	xfrm: pass struct net to xfrm_decode_session wrappers	2023-10-06 08:31:53 +02:00
inet6_connection_sock.c	net: implement lockless SO_PRIORITY	2023-10-01 19:09:54 +01:00
inet6_hashtables.c	net: remove duplicate INDIRECT_CALLABLE_DECLARE of udp[6]_ehashfn	2023-07-31 13:53:10 -07:00
ioam6_iptunnel.c	netlink: make range pointers in policies const	2023-10-26 16:24:09 -07:00
ioam6.c	genetlink: start to validate reserved header bytes	2022-08-29 12:47:15 +01:00
ip6_checksum.c
ip6_fib.c	ipv6: fix potential NULL deref in fib6_add()	2023-11-30 23:20:14 -08:00
ip6_flowlabel.c	ipv6: move np->repflow to atomic flags	2023-09-15 10:33:48 +01:00
ip6_gre.c	net:ipv6: check return value of pskb_trim()	2023-07-19 12:25:58 +01:00
ip6_icmp.c	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-02-23 11:29:52 -08:00
ip6_input.c	ipv6: ignore dst hint for multipath routes	2023-09-01 08:11:51 +01:00
ip6_offload.c	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
ip6_offload.h
ip6_output.c	ipv6: avoid atomic fragment on GSO packets	2023-10-25 18:04:29 -07:00
ip6_tunnel.c	net: tunnels: annotate lockless accesses to dev->needed_headroom	2023-03-15 00:04:04 -07:00
ip6_udp_tunnel.c	ipv6: add new arguments to udp_tunnel6_dst_lookup()	2023-10-23 08:48:57 +01:00
ip6_vti.c	xfrm: pass struct net to xfrm_decode_session wrappers	2023-10-06 08:31:53 +02:00
ip6mr.c	net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated	2023-08-30 09:44:09 +01:00
ipcomp6.c	xfrm: ipcomp: add extack to ipcomp{4,6}_init_state	2022-09-29 07:18:00 +02:00
ipv6_sockglue.c	ipv6: lockless IPV6_ADDR_PREFERENCES implementation	2023-09-19 18:21:44 +02:00
Kconfig	ipv6: fix indentation of a config attribute	2023-08-16 10:03:08 +01:00
Makefile	net/tcp: Introduce TCP_AO setsockopt()s	2023-10-27 10:35:44 +01:00
mcast_snoop.c	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-04-27 14:02:06 -07:00
mcast.c	net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams.	2023-10-20 12:01:00 +01:00
mip6.c	xfrm: mip6: add extack to mip6_destopt_init_state, mip6_rthdr_init_state	2022-09-29 07:18:01 +02:00
ndisc.c	net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams.	2023-10-20 12:01:00 +01:00
netfilter.c	xfrm: pass struct net to xfrm_decode_session wrappers	2023-10-06 08:31:53 +02:00
output_core.c	treewide: use get_random_u32_{above,below}() instead of manual loop	2022-11-18 02:15:22 +01:00
ping.c	bpf: Propagate modified uaddrlen from cgroup sockaddr programs	2023-10-11 15:03:40 -07:00
proc.c	net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams.	2023-10-20 12:01:00 +01:00
protocol.c
raw.c	net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams.	2023-10-20 12:01:00 +01:00
reassembly.c	networking: Update to register_net_sysctl_sz	2023-08-15 15:26:18 -07:00
route.c	ipv6: lockless IPV6_ADDR_PREFERENCES implementation	2023-09-19 18:21:44 +02:00
rpl_iptunnel.c	ipv6: rpl: Remove redundant skb_dst_drop().	2023-07-12 17:12:29 -07:00
rpl.c	ipv6: rpl: Remove pskb(_may)?_pull() in ipv6_rpl_srh_rcv().	2023-06-19 11:32:58 -07:00
seg6_hmac.c	net: ipv6: unexport __init-annotated seg6_hmac_net_init()	2022-06-28 21:23:30 -07:00
seg6_iptunnel.c	seg6: Cleanup duplicates of skb_dst_drop calls	2023-05-17 09:05:47 +01:00
seg6_local.c	seg6: add NEXT-C-SID support for SRv6 End.X behavior	2023-08-15 18:51:47 -07:00
seg6.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-09-08 18:38:30 +02:00
sit.c	sit: update dev->needed_headroom in ipip6_tunnel_bind_dev()	2023-04-28 09:48:14 +01:00
syncookies.c	dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.	2023-11-02 12:56:03 +01:00
sysctl_net_ipv6.c	networking: Update to register_net_sysctl_sz	2023-08-15 15:26:18 -07:00
tcp_ao.c	net/tcp: Wire up l3index to TCP-AO	2023-10-27 10:35:46 +01:00
tcp_ipv6.c	net/tcp: Wire up l3index to TCP-AO	2023-10-27 10:35:46 +01:00
tcpv6_offload.c	net: Make gro complete function to return void	2023-05-31 09:50:17 +01:00
tunnel6.c
udp_impl.h	tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().	2022-10-12 17:50:37 -07:00
udp_offload.c	net: gro: fix misuse of CB in udp socket lookup	2023-07-29 17:10:27 +01:00
udp.c	bpf: Propagate modified uaddrlen from cgroup sockaddr programs	2023-10-11 15:03:40 -07:00
udplite.c	udplite: remove UDPLITE_BIT	2023-09-14 16:16:36 +02:00
xfrm6_input.c	xfrm Fix use after free in __xfrm6_udp_encap_rcv.	2023-10-23 07:10:39 +02:00
xfrm6_output.c	ipv6: drop feature RTAX_FEATURE_ALLFRAG	2023-10-25 18:04:29 -07:00
xfrm6_policy.c	ipsec-2023-10-17	2023-10-17 18:21:13 -07:00
xfrm6_protocol.c
xfrm6_state.c
xfrm6_tunnel.c	xfrm: tunnel: add extack to ipip_init_state, xfrm6_tunnel_init_state	2022-09-29 07:18:00 +02:00