Yuan Can cab345f9d5 platform/chrome: cros_usbpd_notify: Fix error handling in cros_usbpd_notify_init() ... [ Upstream commit 5a2d966236 ] The following WARNING message was given when rmmod cros_usbpd_notify: Unexpected driver unregister! WARNING: CPU: 0 PID: 253 at drivers/base/driver.c:270 driver_unregister+0x8a/0xb0 Modules linked in: cros_usbpd_notify(-) CPU: 0 PID: 253 Comm: rmmod Not tainted 6.1.0-rc3 #24 ... Call Trace: <TASK> cros_usbpd_notify_exit+0x11/0x1e [cros_usbpd_notify] __x64_sys_delete_module+0x3c7/0x570 ? __ia32_sys_delete_module+0x570/0x570 ? lock_is_held_type+0xe3/0x140 ? syscall_enter_from_user_mode+0x17/0x50 ? rcu_read_lock_sched_held+0xa0/0xd0 ? syscall_enter_from_user_mode+0x1c/0x50 do_syscall_64+0x37/0x90 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f333fe9b1b7 The reason is that the cros_usbpd_notify_init() does not check the return value of platform_driver_register(), and the cros_usbpd_notify can install successfully even if platform_driver_register() failed. Fix by checking the return value of platform_driver_register() and unregister cros_usbpd_notify_plat_driver when it failed. Fixes: ec2daf6e33 ("platform: chrome: Add cros-usbpd-notify driver") Signed-off-by: Yuan Can <yuancan@huawei.com> Reviewed-by: Brian Norris <briannorris@chromium.org> Link: https://lore.kernel.org/r/20221117080823.77549-1-yuancan@huawei.com Signed-off-by: Prashant Malani <pmalani@chromium.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-12-31 13:14:02 +01:00
..
chrome	platform/chrome: cros_usbpd_notify: Fix error handling in cros_usbpd_notify_init()	2022-12-31 13:14:02 +01:00
goldfish	platform/goldfish: Convert pipe tasklet to threaded irq	2021-01-27 14:57:06 +01:00
mellanox	platform/mellanox: mlxbf-pmc: Fix an IS_ERR() vs NULL bug in mlxbf_pmc_map_counters	2022-01-05 12:42:33 +01:00
mips	MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.	2022-06-22 14:21:58 +02:00
olpc	platform/olpc: Fix uninitialized data in debugfs write	2022-08-17 14:23:58 +02:00
surface	platform/surface: aggregator: Do not check for repeated unsequenced packets	2022-11-26 09:24:41 +01:00
x86	platform/x86: huawei-wmi: fix return value calculation	2022-12-31 13:14:02 +01:00
Kconfig	platform: Add Surface platform directory	2020-10-27 12:51:03 +01:00
Makefile	platform: Add Surface platform directory	2020-10-27 12:51:03 +01:00