linux/drivers/net/ethernet/intel/ice
Dave Ertman 73e30a62b1 ice: Avoid crash from unnecessary IDA free
In the remove path, there is an attempt to free the aux_idx IDA whether
it was allocated or not.  This can potentially cause a crash when
unloading the driver on systems that do not initialize support for RDMA.
But, this free cannot be gated by the status bit for RDMA, since it is
allocated if the driver detects support for RDMA at probe time, but the
driver can enter into a state where RDMA is not supported after the IDA
has been allocated at probe time and this would lead to a memory leak.

Initialize aux_idx to an invalid value and check for a valid value when
unloading to determine if an IDA free is necessary.

Fixes: d25a0fc41c ("ice: Initialize RDMA support")
Reported-by: Jun Miao <jun.miao@windriver.com>
Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Tested-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-10-14 10:14:45 -07:00
..
ice_adminq_cmd.h ice: add support for set/get of driver-stored firmware parameters 2021-06-11 07:38:00 -07:00
ice_arfs.c ice: Delay netdev registration 2021-03-31 14:21:27 -07:00
ice_arfs.h ice: use static inline for dummy functions 2021-06-07 08:59:01 -07:00
ice_base.c ice: enable transmit timestamps for E810 devices 2021-06-11 08:47:41 -07:00
ice_base.h ice: Refactor ice_setup_rx_ctx 2021-06-07 08:58:56 -07:00
ice_common.c ice: register 1588 PTP clock device object for E810 devices 2021-06-11 08:47:30 -07:00
ice_common.h ice: register 1588 PTP clock device object for E810 devices 2021-06-11 08:47:30 -07:00
ice_controlq.c ice: add support for sideband messages 2021-06-11 07:38:00 -07:00
ice_controlq.h ice: add support for sideband messages 2021-06-11 07:38:00 -07:00
ice_dcb_lib.c ice: Fix a memory leak in an error handling path in 'ice_pf_dcb_cfg()' 2021-06-25 11:30:50 -07:00
ice_dcb_lib.h ice: use static inline for dummy functions 2021-06-07 08:59:01 -07:00
ice_dcb_nl.c ice: remove DCBNL_DEVRESET bit from PF state 2021-03-29 10:37:19 -07:00
ice_dcb_nl.h ice: use static inline for dummy functions 2021-06-07 08:59:01 -07:00
ice_dcb.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2021-04-17 11:08:07 -07:00
ice_dcb.h ice: replace single-element array used for C struct hack 2020-07-01 16:35:23 -07:00
ice_devids.h ice: fix define for E822 backplane device 2020-02-19 13:39:33 -08:00
ice_devlink.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2021-08-26 17:57:57 -07:00
ice_devlink.h ice: refactor devlink_port to be per-VSI 2020-10-09 13:14:19 -07:00
ice_ethtool_fdir.c ice: Drop leading underscores in enum ice_pf_state 2021-04-14 17:00:05 -07:00
ice_ethtool.c ethtool: extend coalesce setting uAPI with CQE mode 2021-08-24 07:38:29 -07:00
ice_fdir.c ice: Fix prototype warnings 2021-03-23 11:34:02 -07:00
ice_fdir.h ice: Add more FDIR filter type for AVF 2021-03-22 11:32:12 -07:00
ice_flex_pipe.c ice: suppress false cppcheck issues 2021-04-14 17:12:17 -07:00
ice_flex_pipe.h ice: Support to separate GTP-U uplink and downlink 2021-03-22 11:32:12 -07:00
ice_flex_type.h ice: cleanup style issues 2021-03-31 14:21:28 -07:00
ice_flow.c ice: Support RSS configure removal for AVF 2021-04-22 09:26:22 -07:00
ice_flow.h ice: Support RSS configure removal for AVF 2021-04-22 09:26:22 -07:00
ice_fltr.c ice: refactor filter functions 2020-05-21 22:10:04 -07:00
ice_fltr.h ice: refactor filter functions 2020-05-21 22:10:04 -07:00
ice_fw_update.c ice: add error message when pldmfw_flash_image fails 2021-06-07 08:59:01 -07:00
ice_fw_update.h ice: add support for flash update overwrite mask 2020-09-25 17:20:57 -07:00
ice_hw_autogen.h ice: add support for auxiliary input/output pins 2021-06-25 11:30:49 -07:00
ice_idc_int.h ice: Implement iidc operations 2021-05-28 20:11:13 -07:00
ice_idc.c ice: Correctly deal with PFs that do not support RDMA 2021-09-10 09:58:55 +01:00
ice_lag.c ice: Initialize RDMA support 2021-05-28 20:11:13 -07:00
ice_lag.h ice: Add initial support framework for LAG 2021-02-08 16:27:01 -08:00
ice_lan_tx_rx.h ice: report hash type such as L2/L3/L4 2021-06-18 08:59:46 -07:00
ice_lib.c ice: Fix failure to re-add LAN/RDMA Tx queues 2021-10-14 10:14:00 -07:00
ice_lib.h ice: enable receive hardware timestamping 2021-06-11 08:47:41 -07:00
ice_main.c ice: Avoid crash from unnecessary IDA free 2021-10-14 10:14:45 -07:00
ice_nvm.c ice: suppress false cppcheck issues 2021-04-14 17:12:17 -07:00
ice_nvm.h ice: display stored UNDI firmware version via devlink info 2021-02-05 11:44:16 -08:00
ice_osdep.h
ice_protocol_type.h ice: Add more advanced protocol support in flow filter 2021-03-22 11:32:12 -07:00
ice_ptp_hw.c ice: remove redundant continue statement in a for-loop 2021-06-17 09:25:06 -07:00
ice_ptp_hw.h ice: add low level PTP clock access functions 2021-06-11 07:38:00 -07:00
ice_ptp.c ice: fix locking for Tx timestamp tracking flush 2021-10-12 12:10:39 +01:00
ice_ptp.h ice: add support for auxiliary input/output pins 2021-06-25 11:30:49 -07:00
ice_sbq_cmd.h ice: add support for sideband messages 2021-06-11 07:38:00 -07:00
ice_sched.c ice: Fix failure to re-add LAN/RDMA Tx queues 2021-10-14 10:14:00 -07:00
ice_sched.h ice: Fix failure to re-add LAN/RDMA Tx queues 2021-10-14 10:14:00 -07:00
ice_sriov.c ice: warn about potentially malicious VFs 2021-04-22 09:26:22 -07:00
ice_sriov.h ice: warn about potentially malicious VFs 2021-04-22 09:26:22 -07:00
ice_status.h ice: display stored netlist versions via devlink info 2021-02-05 11:43:37 -08:00
ice_switch.c ice: Implement iidc operations 2021-05-28 20:11:13 -07:00
ice_switch.h ice: Remove the repeated declaration 2021-06-17 09:19:59 -07:00
ice_trace.h ice: add tracepoints 2021-06-25 08:32:18 -07:00
ice_txrx_lib.c ice: report hash type such as L2/L3/L4 2021-06-18 08:59:46 -07:00
ice_txrx_lib.h ice: report hash type such as L2/L3/L4 2021-06-18 08:59:46 -07:00
ice_txrx.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next 2021-06-28 15:28:03 -07:00
ice_txrx.h ice: enable transmit timestamps for E810 devices 2021-06-11 08:47:41 -07:00
ice_type.h ice: add low level PTP clock access functions 2021-06-11 07:38:00 -07:00
ice_virtchnl_allowlist.c ice: Enable RSS configure for AVF 2021-04-22 09:26:22 -07:00
ice_virtchnl_allowlist.h ice: Allow ignoring opcodes on specific VF 2021-04-22 09:26:22 -07:00
ice_virtchnl_fdir.c ice: Drop leading underscores in enum ice_pf_state 2021-04-14 17:00:05 -07:00
ice_virtchnl_fdir.h ice: Check FDIR program status for AVF 2021-03-22 11:32:12 -07:00
ice_virtchnl_pf.c ice: Stop processing VF messages during teardown 2021-08-09 09:59:23 -07:00
ice_virtchnl_pf.h ice: use static inline for dummy functions 2021-06-07 08:59:01 -07:00
ice_xsk.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next 2021-06-28 15:28:03 -07:00
ice_xsk.h ice: use static inline for dummy functions 2021-06-07 08:59:01 -07:00
ice.h ice: Correctly deal with PFs that do not support RDMA 2021-09-10 09:58:55 +01:00
Makefile ice: register 1588 PTP clock device object for E810 devices 2021-06-11 08:47:30 -07:00