Boris Burkov 6fd4d27dac btrfs: fix start transaction qgroup rsv double free ... commit a649684967 upstream. btrfs_start_transaction reserves metadata space of the PERTRANS type before it identifies a transaction to start/join. This allows flushing when reserving that space without a deadlock. However, it results in a race which temporarily breaks qgroup rsv accounting. T1 T2 start_transaction do_stuff start_transaction qgroup_reserve_meta_pertrans commit_transaction qgroup_free_meta_all_pertrans hit an error starting txn goto reserve_fail qgroup_free_meta_pertrans (already freed!) The basic issue is that there is nothing preventing another commit from committing before start_transaction finishes (in fact sometimes we intentionally wait for it) so any error path that frees the reserve is at risk of this race. While this exact space was getting freed anyway, and it's not a huge deal to double free it (just a warning, the free code catches this), it can result in incorrectly freeing some other pertrans reservation in this same reservation, which could then lead to spuriously granting reservations we might not have the space for. Therefore, I do believe it is worth fixing. To fix it, use the existing prealloc->pertrans conversion mechanism. When we first reserve the space, we reserve prealloc space and only when we are sure we have a transaction do we convert it to pertrans. This way any racing commits do not blow away our reservation, but we still get a pertrans reservation that is freed when _this_ transaction gets committed. This issue can be reproduced by running generic/269 with either qgroups or squotas enabled via mkfs on the scratch device. Reviewed-by: Josef Bacik <josef@toxicpanda.com> CC: stable@vger.kernel.org # 5.10+ Signed-off-by: Boris Burkov <boris@bur.io> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-09-19 12:30:23 +02:00
..
9p	fs/9p: Remove unused extern declaration	2023-07-20 19:21:48 +00:00
adfs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
affs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
afs	afs: Fix accidental truncation when storing data	2023-07-04 12:24:32 -07:00
autofs	arch/*/configs/*defconfig: Replace AUTOFS4_FS by AUTOFS_FS	2023-07-29 14:08:22 -07:00
befs	befs: Replace all non-returning strlcpy with strscpy	2023-05-30 16:42:00 -07:00
bfs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
btrfs	btrfs: fix start transaction qgroup rsv double free	2023-09-19 12:30:23 +02:00
cachefiles	v6.5/vfs.file	2023-06-26 10:14:36 -07:00
ceph	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
coda	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
configfs	fs: consolidate duplicate dt_type helpers	2023-04-03 09:23:54 +02:00
cramfs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
crypto	fscrypt: Replace 1-element array with flexible array	2023-05-23 19:46:09 -07:00
debugfs	debugfs: Correct the 'debugfs_create_str' docs	2023-05-31 19:02:14 +01:00
devpts	devpts: simplify two-level sysctl registration for pty_kern_table	2023-03-13 12:36:34 +01:00
dlm	dlm: fix plock lookup when using multiple lockspaces	2023-09-13 09:53:54 +02:00
ecryptfs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
efivarfs	efivarfs: expose used and total size	2023-05-17 18:21:34 +02:00
efs
erofs	erofs: release ztailpacking pclusters properly	2023-09-13 09:52:58 +02:00
exfat	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
exportfs	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
ext2	\n	2023-06-29 13:39:51 -07:00
ext4	ext4: drop dio overwrite only flag and associated warning	2023-09-19 12:30:22 +02:00
f2fs	f2fs: avoid false alarm of circular locking	2023-09-19 12:30:23 +02:00
fat	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
freevxfs	There is no particular theme here - mainly quick hits all over the tree.	2023-02-23 17:55:40 -08:00
fscache	fscache: Use clear_and_wake_up_bit() in fscache_create_volume_work()	2023-01-30 12:51:54 +00:00
fuse	fuse: nlookup missing decrement in fuse_direntplus_link	2023-09-19 12:30:23 +02:00
gfs2	gfs2: low-memory forced flush fixes	2023-09-19 12:30:13 +02:00
hfs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
hfsplus	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
hostfs	Landlock updates for v6.5-rc1	2023-06-27 17:10:27 -07:00
hpfs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
hugetlbfs	hugetlb: revert use of page_cache_next_miss()	2023-06-23 16:59:32 -07:00
iomap	iomap: Remove large folio handling in iomap_invalidate_folio()	2023-09-13 09:52:58 +02:00
isofs
jbd2	jbd2: correct the end of the journal recovery scan range	2023-09-19 12:30:22 +02:00
jffs2	for-6.5/splice-2023-06-23	2023-06-26 11:52:12 -07:00
jfs	jfs: validate max amount of blocks before allocation.	2023-09-13 09:53:33 +02:00
kernfs	kernfs: fix missing kernfs_iattr_rwsem locking	2023-09-19 12:30:09 +02:00
lockd	fs: lockd: avoid possible wrong NULL parameter	2023-09-13 09:53:33 +02:00
minix	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
netfs	Move netfs_extract_iter_to_sg() to lib/scatterlist.c	2023-06-08 13:42:33 +02:00
nfs	NFSv4/pnfs: minor fix for cleanup path in nfs4_get_device_info	2023-09-19 12:30:12 +02:00
nfs_common	NFSv4.2: remove MODULE_LICENSE in non-modules	2023-04-13 13:13:52 -07:00
nfsd	NFSD: da_addr_body field missing in some GETDEVICEINFO replies	2023-09-13 09:53:33 +02:00
nilfs2	nilfs2: fix WARNING in mark_buffer_dirty due to discarded buffer reuse	2023-09-06 21:22:25 +01:00
nls	fs/nls: make load_nls() take a const parameter	2023-07-25 00:30:02 -05:00
notify	fanotify: disallow mount/sb marks on kernel internal pseudo fs	2023-07-04 13:29:29 +02:00
ntfs	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
ntfs3	driver ntfs3 for linux 6.5	2023-07-07 14:59:38 -07:00
ocfs2	fs: ocfs2: namei: check return value of ocfs2_add_entry()	2023-09-13 09:53:08 +02:00
omfs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
openpromfs
orangefs	orangefs: Provide a splice-read wrapper	2023-05-24 08:42:16 -06:00
overlayfs	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
proc	procfs: block chmod on /proc/thread-self/comm	2023-09-13 09:53:54 +02:00
pstore	pstore/ram: Check start of empty przs during init	2023-09-13 09:53:55 +02:00
qnx4	qnx4: credit contributors in CREDITS	2023-03-14 12:56:30 -06:00
qnx6	qnx6: credit contributor and mark filesystem orphan	2023-03-14 12:56:30 -06:00
quota	quota: fix dqput() to follow the guarantees dquot_srcu should provide	2023-09-13 09:53:13 +02:00
ramfs	- Yosry Ahmed brought back some cgroup v1 stats in OOM logs.	2023-06-28 10:28:11 -07:00
reiserfs	reiserfs: Check the return value from __getblk()	2023-09-13 09:52:57 +02:00
romfs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
smb	smb: propagate error code of extract_sharename()	2023-09-19 12:30:16 +02:00
squashfs	squashfs: fix cache race with migration	2023-07-08 09:29:30 -07:00
sysfs	sysfs: Skip empty folders creation	2023-06-15 13:37:53 +02:00
sysv	for-6.5/splice-2023-06-23	2023-06-26 11:52:12 -07:00
tracefs	fs: port ->mkdir() to pass mnt_idmap	2023-01-19 09:24:26 +01:00
ubifs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
udf	\n	2023-06-29 13:39:51 -07:00
ufs	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
unicode	unicode: remove MODULE_LICENSE in non-modules	2023-04-13 13:13:54 -07:00
vboxsf	hardening fixes for v6.5-rc6	2023-08-08 14:59:49 -07:00
verity	fsverity: skip PKCS#7 parser when keyring is empty	2023-09-13 09:53:55 +02:00
xfs	xfs: convert flex-array declarations in xfs attr shortform objects	2023-07-17 08:48:56 -07:00
zonefs	zonefs: fix synchronous direct writes to sequential files	2023-08-10 12:59:47 +09:00
aio.c	fs/aio: Stop allocating aio rings from HIGHMEM	2023-06-15 09:22:23 +02:00
anon_inodes.c
attr.c	nfs: use vfs setgid helper	2023-03-30 08:51:48 +02:00
bad_inode.c	fs: port ->permission() to pass mnt_idmap	2023-01-19 09:24:28 +01:00
binfmt_elf_fdpic.c	binfmt: Slightly simplify elf_fdpic_map_file()	2023-05-30 15:49:46 -07:00
binfmt_elf_test.c
binfmt_elf.c	Merge branch 'expand-stack'	2023-06-28 20:35:21 -07:00
binfmt_flat.c
binfmt_misc.c	binfmt_misc: fix shift-out-of-bounds in check_special_flags	2022-12-02 13:57:04 -08:00
binfmt_script.c
buffer.c	\n	2023-06-29 13:39:51 -07:00
char_dev.c	vfs: Replace all non-returning strlcpy with strscpy	2023-05-15 09:42:01 +02:00
compat_binfmt_elf.c
coredump.c	v6.5/vfs.misc	2023-06-26 09:50:21 -07:00
d_path.c	fs: d_path: include internal.h	2023-05-17 09:16:59 +02:00
dax.c	dax: enable dax fault handler to report VM_FAULT_HWPOISON	2023-06-26 07:54:23 -06:00
dcache.c
direct-io.c	- Yosry Ahmed brought back some cgroup v1 stats in OOM logs.	2023-06-28 10:28:11 -07:00
drop_caches.c
eventfd.c	eventfd: prevent underflow for eventfd semaphores	2023-09-13 09:52:58 +02:00
eventpoll.c	v6.5/vfs.misc	2023-06-26 09:50:21 -07:00
exec.c	\n	2023-06-29 13:31:44 -07:00
fcntl.c	fs.idmapped.v6.3	2023-02-20 11:53:11 -08:00
fhandle.c	fsnotify: move fsnotify_open() hook into do_dentry_open()	2023-06-12 10:43:45 +02:00
file_table.c	fs: move cleanup from init_file() into its callers	2023-07-02 13:15:49 +02:00
file.c	fs: rely on ->iterate_shared to determine f_pos locking	2023-08-06 15:08:36 +02:00
filesystems.c
fs_context.c	vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing	2023-09-13 09:52:58 +02:00
fs_parser.c	ext4: journal_path mount options should follow links	2022-12-01 10:46:54 -05:00
fs_pin.c
fs_struct.c
fs_types.c
fs-writeback.c	writeback: move wb_over_bg_thresh() call outside lock section	2023-06-09 16:25:14 -07:00
fsopen.c
init.c	fs: port ->permission() to pass mnt_idmap	2023-01-19 09:24:28 +01:00
inode.c	locking: remove spin_lock_prefetch	2023-08-12 09:18:47 -07:00
internal.h	v6.5/vfs.file	2023-06-26 10:14:36 -07:00
ioctl.c	fs: port inode_owner_or_capable() to mnt_idmap	2023-01-19 09:24:29 +01:00
Kconfig	smb: move client and server files to common directory fs/smb	2023-05-24 16:29:21 -05:00
Kconfig.binfmt
kernel_read_file.c
libfs.c	fs: factor out a direct_write_fallback helper	2023-06-09 16:25:53 -07:00
locks.c	filelocks: use mount idmapping for setlease permission check	2023-03-09 22:36:12 +01:00
Makefile	for-6.5/block-2023-06-23	2023-06-26 12:47:20 -07:00
mbcache.c	ext4: fix deadlock due to mbcache entry corruption	2022-12-08 21:49:25 -05:00
mnt_idmapping.c	fs: move mnt_idmap	2023-01-19 09:24:30 +01:00
mount.h
mpage.c	mpage: use folios in bio end_io handler	2023-04-18 16:30:02 -07:00
namei.c	fs: Fix error checking for d_hash_and_lookup()	2023-09-13 09:52:58 +02:00
namespace.c	v6.5/vfs.mount	2023-06-26 10:27:04 -07:00
nsfs.c	kill the last remaining user of proc_ns_fget()	2023-04-20 22:55:35 -04:00
open.c	open: make RESOLVE_CACHED correctly test for O_TMPFILE	2023-08-06 15:08:35 +02:00
pipe.c	pipe: check for IOCB_NOWAIT alongside O_NONBLOCK	2023-05-12 17:17:27 +02:00
pnode.c	fs: allow to mount beneath top mount	2023-05-19 04:30:22 +02:00
pnode.h	fs: allow to mount beneath top mount	2023-05-19 04:30:22 +02:00
posix_acl.c	acl: don't depend on IOP_XATTR	2023-03-06 09:59:20 +01:00
proc_namespace.c	tty, proc, kernfs, random: Use copy_splice_read()	2023-05-24 08:42:16 -06:00
read_write.c	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
readdir.c	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
remap_range.c	fs: use UB-safe check for signed addition overflow in remap_verify_area	2023-05-24 11:03:59 +02:00
select.c
seq_file.c	use less confusing names for iov_iter direction initializers	2022-11-25 13:01:55 -05:00
signalfd.c
splice.c	splice: fsnotify_access(in), fsnotify_modify(out) on success in tee	2023-09-13 09:52:58 +02:00
stack.c
stat.c	fs.idmapped.v6.3	2023-02-20 11:53:11 -08:00
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-17 15:20:17 +02:00
super.c	\n	2023-06-29 13:39:51 -07:00
sync.c
sysctls.c	sysctl: Refactor base paths registrations	2023-05-23 21:43:26 -07:00
timerfd.c
userfaultfd.c	Merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes.	2023-06-23 16:58:19 -07:00
utimes.c	fs.idmapped.v6.3	2023-02-20 11:53:11 -08:00
xattr.c	fs: don't call posix_acl_listxattr in generic_listxattr	2023-05-17 15:25:20 +02:00