Adrian Hunter 6cc4479645 libperf evlist: Fix polling of system-wide events ... Originally, (refer commit f90d194a86 ("perf evlist: Do not poll events that use the system_wide flag") there wasn't much reason to poll system-wide events because: 1. The mmaps get "merged" via set-output anyway (the per-cpu case) 2. perf reads all mmaps when any event is woken 3. system-wide mmaps do not fill up as fast as the mmaps for user selected events But there was 1 reason not to poll which was that it prevented correct termination due to POLLHUP on all user selected events. That issue is now easily resolved by using fdarray_flag__nonfilterable. With the advent of commit ae4f8ae16a ("libperf evlist: Allow mixing per-thread and per-cpu mmaps"), system-wide mmaps can be used also in the per-thread case where reason 1 does not apply. Fix the omission of system-wide events from polling by using the fdarray_flag__nonfilterable flag. Example: Before: $ perf record --no-bpf-event -vvv -e intel_pt// --per-thread uname 2>err.txt Linux $ grep 'sys_perf_event_open.*=\|pollfd' err.txt sys_perf_event_open: pid 155076 cpu -1 group_fd -1 flags 0x8 = 5 sys_perf_event_open: pid 155076 cpu -1 group_fd -1 flags 0x8 = 6 sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 7 sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 9 sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 10 sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 11 sys_perf_event_open: pid -1 cpu 4 group_fd -1 flags 0x8 = 12 sys_perf_event_open: pid -1 cpu 5 group_fd -1 flags 0x8 = 13 sys_perf_event_open: pid -1 cpu 6 group_fd -1 flags 0x8 = 14 sys_perf_event_open: pid -1 cpu 7 group_fd -1 flags 0x8 = 15 thread_data[0x55fb43c29e80]: pollfd[0] <- event_fd=5 thread_data[0x55fb43c29e80]: pollfd[1] <- event_fd=6 thread_data[0x55fb43c29e80]: pollfd[2] <- non_perf_event fd=4 After: $ perf record --no-bpf-event -vvv -e intel_pt// --per-thread uname 2>err.txt Linux $ grep 'sys_perf_event_open.*=\|pollfd' err.txt sys_perf_event_open: pid 156316 cpu -1 group_fd -1 flags 0x8 = 5 sys_perf_event_open: pid 156316 cpu -1 group_fd -1 flags 0x8 = 6 sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 7 sys_perf_event_open: pid -1 cpu 1 group_fd -1 flags 0x8 = 9 sys_perf_event_open: pid -1 cpu 2 group_fd -1 flags 0x8 = 10 sys_perf_event_open: pid -1 cpu 3 group_fd -1 flags 0x8 = 11 sys_perf_event_open: pid -1 cpu 4 group_fd -1 flags 0x8 = 12 sys_perf_event_open: pid -1 cpu 5 group_fd -1 flags 0x8 = 13 sys_perf_event_open: pid -1 cpu 6 group_fd -1 flags 0x8 = 14 sys_perf_event_open: pid -1 cpu 7 group_fd -1 flags 0x8 = 15 thread_data[0x55cc19e58e80]: pollfd[0] <- event_fd=5 thread_data[0x55cc19e58e80]: pollfd[1] <- event_fd=6 thread_data[0x55cc19e58e80]: pollfd[2] <- event_fd=7 thread_data[0x55cc19e58e80]: pollfd[3] <- event_fd=9 thread_data[0x55cc19e58e80]: pollfd[4] <- event_fd=10 thread_data[0x55cc19e58e80]: pollfd[5] <- event_fd=11 thread_data[0x55cc19e58e80]: pollfd[6] <- event_fd=12 thread_data[0x55cc19e58e80]: pollfd[7] <- event_fd=13 thread_data[0x55cc19e58e80]: pollfd[8] <- event_fd=14 thread_data[0x55cc19e58e80]: pollfd[9] <- event_fd=15 thread_data[0x55cc19e58e80]: pollfd[10] <- non_perf_event fd=4 Fixes: ae4f8ae16a ("libperf evlist: Allow mixing per-thread and per-cpu mmaps") Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220915122612.81738-3-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2022-09-21 16:08:00 -03:00
..
accounting
arch	tools kvm headers arm64: Update KVM header from the kernel sources	2022-08-27 11:55:16 -03:00
bootconfig
bpf	bpftool: Complete libbfd feature detection	2022-08-10 10:44:01 -03:00
build	tools build: Switch to new openssl API for test-libcrypto	2022-08-10 10:44:02 -03:00
certs
cgroup	tools: add memcg_shrinker.py	2022-07-03 18:08:40 -07:00
counter
debugging	tools: Add new "test" taint to kernel-chktaint	2022-09-07 14:51:12 -06:00
edid
firewire
firmware
gpio
hv	tools: hv: kvp: remove unnecessary (void*) conversions	2022-09-05 16:55:20 +00:00
iio
include	tools/include/uapi: Fix <asm/errno.h> for parisc and xtensa	2022-09-13 14:04:35 +02:00
io_uring
kvm/kvm_stat
laptop
leds
lib	libperf evlist: Fix polling of system-wide events	2022-09-21 16:08:00 -03:00
memory-model
objtool	Misc fixes:	2022-08-28 10:10:23 -07:00
pci
pcmcia
perf	perf record: Fix cpu mask bit setting for mixed mmaps	2022-09-21 16:08:00 -03:00
power	platform-drivers-x86 for v6.0-1	2022-08-04 18:19:14 -07:00
rcu
scripts
spi
testing	execve reverts for v6.0-rc7	2022-09-20 08:38:55 -07:00
thermal	tools/thermal: Fix possible path truncations	2022-08-03 19:28:46 +02:00
time
tracing	rtla: Consolidate and show all necessary libraries that failed for building	2022-08-10 12:03:02 -04:00
usb	tools: usb: testusb: Add super-plus speed reporting	2022-07-08 14:54:49 +02:00
verification	rv/monitor: Add the wwnr monitor	2022-07-30 14:01:30 -04:00
virtio	tools/virtio: fix build	2022-08-11 04:26:07 -04:00
vm	- The usual batches of cleanups from Baoquan He, Muchun Song, Miaohe	2022-08-05 16:32:45 -07:00
wmi
Makefile