linux/drivers/media
Hans Verkuil 89c08aef8f media: videobuf2: set q->streaming later
Commit a10b215325 ("media: vb2: add (un)prepare_streaming queue ops") moved
up the q->streaming = 1 assignment to before the call to vb2_start_streaming().

This does make sense since q->streaming indicates that VIDIOC_STREAMON is called,
and the call to start_streaming happens either at that time or later if
q->min_buffers_needed > 0. So q->streaming should be 1 before start_streaming
is called.

However, it turned out that some drivers use vb2_is_streaming() in buf_queue,
and if q->min_buffers_needed == 0, then that will now return true instead of
false.

So for the time being revert to the original behavior.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: a10b215325 ("media: vb2: add (un)prepare_streaming queue ops")
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
2023-01-24 16:34:06 +01:00
..
cec media: Switch to use dev_err_probe() helper 2022-12-07 17:58:46 +01:00
common media: videobuf2: set q->streaming later 2023-01-24 16:34:06 +01:00
dvb-core Driver Core changes for 6.2-rc1 2022-12-16 03:54:54 -08:00
dvb-frontends media updates for v6.2-rc1 2022-12-13 11:36:58 -08:00
firewire media: Makefiles: remove extra spaces 2022-03-12 16:59:52 +01:00
i2c Merge tag 'br-v6.2i' of git://linuxtv.org/hverkuil/media_tree into media_stage 2022-12-07 17:58:47 +01:00
mc media: mc: convert pipeline funcs to take media_pad 2022-09-24 09:22:30 +02:00
mmc media: media/*/Kconfig: sort entries 2022-03-18 05:58:35 +01:00
pci treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
platform media updates for v6.2-rc1 2022-12-21 09:44:41 -08:00
radio media: si470x: Fix use-after-free in si470x_int_in_callback() 2022-12-07 17:58:47 +01:00
rc Driver Core changes for 6.2-rc1 2022-12-16 03:54:54 -08:00
spi media updates for v5.18-rc1 2022-03-23 14:51:35 -07:00
test-drivers media updates for v6.2-rc1 2022-12-13 11:36:58 -08:00
tuners Tag branch 2022-11-25 07:55:21 +00:00
usb treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
v4l2-core media: v4l2-ctrls-api.c: move ctrl->is_new = 1 to the correct line 2023-01-22 08:27:33 +01:00
Kconfig media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y 2022-12-07 17:58:46 +01:00
Makefile media: Makefiles: remove extra spaces 2022-03-12 16:59:52 +01:00