Alexander Sverdlin 69a8eed58c mtd: spi-nor: Don't copy self-pointing struct around ... spi_nor_parse_sfdp() modifies the passed structure so that it points to itself (params.erase_map.regions to params.erase_map.uniform_region). This makes it impossible to copy the local struct anywhere else. Therefore only use memcpy() in backup-restore scenario. The bug may show up like below: BUG: unable to handle page fault for address: ffffc90000b377f8 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 4 PID: 3500 Comm: flashcp Tainted: G O 5.4.53-... #1 ... RIP: 0010:spi_nor_erase+0x8e/0x5c0 Code: 64 24 18 89 db 4d 8b b5 d0 04 00 00 4c 89 64 24 18 4c 89 64 24 20 eb 12 a8 10 0f 85 59 02 00 00 49 83 c6 10 0f 84 4f 02 00 00 <49> 8b 06 48 89 c2 48 83 e2 c0 48 89 d1 49 03 4e 08 48 39 cb 73 d8 RSP: 0018:ffffc9000217fc48 EFLAGS: 00010206 RAX: 0000000000740000 RBX: 0000000000000000 RCX: 0000000000740000 RDX: ffff8884550c9980 RSI: ffff88844f9c0bc0 RDI: ffff88844ede7bb8 RBP: 0000000000740000 R08: ffffffff815bfbe0 R09: ffff88844f9c0bc0 R10: 0000000000000000 R11: 0000000000000000 R12: ffffc9000217fc60 R13: ffff88844ede7818 R14: ffffc90000b377f8 R15: 0000000000000000 FS: 00007f4699780500(0000) GS:ffff88846ff00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffc90000b377f8 CR3: 00000004538ee000 CR4: 0000000000340fe0 Call Trace: part_erase+0x27/0x50 mtdchar_ioctl+0x831/0xba0 ? filemap_map_pages+0x186/0x3d0 ? do_filp_open+0xad/0x110 ? _copy_to_user+0x22/0x30 ? cp_new_stat+0x150/0x180 mtdchar_unlocked_ioctl+0x2a/0x40 do_vfs_ioctl+0xa0/0x630 ? __do_sys_newfstat+0x3c/0x60 ksys_ioctl+0x70/0x80 __x64_sys_ioctl+0x16/0x20 do_syscall_64+0x6a/0x200 ? prepare_exit_to_usermode+0x50/0xd0 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f46996b6817 Cc: stable@vger.kernel.org Fixes: c46872170a ("mtd: spi-nor: Move erase_map to 'struct spi_nor_flash_parameter'") Co-developed-by: Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com> Signed-off-by: Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> Tested-by: Baurzhan Ismagulov <ibr@radix50.net> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> Link: https://lore.kernel.org/r/20201005084803.23460-1-alexander.sverdlin@nokia.com		2020-10-28 22:36:30 +05:30
..
accessibility
acpi	More ACPI updates for 5.10-rc1	2020-10-23 16:38:36 -07:00
amba
android	task_work: cleanup notification modes	2020-10-17 15:05:30 -06:00
ata	Merge branch 'parisc-5.10-2' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux	2020-10-25 10:59:34 -07:00
atm
auxdisplay
base	More power management updates for 5.10-rc1	2020-10-23 16:27:03 -07:00
bcma
block	xen: branch for v5.10-rc1c	2020-10-25 10:55:35 -07:00
bluetooth	networking changes for the 5.10 merge window	2020-10-15 18:42:13 -07:00
bus	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
cdrom
char	random32: make prandom_u32() output unpredictable	2020-10-24 20:21:57 +02:00
clk	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
clocksource	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
connector
counter
cpufreq	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
cpuidle	powerpc updates for 5.10	2020-10-16 12:21:15 -07:00
crypto	s390 updates for the 5.10 merge window	2020-10-16 12:36:38 -07:00
dax	fuse update for 5.10	2020-10-19 14:28:30 -07:00
dca
devfreq
dio
dma	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
dma-buf	dma-mapping updates for 5.10	2020-10-15 14:43:29 -07:00
edac	EFI changes for v5.10:	2020-10-12 13:26:49 -07:00
eisa
extcon
firewire
firmware	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
fpga
fsi
gnss
gpio	- New Drivers	2020-10-14 15:56:58 -07:00
gpu	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
greybus
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2020-10-23 16:16:31 -07:00
hsi
hv	Merge branch 'akpm' (patches from Andrew)	2020-10-16 11:31:55 -07:00
hwmon	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
hwspinlock
hwtracing	intel_th: pci: Add Alder Lake CPU support	2020-10-05 12:43:54 +02:00
i2c	i2c: core: Restore acpi_walk_dep_device_list() getting called after registering the ACPI i2c devs	2020-10-25 13:33:54 +01:00
i3c	* Fix DAA for the pre-reserved address case	2020-10-17 11:01:01 -07:00
ide	block-5.10-2020-10-12	2020-10-13 12:12:44 -07:00
idle	intel_idle: Ignore _CST if control cannot be taken from the platform	2020-10-16 17:28:32 +02:00
iio	chrome platform changes for 5.10	2020-10-23 10:54:13 -07:00
infiniband	RDMA 5.10 pull request	2020-10-17 11:18:18 -07:00
input	Merge branch 'parisc-5.10-2' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux	2020-10-25 10:59:34 -07:00
interconnect
iommu	IOMMU Fix for Linux v5.10:	2020-10-20 09:35:06 -07:00
ipack
irqchip	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
isdn
leds	leds: pwm: Remove platform_data support	2020-10-07 12:02:58 +02:00
lightnvm	lightnvm: fix out-of-bounds write to array devices->info[]	2020-10-16 09:28:45 -06:00
macintosh	powerpc updates for 5.10	2020-10-16 12:21:15 -07:00
mailbox	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
mcb
md	- Improve DM core's bio splitting to use blk_max_size_offset(). Also	2020-10-14 15:05:38 -07:00
media	dma-mapping updates for 5.10	2020-10-15 14:43:29 -07:00
memory	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
memstick
message	SCSI misc on 20201013	2020-10-14 15:15:35 -07:00
mfd	- New Drivers	2020-10-14 15:56:58 -07:00
misc	pci-v5.10-changes	2020-10-22 12:41:00 -07:00
mmc	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
most
mtd	mtd: spi-nor: Don't copy self-pointing struct around	2020-10-28 22:36:30 +05:30
mux
net	Fixes for 5.10-rc1 from the networking tree:	2020-10-23 12:05:49 -07:00
nfc	nfc: remove unneeded break	2020-10-20 10:36:41 -07:00
ntb	Bug fixes for v5.10	2020-10-25 11:12:31 -07:00
nubus
nvdimm	mm/memremap_pages: support multiple ranges per invocation	2020-10-13 18:38:28 -07:00
nvme	nvme-fc: shorten reconnect delay if possible for FC	2020-10-23 12:54:45 +02:00
nvmem
of	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
opp	Merge branch 'cpufreq/arm/linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm	2020-10-06 12:26:45 +02:00
oprofile
parisc	dma-mapping: split <linux/dma-mapping.h>	2020-10-06 07:07:03 +02:00
parport
pci	VFIO updates for v5.10-rc1	2020-10-22 13:00:44 -07:00
pcmcia
perf
phy	pci-v5.10-changes	2020-10-22 12:41:00 -07:00
pinctrl	Pin control bulk changes for the v5.10 kernel cycle	2020-10-14 15:25:04 -07:00
platform	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2020-10-23 16:16:31 -07:00
pnp	PNP: remove the now unused pnp_find_card() function	2020-10-08 18:00:08 +02:00
power	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
powercap	powercap: Fix typo in Kconfig "Plance" -> "Plane"	2020-10-19 17:40:53 +02:00
pps
ps3
ptp
pwm	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
rapidio	rapidio: fix the missed put_device() for rio_mport_add_riodev	2020-10-16 11:11:22 -07:00
ras
regulator	Merge remote-tracking branch 'regulator/for-5.10' into regulator-next	2020-10-05 16:54:56 +01:00
remoteproc	remoteproc updates for v5.10	2020-10-22 12:56:33 -07:00
reset	ARM: SoC-related driver updates	2020-10-24 10:39:22 -07:00
rpmsg	rpmsg updates for 5.10	2020-10-22 12:58:21 -07:00
rtc	RTC for 5.10	2020-10-21 11:22:08 -07:00
s390	s390 updates for the 5.10 merge window	2020-10-16 12:36:38 -07:00
sbus
scsi	block-5.10-2020-10-24	2020-10-24 12:46:42 -07:00
sfi
sh
siox
slimbus
soc	ARM: Devicetree updates	2020-10-24 10:44:18 -07:00
soundwire
spi	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
spmi
ssb
staging	mm: remove kzfree() compatibility definition	2020-10-25 11:39:02 -07:00
target	SCSI misc on 20201023	2020-10-23 16:19:02 -07:00
tc
tee
thermal	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
thunderbolt
tty	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
uio
usb	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
vdpa	vhost,vdpa,virtio: cleanups, fixes	2020-10-23 11:00:57 -07:00
vfio	VFIO updates for v5.10-rc1	2020-10-22 13:00:44 -07:00
vhost	vhost_vdpa: remove unnecessary spin_lock in vhost_vring_call	2020-10-21 10:48:10 -04:00
video	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
virt
virtio	vhost,vdpa,virtio: cleanups, fixes	2020-10-23 11:00:57 -07:00
visorbus
vlynq
vme
w1	w1: w1_therm: make w1_poll_completion static	2020-10-05 14:49:24 +02:00
watchdog	ARM: SoC platform updates	2020-10-24 10:33:08 -07:00
xen	xen: branch for v5.10-rc1c	2020-10-25 10:55:35 -07:00
zorro
Kconfig
Makefile