Boqun Feng bd9afea9bd locking/lockdep: Avoid recursion in lockdep_count_{for,back}ward_deps() ... [ Upstream commit 25016bd7f4 ] Qian Cai reported a bug when PROVE_RCU_LIST=y, and read on /proc/lockdep triggered a warning: [ ] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled) ... [ ] Call Trace: [ ] lock_is_held_type+0x5d/0x150 [ ] ? rcu_lockdep_current_cpu_online+0x64/0x80 [ ] rcu_read_lock_any_held+0xac/0x100 [ ] ? rcu_read_lock_held+0xc0/0xc0 [ ] ? __slab_free+0x421/0x540 [ ] ? kasan_kmalloc+0x9/0x10 [ ] ? __kmalloc_node+0x1d7/0x320 [ ] ? kvmalloc_node+0x6f/0x80 [ ] __bfs+0x28a/0x3c0 [ ] ? class_equal+0x30/0x30 [ ] lockdep_count_forward_deps+0x11a/0x1a0 The warning got triggered because lockdep_count_forward_deps() call __bfs() without current->lockdep_recursion being set, as a result a lockdep internal function (__bfs()) is checked by lockdep, which is unexpected, and the inconsistency between the irq-off state and the state traced by lockdep caused the warning. Apart from this warning, lockdep internal functions like __bfs() should always be protected by current->lockdep_recursion to avoid potential deadlocks and data inconsistency, therefore add the current->lockdep_recursion on-and-off section to protect __bfs() in both lockdep_count_forward_deps() and lockdep_count_backward_deps() Reported-by: Qian Cai <cai@lca.pw> Signed-off-by: Boqun Feng <boqun.feng@gmail.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20200312151258.128036-1-boqun.feng@gmail.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-04-17 10:50:05 +02:00
..
bpf	bpf: Explicitly memset some bpf info structures declared on the stack	2020-04-02 15:11:01 +02:00
cgroup	cgroup1: don't call release_agent when it is ""	2020-04-01 11:01:51 +02:00
configs
debug	kgdb: don't use a notifier to enter kgdb at panic; call directly	2019-09-25 17:51:40 -07:00
dma	dma-mapping: Fix dma_pgprot() for unencrypted coherent pages	2020-04-17 10:50:01 +02:00
events	perf/core: Fix mlock accounting in perf_mmap()	2020-02-11 04:35:54 -08:00
gcov	Revert "um: Enable CONFIG_CONSTRUCTORS"	2020-02-01 09:34:53 +00:00
irq	genirq/irqdomain: Check pointer in irq_domain_alloc_irqs_hierarchy()	2020-04-17 10:50:04 +02:00
livepatch	livepatch: Nullify obj->mod in klp_module_coming()'s error path	2019-08-19 13:03:37 +02:00
locking	locking/lockdep: Avoid recursion in lockdep_count_{for,back}ward_deps()	2020-04-17 10:50:05 +02:00
power	ACPI: PM: s2idle: Avoid possible race related to the EC GPE	2020-02-19 19:52:56 +01:00
printk	printk: fix exclusive_console replaying	2020-02-24 08:36:24 +01:00
rcu	rcu: Allow only one expedited GP to run concurrently with wakeups	2020-03-05 16:43:50 +01:00
sched	sched: Avoid scale real weight down to zero	2020-04-17 10:50:02 +02:00
time	time/sched_clock: Expire timer in hardirq context	2020-04-17 10:50:02 +02:00
trace	bpf: Fix deadlock with rq_lock in bpf_send_signal()	2020-04-17 10:49:57 +02:00
.gitignore	Provide in-kernel headers to make extending kernel easier	2019-04-29 16:48:03 +02:00
acct.c	acct_on(): don't mess with freeze protection	2019-04-04 21:04:13 -04:00
async.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
audit_fsnotify.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
audit_tree.c	fsnotify: switch send_to_group() and ->handle_event to const struct qstr *	2019-04-26 13:51:03 -04:00
audit_watch.c	audit_get_nd(): don't unlock parent too early	2019-11-10 11:56:55 -05:00
audit.c	audit: always check the netlink payload length in audit_receive_msg()	2020-03-05 16:43:42 +01:00
audit.h	audit/stable-5.3 PR 20190702	2019-07-08 18:55:42 -07:00
auditfilter.c	audit: fix error handling in audit_data_to_entry()	2020-03-05 16:43:42 +01:00
auditsc.c	audit: enforce op for string fields	2019-05-28 17:46:43 -04:00
backtracetest.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
bounds.c
capability.c
compat.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
configs.c	kernel/configs: Replace GPL boilerplate code with SPDX identifier	2019-07-30 18:34:15 +02:00
context_tracking.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
cpu_pm.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
cpu.c	cpu/hotplug, stop_machine: Fix stop_machine vs hotplug order	2020-02-24 08:36:23 +01:00
crash_core.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230	2019-06-19 17:09:06 +02:00
crash_dump.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
cred.c	keys: Fix request_key() cache	2020-01-17 19:48:42 +01:00
delayacct.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 25	2019-05-21 11:52:39 +02:00
dma.c
elfcore.c	kernel/elfcore.c: include proper prototypes	2019-09-25 17:51:39 -07:00
exec_domain.c
exit.c	exit: panic before exit_mm() on global init exit	2020-01-09 10:20:01 +01:00
extable.c	extable: Add function to search only kernel exception table	2019-08-21 22:23:48 +10:00
fail_function.c	fail_function: no need to check return value of debugfs_create functions	2019-06-03 15:49:06 +02:00
fork.c	mm: fork: fix kernel_stack memcg stats for various stack implementations	2020-04-01 11:02:03 +02:00
freezer.c	Revert "libata, freezer: avoid block device removal while system is frozen"	2019-10-06 09:11:37 -06:00
futex.c	futex: Unbreak futex hashing	2020-03-25 08:25:58 +01:00
gen_kheaders.sh	kheaders: substituting --sort in archive creation	2019-10-17 09:08:19 +09:00
groups.c
hung_task.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
iomem.c	mm/nvdimm: add is_ioremap_addr and use that to check ioremap address	2019-07-12 11:05:40 -07:00
irq_work.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
jump_label.c	jump_label: Don't warn on __exit jump entries	2019-08-29 15:10:10 +01:00
kallsyms.c	kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol	2019-08-27 16:19:56 +01:00
kcmp.c
Kconfig.freezer	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Kconfig.hz	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Kconfig.locks	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Kconfig.preempt	sched/rt, Kconfig: Unbreak def/oldconfig with CONFIG_PREEMPT=y	2019-07-22 18:05:11 +02:00
kcov.c	kcov: convert kcov.refcount to refcount_t	2019-03-07 18:32:02 -08:00
kexec_core.c	kexec: bail out upon SIGKILL when allocating memory.	2019-09-25 17:51:40 -07:00
kexec_elf.c	kexec_elf: support 32 bit ELF files	2019-09-06 23:58:44 +02:00
kexec_file.c	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
kexec_internal.h
kexec.c	kexec_load: Disable at runtime if the kernel is locked down	2019-08-19 21:54:15 -07:00
kheaders.c	kheaders: Move from proc to sysfs	2019-05-24 20:16:01 +02:00
kmod.c
kprobes.c	kprobes: Fix optimize_kprobe()/unoptimize_kprobe() cancellation logic	2020-03-12 13:00:09 +01:00
ksysfs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 170	2019-05-30 11:26:39 -07:00
kthread.c	kthread: make __kthread_queue_delayed_work static	2019-10-16 09:20:58 -07:00
latencytop.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
Makefile	Merge branch 'next-integrity' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity	2019-09-27 19:37:27 -07:00
module_signature.c	MODSIGN: Export module signature definitions	2019-08-05 18:39:56 -04:00
module_signing.c	MODSIGN: Export module signature definitions	2019-08-05 18:39:56 -04:00
module-internal.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36	2019-05-24 17:27:11 +02:00
module.c	module: avoid setting info->name early in case we can fall back to info->mod->name	2020-02-24 08:36:54 +01:00
notifier.c	x86/mm: split vmalloc_sync_all()	2020-03-25 08:25:58 +01:00
nsproxy.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
padata.c	padata: always acquire cpu_hotplug_lock before pinst->lock	2020-04-08 09:08:47 +02:00
panic.c	panic: ensure preemption is disabled during panic()	2019-10-07 15:47:19 -07:00
params.c	lockdown: Lock down module params that specify hardware parameters (eg. ioport)	2019-08-19 21:54:16 -07:00
pid_namespace.c	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
pid.c	kernel/pid.c: convert struct pid count to refcount_t	2019-07-16 19:23:24 -07:00
profile.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
ptrace.c	ptrace: reintroduce usage of subjective credentials in ptrace_has_cap()	2020-01-23 08:22:36 +01:00
range.c
reboot.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
relay.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-03-12 13:27:20 -07:00
resource.c	mm/memory_hotplug.c: use PFN_UP / PFN_DOWN in walk_system_ram_range()	2019-09-24 15:54:09 -07:00
rseq.c	signal: Remove task parameter from force_sig	2019-05-27 09:36:28 -05:00
seccomp.c	seccomp: Check that seccomp_notif is zeroed out by the user	2020-01-09 10:19:57 +01:00
signal.c	signal: avoid double atomic counter increments for user accounting	2020-03-21 08:11:53 +01:00
smp.c	smp: Warn on function calls from softirq context	2019-07-20 11:27:16 +02:00
smpboot.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
smpboot.h
softirq.c	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-07-08 11:01:13 -07:00
stackleak.c
stacktrace.c	stacktrace: Don't skip first entry on noncurrent tasks	2019-11-04 21:19:25 +01:00
stop_machine.c	stop_machine: Avoid potential race behaviour	2019-10-17 12:47:12 +02:00
sys_ni.c	arch: handle arches who do not yet define clone3	2019-06-21 01:54:53 +02:00
sys.c	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-09-17 12:35:15 -07:00
sysctl_binary.c
sysctl.c	kernel: sysctl: make drop_caches write-only	2020-01-04 19:18:32 +01:00
task_work.c
taskstats.c	taskstats: fix data-race	2020-01-09 10:19:54 +01:00
test_kprobes.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 25	2019-05-21 11:52:39 +02:00
torture.c	torture: Remove exporting of internal functions	2019-08-01 14:30:22 -07:00
tracepoint.c	The main changes in this release include:	2019-07-18 11:51:00 -07:00
tsacct.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
ucount.c	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
uid16.c
uid16.h
umh.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
up.c	smp: Remove smp_call_function() and on_each_cpu() return values	2019-06-23 14:26:26 +02:00
user_namespace.c	Keyrings namespacing	2019-07-08 19:36:47 -07:00
user-return-notifier.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
user.c	Keyrings namespacing	2019-07-08 19:36:47 -07:00
utsname_sysctl.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
utsname.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
watchdog_hld.c	kernel/watchdog_hld.c: hard lockup message should end with a newline	2019-04-19 09:46:05 -07:00
watchdog.c	watchdog/softlockup: Enforce that timestamp is valid on boot	2020-02-24 08:36:52 +01:00
workqueue_internal.h	sched/core, workqueues: Distangle worker accounting from rq lock	2019-04-16 16:55:15 +02:00
workqueue.c	workqueue: don't use wq_select_unbound_cpu() for bound works	2020-03-18 07:17:50 +01:00