Varun Sethi 5a9137a66b iommu/fsl: Fix warning resulting from adding PCI device twice ... iommu_group_get_for_dev determines the iommu group for the PCI device and adds the device to the group. In the PAMU driver we were again adding the device to the same group without checking if the device already had an iommu group. This resulted in the following warning. sysfs: cannot create duplicate filename '/devices/ffe200000.pcie/pci0000:00/0000:00:00.0/iommu_group' ------------[ cut here ]------------ WARNING: at fs/sysfs/dir.c:31 Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.17.0-rc3-00002-g7505cea-dirty #126 task: c0000001fe0a0000 ti: c0000001fe044000 task.ti: c0000001fe044000 NIP: c00000000018879c LR: c000000000188798 CTR: c00000000001ea50 REGS: c0000001fe047040 TRAP: 0700 Not tainted (3.17.0-rc3-00002-g7505cea-dirty) MSR: 0000000080029000 <CE,EE,ME> CR: 24ad8e22 XER: 20000000 SOFTE: 1 GPR00: c000000000188798 c0000001fe0472c0 c0000000009a52e0 0000000000000065 GPR04: 0000000000000001 0000000000000000 3a30303a00000000 0000000027000000 GPR08: 2f696f6d00000000 c0000000008d3830 c0000000009b3938 c0000000009bb3d0 GPR12: 0000000028ad8e24 c00000000fff4000 c00000000000205c 0000000000000000 GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 GPR20: 0000000000000000 0000000000000000 0000000000000000 c0000000008a4c70 GPR24: c0000000007e9010 c0000001fe0140a8 ffffffffffffffef 0000000000000001 GPR28: c0000001fe22ebb8 c0000000007e9010 c00000000090bf10 c0000001fe220000 NIP [c00000000018879c] .sysfs_warn_dup+0x74/0xa4 LR [c000000000188798] .sysfs_warn_dup+0x70/0xa4 Call Trace: [c0000001fe0472c0] [c000000000188798] .sysfs_warn_dup+0x70/0xa4 (unreliable) [c0000001fe047350] [c000000000188d34] .sysfs_do_create_link_sd.clone.2+0x168/0x174 [c0000001fe047400] [c0000000004b3cf8] .iommu_group_add_device+0x78/0x244 [c0000001fe0474b0] [c0000000004b6964] .fsl_pamu_add_device+0x88/0x1a8 [c0000001fe047570] [c0000000004b3960] .iommu_bus_notifier+0xdc/0x15c [c0000001fe047600] [c000000000059848] .notifier_call_chain+0x8c/0xe8 [c0000001fe0476a0] [c000000000059d04] .__blocking_notifier_call_chain+0x58/0x84 [c0000001fe047750] [c00000000036619c] .device_add+0x464/0x5c8 [c0000001fe047820] [c000000000300ebc] .pci_device_add+0x14c/0x17c [c0000001fe0478c0] [c000000000300fbc] .pci_scan_single_device+0xd0/0xf4 [c0000001fe047970] [c00000000030104c] .pci_scan_slot+0x6c/0x18c [c0000001fe047a10] [c00000000030226c] .pci_scan_child_bus+0x40/0x114 [c0000001fe047ac0] [c000000000021974] .pcibios_scan_phb+0x240/0x2c8 [c0000001fe047b70] [c00000000085a970] .pcibios_init+0x64/0xc8 [c0000001fe047c00] [c000000000001884] .do_one_initcall+0xbc/0x224 [c0000001fe047d00] [c000000000852d50] .kernel_init_freeable+0x14c/0x21c [c0000001fe047db0] [c000000000002078] .kernel_init+0x1c/0xfa4 [c0000001fe047e30] [c000000000000884] .ret_from_kernel_thread+0x58/0xd4 Instruction dump: 7c7f1b79 4182001c 7fe4fb78 7f83e378 38a01000 4bffc905 60000000 7c641b78 e87e8008 7fa5eb78 48482ff5 60000000 <0fe00000> 7fe3fb78 4bf7bd39 60000000 Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com> Cc: stable@vger.kernel.org Signed-off-by: Joerg Roedel <jroedel@suse.de>		2014-09-05 16:01:46 +02:00
..
amd_iommu_init.c	iommu/amd: Add sysfs support	2014-07-04 12:35:59 +02:00
amd_iommu_proto.h	perf/x86/amd: Add IOMMU Performance Counter resource management	2013-06-19 13:04:52 +02:00
amd_iommu_types.h	Merge branches 'x86/vt-d', 'x86/amd', 'arm/omap', 'ppc/pamu', 'arm/smmu', 'arm/exynos' and 'core' into next	2014-07-31 20:29:02 +02:00
amd_iommu_v2.c	iommu/amd: Fix 2 typos in comments	2014-07-30 16:07:50 +02:00
amd_iommu.c	iommu/amd: Fix cleanup_domain for mass device removal	2014-08-18 13:37:56 +02:00
arm-smmu.c	iommu/arm-smmu: fix corner cases in address size calculations	2014-09-02 10:04:43 +01:00
dmar.c	iommu/vt-d: Check return value of acpi_bus_get_device()	2014-08-26 11:15:17 +02:00
exynos-iommu.c	iommu: Constify struct iommu_ops	2014-07-07 10:36:59 +02:00
fsl_pamu_domain.c	iommu/fsl: Fix warning resulting from adding PCI device twice	2014-09-05 16:01:46 +02:00
fsl_pamu_domain.h	iommu/fsl: Freescale PAMU driver and iommu implementation.	2013-08-14 11:38:34 +02:00
fsl_pamu.c	Merge branches 'x86/vt-d', 'x86/amd', 'arm/omap', 'ppc/pamu', 'arm/smmu', 'arm/exynos' and 'core' into next	2014-07-31 20:29:02 +02:00
fsl_pamu.h	iommu/fsl: Freescale PAMU driver and iommu implementation.	2013-08-14 11:38:34 +02:00
intel_irq_remapping.c	iommu/vt-d: Fix race setting IRQ CPU affinity while freeing IRQ	2014-07-31 13:45:05 +02:00
intel-iommu.c	iommu/vt-d: Defer domain removal if device is assigned to a driver	2014-08-18 13:37:56 +02:00
iommu-sysfs.c	iommu: Fix compile error in iommu-sysfs.c	2014-07-07 12:01:21 +02:00
iommu-traces.c	iommu: Add iommu_error class event to iommu trace	2013-09-25 11:07:04 +02:00
iommu.c	iommu/core: Make iommu_group_get_for_dev() more robust	2014-08-26 11:15:10 +02:00
iova.c	iommu/vt-d: Update IOMMU state when memory hotplug happens	2014-03-04 17:51:06 +01:00
ipmmu-vmsa.c	iommu: Constify struct iommu_ops	2014-07-07 10:36:59 +02:00
irq_remapping.c	x86: irq_remapping: Use irq_alloc/free_hwirq()	2014-05-16 14:05:18 +02:00
irq_remapping.h	iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets	2013-04-18 17:00:47 +02:00
Kconfig	Merge branches 'x86/vt-d', 'x86/amd', 'arm/omap', 'ppc/pamu', 'arm/smmu', 'arm/exynos' and 'core' into next	2014-07-31 20:29:02 +02:00
Makefile	Merge branches 'x86/vt-d', 'x86/amd', 'arm/omap', 'ppc/pamu', 'arm/smmu', 'arm/exynos' and 'core' into next	2014-07-31 20:29:02 +02:00
msm_iommu_dev.c	iommu/msm: Use devm_ioremap_resource to simplify code	2014-05-30 20:20:12 +02:00
msm_iommu_hw-8xxx.h	iommu/msm: Move mach includes to iommu directory	2013-08-06 11:18:03 -07:00
msm_iommu.c	iommu: Constify struct iommu_ops	2014-07-07 10:36:59 +02:00
msm_iommu.h	iommu/msm: Move mach includes to iommu directory	2013-08-06 11:18:03 -07:00
of_iommu.c	iommu: add missing include	2014-01-07 15:16:27 +01:00
omap-iommu2.c	iommu/omap: Enable bus-error back on supported iommus	2014-03-04 17:02:08 +01:00
omap-iommu-debug.c	iommu/omap: Remove virtual memory manager	2014-07-29 12:38:07 +02:00
omap-iommu.c	Merge branches 'x86/vt-d', 'x86/amd', 'arm/omap', 'ppc/pamu', 'arm/smmu', 'arm/exynos' and 'core' into next	2014-07-31 20:29:02 +02:00
omap-iommu.h	iommu/omap: Remove virtual memory manager	2014-07-29 12:38:07 +02:00
omap-iopgtable.h	iommu/omap: Move to_iommu definition from omap-iopgtable.h	2014-04-16 16:30:15 +02:00
shmobile-iommu.c	iommu: Constify struct iommu_ops	2014-07-07 10:36:59 +02:00
shmobile-ipmmu.c	iommu/shmobile: Use devm_ioremap_resource()	2014-04-17 12:16:12 +02:00
shmobile-ipmmu.h	iommu/shmobile: Turn the flush_lock mutex into a spinlock	2014-01-07 15:35:25 +01:00
tegra-gart.c	iommu: Constify struct iommu_ops	2014-07-07 10:36:59 +02:00
tegra-smmu.c	ARM: SoC cleanups for 3.17	2014-08-08 11:00:26 -07:00