linux/drivers/virtio
Amit Shah 31a3ddda16 virtio_pci: Prevent double-free of pci regions after device hot-unplug
In the case where a virtio-console port is in use (opened by a program)
and a virtio-console device is removed, the port is kept around but all
the virtio-related state is assumed to be gone.

When the port is finally released (close() called), we call
device_destroy() on the port's device.  This results in the parent
device's structures to be freed as well.  This includes the PCI regions
for the virtio-console PCI device.

Once this is done, however, virtio_pci_release_dev() kicks in, as the
last ref to the virtio device is now gone, and attempts to do

     pci_iounmap(pci_dev, vp_dev->ioaddr);
     pci_release_regions(pci_dev);
     pci_disable_device(pci_dev);

which results in a double-free warning.

Move the code that releases regions, etc., to the virtio_pci_remove()
function, and all that's now left in release_dev is the final freeing of
the vp_dev.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-04-21 22:57:00 +09:30
..
config.c Virtio interface 2007-10-23 15:49:54 +10:00
Kconfig virtio: balloon driver 2008-02-04 23:50:13 +11:00
Makefile virtio: balloon driver 2008-02-04 23:50:13 +11:00
virtio_balloon.c virtio_balloon: use virtqueue_xxx wrappers 2010-05-19 22:15:41 +09:30
virtio_pci.c virtio_pci: Prevent double-free of pci regions after device hot-unplug 2011-04-21 22:57:00 +09:30
virtio_ring.c virtio: Decrement avail idx on buffer detach 2011-04-21 22:57:00 +09:30
virtio.c virtio: fix format of sysfs driver/vendor files 2010-11-24 15:21:12 +10:30