Sebastian Andrzej Siewior 21a061772b hsr: Synchronize sequence number updates. ... [ Upstream commit 5c7aa13210 ] hsr_register_frame_out() compares new sequence_nr vs the old one recorded in hsr_node::seq_out and if the new sequence_nr is higher then it will be written to hsr_node::seq_out as the new value. This operation isn't locked so it is possible that two frames with the same sequence number arrive (via the two slave devices) and are fed to hsr_register_frame_out() at the same time. Both will pass the check and update the sequence counter later to the same value. As a result the content of the same packet is fed into the stack twice. This was noticed by running ping and observing DUP being reported from time to time. Instead of using the hsr_priv::seqnr_lock for the whole receive path (as it is for sending in the master node) add an additional lock that is only used for sequence number checks and updates. Add a per-node lock that is used during sequence number reads and updates. Fixes: f421436a59 ("net/hsr: Add support for the High-availability Seamless Redundancy protocol (HSRv0)") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-12-31 13:14:15 +01:00
..
hsr_debugfs.c	/net/hsr: fix misspellings using codespell tool	2021-03-18 19:13:41 -07:00
hsr_device.c	hsr: Synchronize sending frames to have always incremented outgoing seq nr.	2022-12-31 13:14:15 +01:00
hsr_device.h	net: hsr: add offloading support	2021-02-11 13:24:44 -08:00
hsr_forward.c	hsr: Synchronize sending frames to have always incremented outgoing seq nr.	2022-12-31 13:14:15 +01:00
hsr_forward.h	net: hsr: fix mac_len checks	2021-05-24 14:10:28 -07:00
hsr_framereg.c	hsr: Synchronize sequence number updates.	2022-12-31 13:14:15 +01:00
hsr_framereg.h	hsr: Synchronize sequence number updates.	2022-12-31 13:14:15 +01:00
hsr_main.c	net: use eth_hw_addr_set() instead of ether_addr_copy()	2022-08-31 17:16:37 +02:00
hsr_main.h	net: hsr: fix mac_len checks	2021-05-24 14:10:28 -07:00
hsr_netlink.c	genetlink: move to smaller ops wherever possible	2020-10-02 19:11:11 -07:00
hsr_netlink.h	hsr: enhance netlink socket interface to support PRP	2020-07-27 12:20:40 -07:00
hsr_slave.c	net: hsr: fix mac_len checks	2021-05-24 14:10:28 -07:00
hsr_slave.h	net: prp: add packet handling support	2020-07-27 12:20:40 -07:00
Kconfig	hsr: enhance netlink socket interface to support PRP	2020-07-27 12:20:40 -07:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00